Share Highlight: incorrect height when the preview dialog is initially opened
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	lwatson
	Apr 30 2026, 4:20 PM

Project Tags

Referenced Files

	F80968207: load_ article highlight2.gif
	May 11 2026, 9:09 PM

	F79956960: ShareHighlight bug dialog height.mov
	May 6 2026, 7:46 PM

	F79955835: ShareHighlight bug card clipped.png
	May 6 2026, 7:29 PM

	F79955814: ShareHighlight bug card overflows dialog.png
	May 6 2026, 7:29 PM

	F79637584: ShareHighlight-bug-dialog-height.png
	May 4 2026, 3:02 PM

Subscribers

Description

Steps to replicate the issue (include links if applicable):

Open share dialog
Observe the open dialog. Notice the height is shorter than expected.
Close the dialog.
Re-open the dialog and notice that the height is correct.

ShareHighlight bug dialog height.mov3 MBDownload

What happens?:

The dialog height is short and unscrollable. The quote card is cut off and not fully displayed.

Screenshot from Apple Simulator:

ShareHighlight-bug-dialog-height.png (796×1,566 px, 501 KB)

What should have happened instead?:

The dialog's height can grow up to the full viewport height minus 2rems (max-height: calc(100vh - 2rem)).
Overflow content should be scrollable.
The quote card is fully visible or visible via scroll.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Browsers impacted: macOS Safari, macOS Apple Simulator, iOS Chrome, iOS Firefox

Acceptance Criteria:

Dialog displays correct height
Vertical overflow content is scrollable

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Don't perform API call until needed	mediawiki/extensions/ReaderExperiments	master	+1 -1
	Share Highlight: fix dialog height bug	mediawiki/extensions/ReaderExperiments	master	+18 -9

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T416432 [Epic] Share Card experiment
Resolved		KSarabia-WMF	T424591 [Share Highlights] Bug Bash
Resolved	BUG REPORT	lwatson	T425013 Share Highlight: incorrect height when the preview dialog is initially opened

Event Timeline

lwatson created this task.Apr 30 2026, 4:20 PM

lwatson renamed this task from Share Highlight: incorrect height when the preview dialog is initially opened on Safari to Share Highlight: incorrect height when the preview dialog is initially opened.May 4 2026, 3:02 PM

lwatson updated the task description. (Show Details)

lwatson edited projects, added: Reader Growth Team (Sprint 3 (Apr 29 - May 12) Q4 25/26); removed: Reader Growth Team.

does this always occur or is it on specific devices, etc.?

SherryYang-WMF triaged this task as High priority.May 5 2026, 4:15 PM

lwatson claimed this task.May 6 2026, 1:13 PM

lwatson moved this task from Committed to Doing on the Reader Growth Team (Sprint 3 (Apr 29 - May 12) Q4 25/26) board.May 6 2026, 6:04 PM

Change #1283894 had a related patch set uploaded (by LWatson; author: LWatson):

[mediawiki/extensions/ReaderExperiments@master] Share Highlight: fix dialog height bug

https://gerrit.wikimedia.org/r/1283894

gerritbot added a project: Patch-For-Review.May 6 2026, 7:17 PM

The issue is specific to Safari/WebKit, which did not properly reflow the dialog to accommodate its growth when the summary API resolved, resulting in the card being cut off.

Other bugs resolved in the same patch:

Resolved card overflowing the dialog.
Resolved card content clipping.

lwatson changed the task status from Open to In Progress.May 6 2026, 7:46 PM

lwatson updated the task description. (Show Details)

lwatson moved this task from Doing to Code Review on the Reader Growth Team (Sprint 3 (Apr 29 - May 12) Q4 25/26) board.

Change #1283894 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@master] Share Highlight: fix dialog height bug

https://gerrit.wikimedia.org/r/1283894

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.2; 2026-05-12).May 6 2026, 10:00 PM

Looks clean and runs correctly in my local testing in iOS Simulator and desktop Safari. +2'd, merged, and moving task to QA column.

Maintenance_bot removed a project: Patch-For-Review.May 6 2026, 10:31 PM

Change #1284758 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/ReaderExperiments@master] Don't perform API call until needed

https://gerrit.wikimedia.org/r/1284758

gerritbot added a project: Patch-For-Review.May 7 2026, 5:56 PM

lwatson updated the task description. (Show Details)May 8 2026, 4:10 PM

Etonkovidova mentioned this in T424667: [QA task] Share highlight - production check.May 11 2026, 9:03 PM

Thanks, @lwatson - I noticed the same issues (https://phabricator.wikimedia.org/T425013#11896017) when checking production. No issues are present in enwiki beta
The gif shows that the card loads correctly on the first click.

load_ article highlight2.gif (359×825 px, 476 KB)

@bvibber - thank you for confirming the fixes! Based on this task, I've added additional cases to check in production to T424667: [QA task] Share highlight - production check

lwatson set the point value for this task to 1.May 12 2026, 1:46 PM

mfossati closed this task as Resolved.May 12 2026, 1:56 PM

mfossati added a project: FY2025-26 WE3.1 Engaging New Audiences.

Change #1284758 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@master] Don't perform API call until needed

https://gerrit.wikimedia.org/r/1284758

ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.3; 2026-05-19); removed: MW-1.47-notes (1.47.0-wmf.2; 2026-05-12).Mon, May 18, 12:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mon, May 18, 12:31 PM

bvibber unsubscribed.Mon, May 18, 3:10 PM