Skip to content

[AIR] Add artifact_location, run_name to MLFlow integration#33641

Merged
Yard1 merged 3 commits into
ray-project:masterfrom
Yard1:mlflow_artifact_location
Mar 28, 2023
Merged

[AIR] Add artifact_location, run_name to MLFlow integration#33641
Yard1 merged 3 commits into
ray-project:masterfrom
Yard1:mlflow_artifact_location

Conversation

@Yard1

@Yard1 Yard1 commented Mar 23, 2023

Copy link
Copy Markdown
Member

Why are these changes needed?

Allows users to pass the artifact_location argument of mlflow.create_experiment and the run_name argument in setup_mlflow.

This has been requested by a user.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1 Yard1 marked this pull request as ready for review March 23, 2023 21:07
@Yard1 Yard1 requested review from amogkam and krfricke March 23, 2023 21:07
Yard1 added 2 commits March 27, 2023 16:58
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1 Yard1 changed the title [AIR] Add artifact_location to MLFlow integration [AIR] Add artifact_location, run_name to MLFlow integration Mar 27, 2023

@krfricke krfricke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Yard1 Yard1 merged commit 7244669 into ray-project:master Mar 28, 2023
@Yard1 Yard1 deleted the mlflow_artifact_location branch March 28, 2023 16:18
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
…project#33641)

* [AIR] Add artifact_location to MLFlow integration

Allows users to pass the artifact_location argument of mlflow.create_experiment and the run_name argument in setup_mlflow.

---------

Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
…project#33641)

* [AIR] Add artifact_location to MLFlow integration

Allows users to pass the artifact_location argument of mlflow.create_experiment and the run_name argument in setup_mlflow.

---------

Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants