Apply Ruff rules - #261
Conversation
reactive-firewall
added
chore
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev-v5.6 #261 +/- ##
============================================
- Coverage 99.58% 99.58% -0.01%
============================================
Files 1 1
Lines 481 478 -3
============================================
- Hits 479 476 -3
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bumps [actions/checkout](https://github.com/actions/checkout) from 5.0.0 to 6.0.2. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@08c6903...de0fac2) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…ithub/workflows/master/actions/checkout-6.0.2 [UPDATE] (deps): Bump actions/checkout from 5.0.0 to 6.0.2 in /.github/workflows
Implicitly concatenated string literals on one line
Implicitly concatenated string literals over multiple lines
Use `key in dict` instead of `key in dict.keys()`
Use `... != ...` instead of `not ... == ...`
Use a list comprehension to create a transformed list
Use a dictionary comprehension instead of a for-loop
Test for membership should be `not in`
Imported but unused
Use specific rule codes when ignoring type issues
Extracting value from dictionary without calling `.items()`
Class inherits from `object`
UTF-8 encoding declaration is unnecessary
Replace aliased errors with `OSError`
Use format specifiers instead of percent format
Use f-string instead of `format` call
Avoid extraneous parentheses
reactive-firewall
left a comment
reactive-firewall
left a comment
There was a problem hiding this comment.
👍 LGTM; with minor caveats.
Specifically, either revert the PEP-263 headers or update the vim directive to clarify python3 (and thus PEP-3120) to match.
See additional comments and suggestions inline.
Tests pass, so it is not needed by MyPy, is it? |
reactive-firewall
left a comment
reactive-firewall
left a comment
There was a problem hiding this comment.
👍 LGTM;
☑️ Specifically, the ruff linter suggestions are approved!
Additional Comments: All concerns discussed and resolved. See resolved comments in GH PR for NIT and out-of-scope details.
@DimitriPapadopoulos 🙇 Thank you for your time and efforts on this PR! 🎉
3 participants
Rules are not enforced in CI for now.