Generate keypair using tested provider - #316
Merged
Merged
Conversation
For the keypair generator tests, the keypairs are generated by the first available provider and not the provider that is to be tested. With this change the service from the tested provider is explicitly requested where needed. When a keypair from any provider is good enough, we allow the test to get it from the first available. Signed-off-by: Kostas Tsiounis <kostas.tsiounis@ibm.com>
Contributor
Author
|
FYI @keithc-ca |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the keypair generator tests, the keypairs are generated by the first available provider and not the provider that is to be tested.
With this change the service from the tested provider is explicitly requested where needed.
When a keypair from any provider is good enough, we allow the test to get it from the first available.
Back-ported from: ibmruntimes/openj9-openjdk-jdk#1038
Signed-off-by: Kostas Tsiounis kostas.tsiounis@ibm.com