Fix cmake warnings related to unused variables - #295
Merged
Conversation
Newer versions of cmake (e.g. 3.22.1) warn:
Manually-specified variables were not used by the project:
OPENJDK_VERSION_NUMBER_FOUR_POSITIONS
OPENSSL_CFLAGS
* only specify OPENJDK_VERSION_NUMBER_FOUR_POSITIONS on Windows
* remove unused definition of OPENSSL_CFLAGS
Adjust OpenSSL build to avoid overwriting OPENSSL_CFLAGS.
Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
pshipton
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer versions of cmake (e.g. 3.22.1) warn:
OPENJDK_VERSION_NUMBER_FOUR_POSITIONSon WindowsOPENSSL_CFLAGSAdjust OpenSSL build to avoid overwriting
OPENSSL_CFLAGS.This is a back-port of ibmruntimes/openj9-openjdk-jdk#1009.