Recreate LSP Client to prevent out of sync state - #872
Merged
Conversation
DaelonSuzuka
self-requested a review
June 16, 2025 15:33
Collaborator
|
I tried doing this a while ago but got a lot of wierd behavior and decided revisit later. I'll try to make time to test this out today. Thanks! |
Collaborator
|
I need an AI that just slaps me in the face with a robot arm if I ever say I'm going to review something within a certain time window. Sorry for the delay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #844
Over on the issue a rework of the client was mentioned. This PR is not meant to do this. It's a minimal fix to ensure consistent state, since consistent state is a blocker to move forward with certain refactorings and fixes in the server (e.g. godotengine/godot#105236)
(Also added one unrelated comment to a message filter, since it jumped into my eye)