Skip to content

Exclude testSharedCacheJvmtiAPI on AArch64 macOS - #14591

Merged
pshipton merged 1 commit into
eclipse-openj9:masterfrom
knn-k:aarch64macos_excludes5
Feb 25, 2022
Merged

Exclude testSharedCacheJvmtiAPI on AArch64 macOS#14591
pshipton merged 1 commit into
eclipse-openj9:masterfrom
knn-k:aarch64macos_excludes5

Conversation

@knn-k

@knn-k knn-k commented Feb 24, 2022

Copy link
Copy Markdown
Contributor

This commit excludes testSharedCacheJvmtiAPI in extended.functional on
AArch64 macOS for the time being, because it is a JVMTI-related test.

Signed-off-by: KONNO Kazuhiro konno@jp.ibm.com

@knn-k

knn-k commented Feb 24, 2022

Copy link
Copy Markdown
Contributor Author

How can I exclude a specific subtest?

I tried to exclude testSharedCacheJvmtiAPI only, but I was not able to find how to do it.
OpenJ9 AArch64 macOS passes all the tests in testSCCacheManagement but testSharedCacheJvmtiAPI.

@pshipton

Copy link
Copy Markdown
Member

How can I exclude a specific subtest?

@llxia may know, or we could modify the test code to do nothing on amac. If we can't exclude the sub-test, modifying the test is my preference over excluding the entire suite.

@llxia

llxia commented Feb 24, 2022

Copy link
Copy Markdown
Contributor

We can add if statement in the test in

public void testSharedCacheJvmtiAPI() { TestSharedCacheJvmtiAPI.main(null); }

to

public void testSharedCacheJvmtiAPI() {
	String spec = System.getenv("SPEC");
	if (!spec.contains("osx_aarch64")) {
		TestSharedCacheJvmtiAPI.main(null);
	}
}

This commit excludes testSharedCacheJvmtiAPI in extended.functional on
AArch64 macOS for the time being, because it is a JVMTI-related test.

Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
@knn-k
knn-k force-pushed the aarch64macos_excludes5 branch from b9ffb30 to ec52ed5 Compare February 25, 2022 01:59
@knn-k knn-k changed the title Exclude testSCCacheManagement on AArch64 macOS Exclude testSharedCacheJvmtiAPI on AArch64 macOS Feb 25, 2022
@knn-k

knn-k commented Feb 25, 2022

Copy link
Copy Markdown
Contributor Author

jenkins test extended.functional amac jdk18

@knn-k

knn-k commented Feb 25, 2022

Copy link
Copy Markdown
Contributor Author

@llxia Thank you, I changed the test code as you suggested. I also changed the commit title and the commit message.

@knn-k

knn-k commented Feb 25, 2022

Copy link
Copy Markdown
Contributor Author

The test job finished successfully on AArch64 macOS, and the result contains testSCCacheManagement_0 as I intended.
https://openj9-jenkins.osuosl.org/job/Build_JDK18_aarch64_mac_Personal/8/

knn-k added a commit to knn-k/openj9 that referenced this pull request Feb 25, 2022
This commit excludes testSharedCacheJvmtiAPI in extended.functional on
AArch64 macOS for the time being, because it is a JVMTI-related test.

Original PR in master: eclipse-openj9#14591

Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
@pshipton
pshipton merged commit 038e689 into eclipse-openj9:master Feb 25, 2022
@knn-k
knn-k deleted the aarch64macos_excludes5 branch February 25, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants