Update SystemPropertiesTest to work on AIX - #14579
Conversation
There was a problem hiding this comment.
Is <platformRequirements>os.aix</platformRequirements> still required particularly for JDK18+?
There was a problem hiding this comment.
I did try on alinux. On jdk18 everything passed except the Test 9 Test -Xnoargsconversion and on jdk17 8/10 tests failed. I expect I could fix it but I'm not convinced doing so is a good use of time. Results on other platforms may be different.
There was a problem hiding this comment.
Sure, other platforms can rely on OpenJDK JEP400 test coverages.
There was a problem hiding this comment.
This is a test for OpenJ9 command line arguments like -Xargencoding and -Xnoargsconversion
|
Updated to use TestUtilities and add brackets, tested via https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/675/ |
JasonFengJ9
left a comment
JasonFengJ9
left a comment
There was a problem hiding this comment.
Just added a few format suggestions.
The change looks good, thanks.
On AIX with jdk18+ JEP 400 UTF-8 by default, the non-ASCII characters on the command line are converted to UTF-8 by the test (not the JVM). Issue eclipse-openj9#14227 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
|
Updated to address latest review comments, and retested https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/676/ |
3 participants
On AIX with jdk18+ JEP 400 UTF-8 by default, the non-ASCII characters on
the command line are converted to UTF-8 by the test (not the JVM).
Fixes #14227
Tested via grinders, which all passed.
AIX
8: https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/669/
17: https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/666/
18: https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/665/
Windows
8: https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/670/
17: https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/672/
18: https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/671