Skip to content

Add implementation of Class.isValue() - #14543

Merged
tajila merged 1 commit into
eclipse-openj9:masterfrom
hangshao0:master
Feb 23, 2022
Merged

Add implementation of Class.isValue()#14543
tajila merged 1 commit into
eclipse-openj9:masterfrom
hangshao0:master

Conversation

@hangshao0

Copy link
Copy Markdown
Contributor
  1. Add implementation of Class.isValue()
  2. Update Class.isPrimitiveClass() to check for ACC_PRIMITIVE

Closes #14519

Signed-off-by: Hang Shao hangshao@ca.ibm.com

1. Add implementation of Class.isValue()
2. Update Class.isPrimitiveClass() to check for ACC_PRIMITIVE

Closes eclipse-openj9#14519

Signed-off-by: Hang Shao <hangshao@ca.ibm.com>
@hangshao0
hangshao0 requested a review from tajila February 17, 2022 16:23
@hangshao0 hangshao0 added project:valhalla Used to track Project Valhalla related work comp:vm labels Feb 17, 2022
@tajila

tajila commented Feb 20, 2022

Copy link
Copy Markdown
Contributor

Jenkins test sanity win jdk8

@tajila

tajila commented Feb 20, 2022

Copy link
Copy Markdown
Contributor

Jenkins test sanity,extended plinuxval jdknext

@tajila

tajila commented Feb 20, 2022

Copy link
Copy Markdown
Contributor

Jenkins test sanity xlinuxvalst jdknext

@hangshao0

Copy link
Copy Markdown
Contributor Author

Builds failed at:

17:58:52  /home/jenkins/workspace/Build_JDKnext_ppc64le_linux_valhalla_Personal/build/linux-ppc64le-server-release/support/j9jcl/java.base/share/classes/java/lang/ClassLoader.java:338: error: cannot find symbol
17:58:52  	this.nativelibs = NativeLibraries.newInstance((this == bootstrapClassLoader) ? null : this);
17:58:52  	                                 ^
17:58:52    symbol:   method newInstance((this == b[...] this)

Seems not related to this change.

@hangshao0

Copy link
Copy Markdown
Contributor Author

The change was recently added by: #14549

@JasonFengJ9

Copy link
Copy Markdown
Member

@hangshao0

Copy link
Copy Markdown
Contributor Author

The PR build picked up an outdated SHA [1], latest one [2] has the API in question [3].

Thanks @JasonFengJ9.
@tajila You may want to re-launch the VT PR builds.

@tajila

tajila commented Feb 22, 2022

Copy link
Copy Markdown
Contributor

Thanks for looking into this @hangshao0 @JasonFengJ9

@tajila

tajila commented Feb 22, 2022

Copy link
Copy Markdown
Contributor

Jenkins test sanity,extended plinuxval jdknext

@tajila

tajila commented Feb 22, 2022

Copy link
Copy Markdown
Contributor

Jenkins test sanity xlinuxvalst jdknext

@tajila
tajila merged commit c67548f into eclipse-openj9:master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:vm project:valhalla Used to track Project Valhalla related work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Class.isPrimitiveClass() needs to check for ACC_PRIMITIVE

3 participants