AArch64: Preserve vector registers across helper calls - #14506
Merged
gacholio merged 1 commit intoFeb 14, 2022
Conversation
Contributor
Author
knn-k
reviewed
Feb 14, 2022
knn-k
reviewed
Feb 14, 2022
Preserve vector registers across helper calls. Split helper functions into two categories as other platform do. For method invocation helpers, we save parameter FPRs only. For other helpers, we save all 128-bit vector registers. Signed-off-by: Akira Saitoh <saiaki@jp.ibm.com>
Akira1Saitoh
force-pushed
the
aarch64VectorRegHelper
branch
from
February 14, 2022 06:44
a6f7b6f to
be054d4
Compare
Contributor
|
jenkins test sanity alinux64 jdk17 |
knn-k
approved these changes
Feb 14, 2022
Contributor
|
@gacholio Do you have any comments? Thanks. |
gacholio
approved these changes
Feb 14, 2022
gacholio
left a comment
gacholio
left a comment
Contributor
There was a problem hiding this comment.
Other platforms perform a capability check in order to enable vector support. I assume all supported ARM hardware has this support so there's no need for the runtime check?
Contributor
Author
|
Yes, all supported ARM hardware has 128-bit length vector registers, so we do not need the runtime check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve vector registers across helper calls.
Split helper functions into two categories as other platform do.
For method invocation helpers, we save parameter FPRs only.
For other helpers, we save all 128-bit vector registers.
This implementation is based on x.
Resolves #12179.
Signed-off-by: Akira Saitoh saiaki@jp.ibm.com