Skip to content

Eliminate the effect -Xaggressive has on switching to profiling - #14496

Merged
vijaysun-omr merged 1 commit into
eclipse-openj9:masterfrom
mpirvu:xaggressive
Feb 14, 2022
Merged

Eliminate the effect -Xaggressive has on switching to profiling#14496
vijaysun-omr merged 1 commit into
eclipse-openj9:masterfrom
mpirvu:xaggressive

Conversation

@mpirvu

@mpirvu mpirvu commented Feb 12, 2022

Copy link
Copy Markdown
Contributor

The option -Xaggressive allows switching to profiling of hot compilations
in a more aggressive manner. This has been seen to have negative performance
effects on some applications.
This commit eliminates the effect -Xaggressive has on switching to profiling.
More aggressive switching to profiling can be enabled with the newly created
option -Xjit:aggressiveSwitchingToProfiling

Another change is the elimination of code that tried to disable downgrading
to cold optimization level. That code had no effect because it was conditional
on an option that was not yet set at that point.

Depends on eclipse-omr/omr#6350

Signed-off-by: Marius Pirvu mpirvu@ca.ibm.com

@mpirvu mpirvu added comp:jit depends:omr Pull request is dependent on a corresponding change in OMR labels Feb 12, 2022
@mpirvu mpirvu changed the title Eliminate the effect -Xaggressive has on swithing to profiling Eliminate the effect -Xaggressive has on switching to profiling Feb 12, 2022
@mpirvu

mpirvu commented Feb 12, 2022

Copy link
Copy Markdown
Contributor Author

FYI @vijaysun-omr

@mpirvu
mpirvu marked this pull request as draft February 12, 2022 00:57
@mpirvu

mpirvu commented Feb 12, 2022

Copy link
Copy Markdown
Contributor Author

Converted to draft mode until the OMR change it depends on gets merged.

@vijaysun-omr

Copy link
Copy Markdown
Contributor

Typo in commit message and PR abstract : "profilig"

The option `-Xaggressive` allows switching to profiling of hot compilations
in a more aggressive manner. This has been seen to have negative performance
effects on some applications.
This commit eliminates the effect `-Xaggressive` has on switching to profiling.
More aggressive switching to profiling can be enabled with the newly created
option `-Xjit:aggressiveSwitchingToProfiling`

Another change is the elimination of code that tried to disable downgrading
to cold optimization level. That code had no effect because it was conditional
on an option that was not yet set at that point.

Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
@mpirvu

mpirvu commented Feb 12, 2022

Copy link
Copy Markdown
Contributor Author

Fixed the typo.

@vijaysun-omr

Copy link
Copy Markdown
Contributor

Jenkins test extended all jdk11

@mpirvu

mpirvu commented Feb 14, 2022

Copy link
Copy Markdown
Contributor Author

One test on AIX failed, but from the error message, the failure doesn't seem connected to this PR

Running test testRASAPI_0 .
...
      [test]     [junit] ------------- Standard Output ---------------
     [test]     [junit] com.ibm.jvm.InvalidDumpOptionException: Error in dump options.
     [test]     [junit] reach here
     [test]     [junit] ------------- ---------------- ---------------
     [test]     [junit] 
     [test]     [junit] Testcase: testJavaDumpNoArgs took 0.04 sec
     [test]     [junit] Testcase: testJavaDumpWithFile took 0.034 sec
     [test]     [junit] Testcase: testJavaDumpWithOptions took 0.003 sec
     [test]     [junit] Testcase: testJavaDumpNullFile took 0.032 sec
     [test]     [junit] Testcase: testJavaDumpEmptyFile took 0.025 sec
     [test]     [junit] Testcase: testJavaDumpToDashFile took 0.494 sec
     [test]     [junit] Testcase: testJavaDumpWithSameFile took 1.069 sec
     [test]     [junit] Testcase: testHeapDumpNoArgs took 0.045 sec
     [test]     [junit] Testcase: testHeapDumpWithFile took 0.046 sec
     [test]     [junit] Testcase: testHeapDumpWithOptions took 0.002 sec
     [test]     [junit] Testcase: testHeapDumpNullFile took 0.045 sec
     [test]     [junit] Testcase: testHeapDumpToDashFile took 0.008 sec
     [test]     [junit] Testcase: testHeapDumpWithSameFile took 1.121 sec
     [test]     [junit] Testcase: testSnapDumpNoArgs took 0.106 sec
     [test]     [junit] Testcase: testSnapDumpWithFile took 0.11 sec
     [test]     [junit] Testcase: testSnapDumpWithOptions took 0.004 sec
     [test]     [junit] Testcase: testSnapDumpNullFile took 0.138 sec
     [test]     [junit] Testcase: testSnapDumpToDashFile took 0.009 sec
     [test]     [junit] Testcase: testSnapDumpWithSameFile took 1.232 sec
     [test]     [junit] Testcase: testSystemDumpNoArgs took 34.145 sec
     [test]     [junit] Testcase: testSystemDumpWithFile took 45.75 sec
     [test]     [junit] Testcase: testSystemDumpWithOptions took 0.643 sec
     [test]     [junit] Testcase: testSystemDumpNullFile took 146.664 sec
     [test]     [junit] 	Caused an ERROR
     [test]     [junit] Java heap space
     [test]     [junit] java.lang.OutOfMemoryError: Java heap space
     [test]     [junit] 	at java.base/java.lang.StringCoding.decodeUTF8_0(StringCoding.java:766)
     [test]     [junit] 	at java.base/java.lang.StringCoding.decodeUTF8(StringCoding.java:725)
     [test]     [junit] 	at java.base/java.lang.StringCoding.decode(StringCoding.java:237)
     [test]     [junit] 	at java.base/java.lang.String.<init>(String.java:602)
...

@mpirvu
mpirvu marked this pull request as ready for review February 14, 2022 13:41
@pshipton

Copy link
Copy Markdown
Member

The AIX failure is a known issue #14193

@mpirvu

mpirvu commented Feb 14, 2022

Copy link
Copy Markdown
Contributor Author

Based on Peter's comment, this PR is ready to be merged.

@vijaysun-omr
vijaysun-omr merged commit 1a2a30a into eclipse-openj9:master Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:jit depends:omr Pull request is dependent on a corresponding change in OMR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants