Eliminate the effect -Xaggressive has on switching to profiling - #14496
Merged
Conversation
Contributor
Author
|
FYI @vijaysun-omr |
mpirvu
marked this pull request as draft
February 12, 2022 00:57
Contributor
Author
|
Converted to draft mode until the OMR change it depends on gets merged. |
Contributor
|
Typo in commit message and PR abstract : "profilig" |
The option `-Xaggressive` allows switching to profiling of hot compilations in a more aggressive manner. This has been seen to have negative performance effects on some applications. This commit eliminates the effect `-Xaggressive` has on switching to profiling. More aggressive switching to profiling can be enabled with the newly created option `-Xjit:aggressiveSwitchingToProfiling` Another change is the elimination of code that tried to disable downgrading to cold optimization level. That code had no effect because it was conditional on an option that was not yet set at that point. Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
Contributor
Author
|
Fixed the typo. |
vijaysun-omr
approved these changes
Feb 13, 2022
Contributor
|
Jenkins test extended all jdk11 |
Contributor
Author
|
One test on AIX failed, but from the error message, the failure doesn't seem connected to this PR |
mpirvu
marked this pull request as ready for review
February 14, 2022 13:41
Member
|
The AIX failure is a known issue #14193 |
Contributor
Author
|
Based on Peter's comment, this PR is ready to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The option
-Xaggressiveallows switching to profiling of hot compilationsin a more aggressive manner. This has been seen to have negative performance
effects on some applications.
This commit eliminates the effect
-Xaggressivehas on switching to profiling.More aggressive switching to profiling can be enabled with the newly created
option
-Xjit:aggressiveSwitchingToProfilingAnother change is the elimination of code that tried to disable downgrading
to cold optimization level. That code had no effect because it was conditional
on an option that was not yet set at that point.
Depends on eclipse-omr/omr#6350
Signed-off-by: Marius Pirvu mpirvu@ca.ibm.com