Avoid leading tabs in makefiles outside of recipes - #14449
Merged
Conversation
Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
Contributor
Author
|
FYI @babsingh |
pshipton
approved these changes
Feb 7, 2022
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
Feb 14, 2022
Setting JVM_OPTIONS overwrites the modes. EXTRA_OPTIONS will always append to the JVM options for the modes. If the modes already specify -Djava.security.manager=*, then it will be overwritten by EXTRA_OPTIONS. JAVA_TOOL_OPTIONS works with both OpenJ9 and Hotspot. It prepends JVM options at startup so it will not overwrite the JVM options for the modes. Leading tabs have the potential to cause elements of makefiles to be considered part of a recipe instead of part of the global structure: use spaces instead. Fixes: eclipse-openj9/openj9#14495 Related: eclipse-openj9/openj9#14449 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
Feb 14, 2022
Setting JVM_OPTIONS overwrites the modes. EXTRA_OPTIONS will always append to the JVM options for the modes. If the modes already specify -Djava.security.manager=*, then it will be overwritten by EXTRA_OPTIONS. JAVA_TOOL_OPTIONS works with both OpenJ9 and Hotspot. It prepends JVM options at startup so it will not overwrite the JVM options for the modes. Leading tabs have the potential to cause elements of makefiles to be considered part of a recipe instead of part of the global structure: use spaces instead. Fixes: eclipse-openj9/openj9#14495 Related: eclipse-openj9/openj9#14449 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
Feb 14, 2022
Setting JVM_OPTIONS overwrites the modes. EXTRA_OPTIONS will always append to the JVM options for the modes. If the modes already specify -Djava.security.manager=*, then it will be overwritten by EXTRA_OPTIONS. JAVA_TOOL_OPTIONS works with both OpenJ9 and Hotspot. It prepends JVM options at startup so it will not overwrite the JVM options for the modes. Leading tabs have the potential to cause elements of makefiles to be considered part of a recipe instead of part of the global structure: use spaces instead. For consistency, 2 spaces are used in this file for a tab. Fixes: eclipse-openj9/openj9#14495 Related: eclipse-openj9/openj9#14449 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
Feb 14, 2022
Setting JVM_OPTIONS overwrites the modes. EXTRA_OPTIONS will always append to the JVM options for the modes. If the modes already specify -Djava.security.manager=*, then it will be overwritten by EXTRA_OPTIONS. JAVA_TOOL_OPTIONS works with both OpenJ9 and Hotspot. It prepends JVM options at startup so it will not overwrite the JVM options for the modes. Leading tabs have the potential to cause elements of makefiles to be considered part of a recipe instead of part of the global structure: use spaces instead. For consistency, 2 spaces are used in this file for a tab. Fixes: eclipse-openj9/openj9#14495 Related: eclipse-openj9/openj9#14449 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
Feb 14, 2022
Setting JVM_OPTIONS overwrites the modes. EXTRA_OPTIONS will always append to the JVM options for the modes. If the modes already specify -Djava.security.manager=*, then it will be overwritten by EXTRA_OPTIONS. JAVA_TOOL_OPTIONS works with both OpenJ9 and Hotspot. It prepends JVM options at startup so it will not overwrite the JVM options for the modes. Leading tabs have the potential to cause elements of makefiles to be considered part of a recipe instead of part of the global structure: use spaces instead. For consistency, 2 spaces are used in this file for a tab. Fixes: eclipse-openj9/openj9#14495 Related: eclipse-openj9/openj9#14449 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
Feb 18, 2022
Setting JVM_OPTIONS overwrites the modes. EXTRA_OPTIONS will always append to the JVM options for the modes. If the modes already specify -Djava.security.manager=*, then it will be overwritten by EXTRA_OPTIONS. JAVA_TOOL_OPTIONS works with both OpenJ9 and Hotspot. It prepends JVM options at startup so it will not overwrite the JVM options for the modes. Leading tabs have the potential to cause elements of makefiles to be considered part of a recipe instead of part of the global structure: use spaces instead. For consistency, 2 spaces are used in this file for a tab. Fixes: eclipse-openj9/openj9#14495 Related: eclipse-openj9/openj9#14449 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
llxia
pushed a commit
to adoptium/aqa-tests
that referenced
this pull request
Feb 18, 2022
Setting JVM_OPTIONS overwrites the modes. EXTRA_OPTIONS will always append to the JVM options for the modes. If the modes already specify -Djava.security.manager=*, then it will be overwritten by EXTRA_OPTIONS. JAVA_TOOL_OPTIONS works with both OpenJ9 and Hotspot. It prepends JVM options at startup so it will not overwrite the JVM options for the modes. Leading tabs have the potential to cause elements of makefiles to be considered part of a recipe instead of part of the global structure: use spaces instead. For consistency, 2 spaces are used in this file for a tab. Fixes: eclipse-openj9/openj9#14495 Related: eclipse-openj9/openj9#14449 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leading tabs have the potential to cause elements of makefiles to be considered part of a recipe instead of part of the global structure: use spaces instead.