Skip to content

Fix JIT code breakpoints on x86 - #14435

Merged
dsouzai merged 1 commit into
eclipse-openj9:masterfrom
0xdaryl:fixint3
Feb 7, 2022
Merged

Fix JIT code breakpoints on x86#14435
dsouzai merged 1 commit into
eclipse-openj9:masterfrom
0xdaryl:fixint3

Conversation

@0xdaryl

@0xdaryl 0xdaryl commented Feb 4, 2022

Copy link
Copy Markdown
Contributor

Code breakpoints inserted by the JIT should use an int3 instruction rather
than the bad pseudo instruction.

Signed-off-by: Daryl Maier maier@ca.ibm.com

@0xdaryl

0xdaryl commented Feb 4, 2022

Copy link
Copy Markdown
Contributor Author

Jenkins test sanity xlinux,win,win32 jdk8

@0xdaryl

0xdaryl commented Feb 4, 2022

Copy link
Copy Markdown
Contributor Author

@dsouzai @ymanton : would one of you mind reviewing and merging this please?

@dsouzai

dsouzai commented Feb 4, 2022

Copy link
Copy Markdown
Contributor

Linux build is failing because of cmdLineTester_GCRotatingVerboseLogTests_2 which has been seen elsewhere. The win32 build though is crashing in the JIT while building some test:

23:42:49  Unhandled exception
23:42:49  Type=Segmentation error vmState=0x00000000
23:42:49  J9Generic_Signal_Number=00000004 ExceptionCode=c0000005 ExceptionAddress=71131C6C ContextFlags=0001007f
23:42:49  Handler1=71A01C60 Handler2=71924270 InaccessibleReadAddress=0B4868B6
23:42:49  EDI=2340F29A ESI=0140A750 EAX=212E1798 EBX=212E17F0
23:42:49  ECX=013F4320 EDX=0B4868AA
23:42:49  EIP=71131C6C ESP=2648412C EBP=22129800 EFLAGS=00210282
23:42:49  GS=002B FS=0053 ES=002B DS=002B
23:42:49  Module=F:\Users\jenkins\workspace\Test_openjdk8_j9_sanity.functional_x86-32_windows_Personal\openjdkbinary\j2sdk-image\jre\bin\default\j9jit29.dll
23:42:49  Module_base_address=71130000 Offset_in_DLL=00001c6c
23:42:49  Target=2_90_20220203_158 (Windows Server 2012 R2 6.3 build 9600)
23:42:49  CPU=x86 (8 logical CPUs) (0x1ffb9c000 RAM)
23:42:49  ----------- Stack Backtrace -----------
23:42:49  (0x71131C6C [j9jit29+0x1c6c])
23:42:49  (0x212E1798)
23:42:49  ---------------------------------------

though I don't see how it could be related to this change.

@dsouzai

dsouzai commented Feb 4, 2022

Copy link
Copy Markdown
Contributor

Jenkins test sanity win32 jdk8

@dsouzai dsouzai self-assigned this Feb 4, 2022
@dsouzai

dsouzai commented Feb 4, 2022

Copy link
Copy Markdown
Contributor

@0xdaryl win32 looks like it's consistently failing, now failing with

11:12:22  Buildfile: F:\Users\jenkins\workspace\Test_openjdk8_j9_sanity.functional_x86-32_windows_Personal\aqa-tests\TKG\scripts\build_tools.xml
11:12:23  Unhandled exception
11:12:23  Type=Segmentation error vmState=0x00070000
11:12:23  J9Generic_Signal_Number=00000004 ExceptionCode=c0000005 ExceptionAddress=71E26E59 ContextFlags=0001007f
11:12:23  Handler1=72231C60 Handler2=72154270 InaccessibleReadAddress=7FFA818C
11:12:23  EDI=00000000 ESI=22129800 EAX=0FFFFFFF EBX=00000009
11:12:23  ECX=22129800 EDX=2D8E400F
11:12:23  EIP=71E26E59 ESP=00CAF54C EBP=FFFA8190 EFLAGS=00210246
11:12:23  GS=002B FS=0053 ES=002B DS=002B
11:12:23  Module=F:\Users\jenkins\workspace\Test_openjdk8_j9_sanity.functional_x86-32_windows_Personal\openjdkbinary\j2sdk-image\jre\bin\default\j9jit29.dll
11:12:23  Module_base_address=71960000 Offset_in_DLL=004c6e59
11:12:23  Target=2_90_20220204_159 (Windows Server 2012 R2 6.3 build 9600)
11:12:23  CPU=x86 (8 logical CPUs) (0x1ffb9c000 RAM)
11:12:23  ----------- Stack Backtrace -----------
11:12:23  Java_java_lang_invoke_ThunkTuple_initialInvokeExactThunk+0x4212e9 (0x71E26E59 [j9jit29+0x4c6e59])
11:12:23  (0x71961C82 [j9jit29+0x1c82])
11:12:23  Java_java_lang_invoke_ThunkTuple_initialInvokeExactThunk+0x40d8b2 (0x71E13422 [j9jit29+0x4b3422])
11:12:23  J9VMDllMain+0x8956 (0x71659966 [j9gc29+0x9966])
11:12:23  (0x72217987 [j9vm29+0x57987])
11:12:23  (0x7221E95F [j9vm29+0x5e95f])
11:12:23  (0x7222049B [j9vm29+0x6049b])
11:12:23  J9_GetInterface+0x4eda3 (0x7228A6E3 [j9vm29+0xca6e3])
11:12:23  J9_GetInterface+0x4e118 (0x72289A58 [j9vm29+0xc9a58])

@0xdaryl

0xdaryl commented Feb 4, 2022

Copy link
Copy Markdown
Contributor Author

Thanks. That's weird. I'll have a look.

@0xdaryl
0xdaryl force-pushed the fixint3 branch 2 times, most recently from c7ed1e2 to cde6257 Compare February 5, 2022 17:32
Code breakpoints inserted by the JIT should use an `int3` instruction rather
than the `bad` pseudo instruction.

Signed-off-by: Daryl Maier <maier@ca.ibm.com>
@0xdaryl

0xdaryl commented Feb 6, 2022

Copy link
Copy Markdown
Contributor Author

Jenkins test sanity xlinux,win,win32 jdk8

@0xdaryl

0xdaryl commented Feb 6, 2022

Copy link
Copy Markdown
Contributor Author

Win32 issue is fixed in most recent forced push. @dsouzai, please review again. Thank you.

@dsouzai
dsouzai merged commit ecc33af into eclipse-openj9:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants