Fix JIT code breakpoints on x86 - #14435
Merged
Merged
Conversation
Contributor
Author
|
Jenkins test sanity xlinux,win,win32 jdk8 |
Contributor
Author
dsouzai
approved these changes
Feb 4, 2022
Contributor
|
Linux build is failing because of though I don't see how it could be related to this change. |
Contributor
|
Jenkins test sanity win32 jdk8 |
Contributor
|
@0xdaryl win32 looks like it's consistently failing, now failing with |
Contributor
Author
|
Thanks. That's weird. I'll have a look. |
0xdaryl
force-pushed
the
fixint3
branch
2 times, most recently
from
February 5, 2022 17:32
c7ed1e2 to
cde6257
Compare
Code breakpoints inserted by the JIT should use an `int3` instruction rather than the `bad` pseudo instruction. Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Contributor
Author
|
Jenkins test sanity xlinux,win,win32 jdk8 |
Contributor
Author
|
Win32 issue is fixed in most recent forced push. @dsouzai, please review again. Thank you. |
dsouzai
approved these changes
Feb 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code breakpoints inserted by the JIT should use an
int3instruction ratherthan the
badpseudo instruction.Signed-off-by: Daryl Maier maier@ca.ibm.com