JDK8 Thread.cleanup requires TerminatingThreadLocal.threadTerminated() - #14069
Merged
Conversation
Replace JAVA11 JPP decoration w/ Sidecar18-SE-OpenJ9 to allow JDK8 j.l.Thread.cleanup() to invoke TerminatingThreadLocal.threadTerminated() if required. Sidecar18-SE (internal IBM build) is unchanged because they are still not updated to 1.8.0_322. Signed-off-by: Jason Feng <fengj@ca.ibm.com>
Member
|
jenkins compile alinux64 jdk8 |
Member
|
I assume this is going to work, so pls cherry pick for the 0.30 branch. |
Member
Author
|
Created #14070 for the |
Member
|
Tested via grinder, which passed. |
pshipton
approved these changes
Dec 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced
JAVA11JPPdecoration w/Sidecar18-SE-OpenJ9to allowJDK8j.l.Thread.cleanup()to invokeTerminatingThreadLocal.threadTerminated()if required.Sidecar18-SE(internal IBM build) is unchanged because they are still not updated to1.8.0_322yet.Note: IBM Java 8 build is at
jdk8u311-b11which doesn't havejdk.internal.misc.TerminatingThreadLocal.fixes #14008
Signed-off-by: Jason Feng fengj@ca.ibm.com