Avoid locking the CHTable at end of compilation if possible - #14050
Merged
Conversation
Contributor
Author
|
@dsouzai Please review/merge this PR. Thanks! |
dsouzai
requested changes
Dec 1, 2021
dsouzai
left a comment
dsouzai
left a comment
Contributor
There was a problem hiding this comment.
Overall lgtm; minor change requested.
At the end of compilation the JIT acquires the VM class mutex just before performing chtable.commit(). We can skip this lock acquire operation if we test beforehand that a chtable.commit does not need to be performed. This can speed up AOT loads and some JIT compilations, because they don't have to wait for the VM class mutex. Contention on the VM class mutex has been shown to be very heavy in very large applications that load very many classes. Partially addresses issue eclipse-openj9#13807 Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
dsouzai
approved these changes
Dec 1, 2021
Contributor
|
jenkins test sanity.functional all jdk17 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the end of compilation the JIT acquires the VM class mutex
just before performing chtable.commit(). We can skip this lock acquire
operation if we test beforehand that a chtable.commit does not need
to be performed. This can speed up AOT loads and some JIT compilations,
because they don't have to wait for the VM class mutex.
Contention on the VM class mutex has been shown to be very heavy
in very large applications that load very many classes.
Partially addresses issue #13807
Signed-off-by: Marius Pirvu mpirvu@ca.ibm.com