Skip to content

Add calculate element address with element stride - #13975

Merged
0xdaryl merged 2 commits into
eclipse-openj9:masterfrom
a7ehuo:PR-calculate-element-address
Dec 18, 2021
Merged

Add calculate element address with element stride#13975
0xdaryl merged 2 commits into
eclipse-openj9:masterfrom
a7ehuo:PR-calculate-element-address

Conversation

@a7ehuo

@a7ehuo a7ehuo commented Nov 23, 2021

Copy link
Copy Markdown
Contributor

Update TransformUtil to calculate element address with element stride and add flattenedArrayElementSize to ClassEnv.

@a7ehuo a7ehuo added project:valhalla Used to track Project Valhalla related work comp:jit labels Nov 23, 2021
@a7ehuo

a7ehuo commented Nov 23, 2021

Copy link
Copy Markdown
Contributor Author

@hzongaro @0xdaryl, may I ask you to review? Thanks!
@mpirvu, may I ask you to review the change related to JITServer? Thanks!

mpirvu
mpirvu reviewed Nov 23, 2021
View reviewed changes

@mpirvu mpirvu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from JITServer point of view. I don't see flattenedArrayElementSize() is used though.
As an optimization, in the future we could keep the desired size in the cache of J9classes at the server.

@a7ehuo

a7ehuo commented Nov 23, 2021

Copy link
Copy Markdown
Contributor Author

I don't see flattenedArrayElementSize() is used though.

flattenedArrayElementSize will be used in a future change that will transform flattened array element load/store helper calls with sym refs in VP.

@a7ehuo a7ehuo changed the title WIP: Add calculate element address with element stride Add calculate element address with element stride Nov 25, 2021
hzongaro
hzongaro reviewed Nov 26, 2021
View reviewed changes

@hzongaro hzongaro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The general approach looks correct - we just need to check on the possibility that strides of length zero might occur

Comment thread runtime/compiler/optimizer/J9TransformUtil.hpp Outdated
Comment thread runtime/compiler/optimizer/J9TransformUtil.hpp Outdated
Comment thread runtime/compiler/optimizer/J9TransformUtil.cpp Outdated
@a7ehuo
a7ehuo force-pushed the PR-calculate-element-address branch 3 times, most recently from ad220f8 to 7bfe3e8 Compare November 30, 2021 15:32
Annabelle Huo Annabelle Huo
Add flattenedArrayElementSize in ClassEnv
21a17cf 
Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
@a7ehuo
a7ehuo force-pushed the PR-calculate-element-address branch from 7bfe3e8 to bb08c80 Compare December 6, 2021 21:36
@a7ehuo a7ehuo changed the title Add calculate element address with element stride WIP: Add calculate element address with element stride Dec 6, 2021
Annabelle Huo Annabelle Huo
Add calculate element address with element stride
72bcad7 
Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
@a7ehuo
a7ehuo force-pushed the PR-calculate-element-address branch from bb08c80 to 72bcad7 Compare December 7, 2021 16:38
hzongaro
hzongaro approved these changes Dec 8, 2021
View reviewed changes

@hzongaro hzongaro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes look good. Thanks!

@a7ehuo a7ehuo changed the title WIP: Add calculate element address with element stride Add calculate element address with element stride Dec 9, 2021
@a7ehuo

a7ehuo commented Dec 10, 2021

Copy link
Copy Markdown
Contributor Author

@0xdaryl All comments are addressed. Ready for another review. Thanks!

@a7ehuo a7ehuo mentioned this pull request Dec 11, 2021
Merged
1 task
@0xdaryl

0xdaryl commented Dec 17, 2021

Copy link
Copy Markdown
Contributor

Jenkins test sanity all jdk17

@0xdaryl 0xdaryl self-assigned this Dec 18, 2021
@0xdaryl
0xdaryl merged commit ca2a78c into eclipse-openj9:master Dec 18, 2021
@a7ehuo
a7ehuo deleted the PR-calculate-element-address branch January 12, 2022 21:25
@mpirvu mpirvu mentioned this pull request Jan 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpirvu mpirvu mpirvu left review comments
@0xdaryl 0xdaryl 0xdaryl approved these changes
@hzongaro hzongaro hzongaro approved these changes

Assignees

@0xdaryl 0xdaryl

Labels

comp:jit project:valhalla Used to track Project Valhalla related work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@a7ehuo @0xdaryl @hzongaro @mpirvu