Fix logger errors under DEBUG - #8107
Merged
Merged
Conversation
After the logger overhaul, there are a few places where compilation fails when DEBUG is defined.
kevindean12
requested review from
0xdaryl,
mstoodle and
vijaysun-omr
as code owners
January 27, 2026 21:51
Contributor
|
Jenkins build all |
Contributor
|
Thanks @kevindean12. The JIT DEBUG path does not get much (any) love these days from a testing perspective, which is arguably something we need to rectify. |
0xdaryl
approved these changes
Jan 28, 2026
0xdaryl
left a comment
0xdaryl
left a comment
Contributor
There was a problem hiding this comment.
All failures are known issues.
Contributor
Author
No problem! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the logger overhaul, there are a few places where compilation fails when DEBUG is defined.