Missing files in jitbuilder common.mk - #8098
Conversation
mstoodle
left a comment
mstoodle
left a comment
There was a problem hiding this comment.
Please change the commit message to "Add missing files..." since we seem to like commit messages that start with verbs.
This file hasn't been updated because most consumers are now using cmake and the files in this directory aren't used by cmake. I see no reason we can't update the file, but I don't believe we have any remaining tests that use them (otherwise those tests would be broken). I'll merge once the title is updated. Thanks, @jduimovich!
3a47f92 to
c517864
Compare
|
I did the quick and dirty git -amend to fix the specific commit and changed the name to Add missing files to common.mk |
|
Thanks, John! I'll run tests on all platforms just in case somehow we do run one of these builds... |
|
jenkins build all |
mstoodle
left a comment
mstoodle
left a comment
There was a problem hiding this comment.
looks good now, let's just wait to see how the builds proceed...
|
most of those failures are known issues, and the one I don't recognize couldn't possibly be caused by this PR so I'll merge. |
3 participants
I recompiled an app which uses the JITBuilder libraries and it failed to link due to missing files in jitbuilder/build/files/common.mk which then doesn't add them to the libraries. I added the missing files manually and my code now links correctly.
I don't know if updating common.mk is a manual process or there is a tool to generate it automatically. If so, let me know and I can update the PR with a generated file instead of the manual edited one.