[android] update AOT profile for .NET 9 GA - #25509
Merged
Merged
Conversation
There are very few changes as this point, but recording a new profile
shows a few changes, and maybe improvement by a very small amount:
Before:
Average(ms): 450.1
Std Err(ms): 3.53537676760043
Std Dev(ms): 11.1798429724611
After:
Average(ms): 448.6
Std Err(ms): 2.54383787044519
Std Dev(ms): 8.04432166879912
This is an average of 10 runs on a `dotnet new maui` template on a Pixel 7 Pro.
It might be effectively *the same*, but it's worth updating I suppose.
jonathanpeppers
requested review from
jfversluis
and removed request for
a team
October 24, 2024 16:50
jonathanpeppers
commented
Oct 24, 2024
Comment on lines
-4868
to
+4872
| void Microsoft.Maui.Controls.Generated.GeneratedBindingInterceptors:SetBinding1138676086 (Microsoft.Maui.Controls.BindableObject,Microsoft.Maui.Controls.BindableProperty,System.Func`2<Microsoft.Maui.Controls.BaseShellItem, Microsoft.Maui.Controls.ImageSource>,Microsoft.Maui.Controls.BindingMode,Microsoft.Maui.Controls.IValueConverter,object,string,object,object,object) | ||
| void Microsoft.Maui.Controls.Generated.GeneratedBindingInterceptors:SetBinding114022620 (Microsoft.Maui.Controls.BindableObject,Microsoft.Maui.Controls.BindableProperty,System.Func`2<Microsoft.Maui.Controls.BaseShellItem, string>,Microsoft.Maui.Controls.BindingMode,Microsoft.Maui.Controls.IValueConverter,object,string,object,object,object) | ||
| void Microsoft.Maui.Controls.Generated.GeneratedBindingInterceptors:SetBinding1635156915 (Microsoft.Maui.Controls.BindableObject,Microsoft.Maui.Controls.BindableProperty,System.Func`2<Microsoft.Maui.Controls.BaseShellItem, Microsoft.Maui.Controls.ImageSource>,Microsoft.Maui.Controls.BindingMode,Microsoft.Maui.Controls.IValueConverter,object,string,object,object,object) | ||
| void Microsoft.Maui.Controls.Generated.GeneratedBindingInterceptors:SetBinding570983195 (Microsoft.Maui.Controls.BindableObject,Microsoft.Maui.Controls.BindableProperty,System.Func`2<Microsoft.Maui.Controls.BaseShellItem, string>,Microsoft.Maui.Controls.BindingMode,Microsoft.Maui.Controls.IValueConverter,object,string,object,object,object) | ||
| void Microsoft.Maui.Controls.Generated.GeneratedBindingInterceptors:SetBinding1310226827 (Microsoft.Maui.Controls.BindableObject,Microsoft.Maui.Controls.BindableProperty,System.Func`2<Microsoft.Maui.Controls.BaseShellItem, Microsoft.Maui.Controls.ImageSource>,Microsoft.Maui.Controls.BindingMode,Microsoft.Maui.Controls.IValueConverter,object,string,object,object,object) | ||
| void Microsoft.Maui.Controls.Generated.GeneratedBindingInterceptors:SetBinding1361557553 (Microsoft.Maui.Controls.BindableObject,Microsoft.Maui.Controls.BindableProperty,System.Func`2<Microsoft.Maui.Controls.BaseShellItem, string>,Microsoft.Maui.Controls.BindingMode,Microsoft.Maui.Controls.IValueConverter,object,string,object,object,object) | ||
| void Microsoft.Maui.Controls.Generated.GeneratedBindingInterceptors:SetBinding1463606174 (Microsoft.Maui.Controls.BindableObject,Microsoft.Maui.Controls.BindableProperty,System.Func`2<Microsoft.Maui.Controls.BaseShellItem, Microsoft.Maui.Controls.ImageSource>,Microsoft.Maui.Controls.BindingMode,Microsoft.Maui.Controls.IValueConverter,object,string,object,object,object) | ||
| void Microsoft.Maui.Controls.Generated.GeneratedBindingInterceptors:SetBinding57528121 (Microsoft.Maui.Controls.BindableObject,Microsoft.Maui.Controls.BindableProperty,System.Func`2<Microsoft.Maui.Controls.BaseShellItem, string>,Microsoft.Maui.Controls.BindingMode,Microsoft.Maui.Controls.IValueConverter,object,string,object,object,object) |
Member
Author
There was a problem hiding this comment.
Just curious, @simonrozsival @jkurdek are the names like SetBinding1310226827 deterministic? Is it a hash of some kind?
Contributor
There was a problem hiding this comment.
Yes, it's a hash of the location
maui/src/Controls/src/BindingSourceGen/BindingSourceGenerator.cs
Lines 42 to 49 in d541b54
rmarinho
approved these changes
Oct 24, 2024
jonathanpeppers
enabled auto-merge (squash)
October 24, 2024 17:40
rmarinho
disabled auto-merge
October 25, 2024 01:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are very few changes as this point, but recording a new profile shows a few changes, and maybe improvement by a very small amount:
This is an average of 10 runs on a
dotnet new mauitemplate on a Pixel 7 Pro.It might be effectively the same, but it's worth updating I suppose.
Fixes #25403