Skip to content

[nuget-msi-convert] Do not use new VS component IDs - #25355

Merged
PureWeen merged 1 commit into
release/9.0.1xxfrom
dev/pjc/revert-new-vsids
Oct 18, 2024
Merged

[nuget-msi-convert] Do not use new VS component IDs#25355
PureWeen merged 1 commit into
release/9.0.1xxfrom
dev/pjc/revert-new-vsids

Conversation

@pjcollins

Copy link
Copy Markdown
Member

Context: ce01c15

We've decided hold off on this change until .NET 10.

@pjcollins
pjcollins requested a review from a team as a code owner October 17, 2024 19:37
@pjcollins

Copy link
Copy Markdown
Member Author

@rmarinho we'll need this in all .NET 9 branches where this prop was added and set to true.

@PureWeen
PureWeen changed the base branch from net9.0 to release/9.0.1xx October 17, 2024 21:03
@PureWeen
PureWeen requested a review from a team as a code owner October 17, 2024 21:03
@PureWeen
PureWeen force-pushed the dev/pjc/revert-new-vsids branch from 5314054 to feaf17e Compare October 17, 2024 21:11
@jsuarezruiz

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@PureWeen

Copy link
Copy Markdown
Member

/rebase

Context: ce01c15

We've decided hold off on this change until .NET 10.
@github-actions
github-actions Bot force-pushed the dev/pjc/revert-new-vsids branch from feaf17e to 1eca4e3 Compare October 18, 2024 13:06
@PureWeen

Copy link
Copy Markdown
Member
  • Failing tests are unrelated

@PureWeen
PureWeen merged commit f5ca66a into release/9.0.1xx Oct 18, 2024
@PureWeen
PureWeen deleted the dev/pjc/revert-new-vsids branch October 18, 2024 20:01
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants