[Rgen] Compile all platforms provided in parallel. by mandel-macaque · Pull Request #22024 · dotnet/macios

mandel-macaque · 2025-01-21T19:52:12Z

Allow the command line to be used with more than one rsp. That allows to pass all the rsp for the different platforms we support allowing us to merge the compilation results later to be used by the transformation.

mcumming · 2025-01-21T19:53:59Z

+					$"Microsoft.Macios.Transformer v{typeof(Program).Assembly.GetName ().Version}, (c) Microsoft Corporation. All rights reserved.\n");
+
+				// Convert local to absolute, expand ~
+				//rspPath = ToAbsolutePath (rspPath);


bit: remove?

oops, cleaning.

github-actions · 2025-01-21T19:56:24Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

mandel-macaque · 2025-01-21T23:47:56Z

Failure is unrelated to the change.

vs-mobiletools-engineering-service2 · 2025-01-22T00:27:49Z

✅ [CI Build] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 0ab074390689880fe9269804a0156341d30251f6 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-22T00:35:50Z

✅ [CI Build] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 0ab074390689880fe9269804a0156341d30251f6 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-22T00:54:57Z

✅ [CI Build] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 0ab074390689880fe9269804a0156341d30251f6 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-22T01:08:09Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 0ab074390689880fe9269804a0156341d30251f6 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-22T01:13:05Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 0ab074390689880fe9269804a0156341d30251f6 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-22T01:13:07Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 0ab074390689880fe9269804a0156341d30251f6 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-22T01:13:51Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 0ab074390689880fe9269804a0156341d30251f6 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-22T01:14:06Z

💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 0ab074390689880fe9269804a0156341d30251f6 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-22T01:14:37Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

iOS: vsdrops gist ( ❗ Breaking changes ❗ )
tvOS: vsdrops gist ( ❗ Breaking changes ❗ )
MacCatalyst: vsdrops gist ( ❗ Breaking changes ❗ )
macOS: vsdrops gist ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 0ab074390689880fe9269804a0156341d30251f6 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-22T03:29:46Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 112 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 0ab074390689880fe9269804a0156341d30251f6 [PR build]

[Rgen] Compile all platforms provided in parallel.

98e0721

Allow the command line to be used with more than one rsp. That allows to pass all the rsp for the different platforms we support allowing us to merge the compilation results later to be used by the transformation.

mcumming approved these changes Jan 21, 2025

View reviewed changes

Auto-format source code

02e13c6

Clean not needed comment.

002077c

dalexsoto approved these changes Jan 21, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

mandel-macaque merged commit 0ab0743 into main Jan 21, 2025

mandel-macaque deleted the dev/mandel/multiple-apidefinitions branch January 21, 2025 23:48

Uh oh!

Conversation

mandel-macaque commented Jan 21, 2025

Uh oh!

mcumming Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

mandel-macaque Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jan 21, 2025

⚠️ Your code has been reformatted. ⚠️

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mandel-macaque commented Jan 21, 2025

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 22, 2025

✅ [CI Build] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 22, 2025

✅ [CI Build] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 22, 2025

✅ [CI Build] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 22, 2025

💻 [CI Build] Windows Integration Tests passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 22, 2025

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 22, 2025

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 22, 2025

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 22, 2025

💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 22, 2025

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 22, 2025

🚀 [CI Build] Test results 🚀

Test results

Tests counts

Uh oh!

Reviewers