Skip to content

Disable failing weak reference leak test - #11755

Merged
jonathanpeppers merged 1 commit into
dotnet:mainfrom
simonrozsival:dev/simonrozsival/disable-weakref-leak-test
Jun 26, 2026
Merged

Disable failing weak reference leak test#11755
jonathanpeppers merged 1 commit into
dotnet:mainfrom
simonrozsival:dev/simonrozsival/disable-weakref-leak-test

Conversation

@simonrozsival

@simonrozsival simonrozsival commented Jun 26, 2026

Copy link
Copy Markdown
Member

The Java.InteropTests.JnienvTest.DoNotLeakWeakReferences test is very flaky and we should look into why that is - is there a bug in the gc bridge/value manager/somewhere else or is it just the test that's unreliable?

There is an existing issue to look into this problem: #11690

Testing

  • git diff --check -- tests/Mono.Android-Tests/Mono.Android-Tests/Java.Interop/JnienvTest.cs

Refs #11690

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 26, 2026 12:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables a flaky/failing GC bridge test related to weak reference leak detection while a NativeAOT-specific regression is investigated (tracked in #11690).

Changes:

  • Adds an NUnit attribute to skip Java.InteropTests.JnienvTest.DoNotLeakWeakReferences and links the ignore reason to the tracking issue.
Show a summary per file
File Description
tests/Mono.Android-Tests/Mono.Android-Tests/Java.Interop/JnienvTest.cs Marks DoNotLeakWeakReferences as ignored due to a NativeAOT failure, referencing the tracking issue.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

@simonrozsival simonrozsival added the ready-to-review This PR is ready to review/merge, I think any CI failures are just flaky (ignorable). label Jun 26, 2026
@jonathanpeppers
jonathanpeppers merged commit 3a461cb into dotnet:main Jun 26, 2026
40 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ready-to-review This PR is ready to review/merge, I think any CI failures are just flaky (ignorable).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants