Add node field to PolymerDomApi - #5598
Conversation
And keep DomApiNative type compatible with PolymerDomApi. Upstreaming cl/275091781
|
I think this should go to |
|
Either place... we're regularly merging |
|
Curious what was relying on |
|
It looks like it's from a desire to unwrap a PolymerDomApi value back to its underlying dom value in order to pass it to a basic DOM handling API. Might have been totally based on a type error from the compiler and it may have worked fine at runtime, in which case maybe they should just cast the PolymerDomApi as a Node instead. To check out the code, see http://cs/setPolymerNodeContent |
|
@sorvell Can you review? |
sorvell
left a comment
There was a problem hiding this comment.
I think this is basically fine. The original intent was that this was private, but it was never marked so and it's not going to change at this point so it seems ok.
And keep DomApiNative type compatible with PolymerDomApi.
Upstreaming cl/275091781