Page MenuHomePhabricator

TypeError: Cannot read properties of undefined (reading 'set')
Closed, ResolvedPublicPRODUCTION ERROR

Description

A few errors related to the same code:

  • TypeError: Cannot read properties of undefined (reading 'set')
  • TypeError: can't access property "set", mw.user.clientPrefs is undefined
  • TypeError: Cannot read property 'set' of undefined
  • TypeError: mw.user.clientPrefs is undefined
  • TypeError: undefined is not an object (evaluating 'mw.user.clientPrefs.set')

Over 4000 errors in the 12 hours or so. Stack trace for the second error is the most helpful:

at init https://en.wikipedia.org/w/load.php?lang=en&modules=ext.wikimediaCustomizations.donorDelightBadge&skin=minerva&version=4kjzd:1:439
at mightThrow https://en.wikipedia.org/w/load.php?lang=en&modules=ext.centralNotice.choiceData%7Cjquery%7Cmediawiki.base&skin=minerva&version=13xnt:46:983
at Deferred/then/resolve/</process< https://en.wikipedia.org/w/load.php?lang=en&modules=ext.centralNotice.choiceData%7Cjquery%7Cmediawiki.base&skin=minerva&version=13xnt:47:643

This is related to the donor badge experiment in WikimediaCustomizations.

Steps to replicate the issue (include links if applicable):

What happens?:

What should have happened instead?:

Software version: 1.47.0-wmf.4

Other information: Specific to MinervaNeue

Event Timeline

Restricted Application changed the subtype of this task from "Bug Report" to "Production Error". · View Herald TranscriptMon, Jun 1, 8:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1296017 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/extensions/WikimediaCustomizations@master] Donor Delight Badge: Add dependency on mw.user

https://gerrit.wikimedia.org/r/1296017

Change #1296022 had a related patch set uploaded (by Jdlrobson; author: Anne Tomasevich):

[mediawiki/extensions/WikimediaCustomizations@wmf/1.47.0-wmf.4] Donor Delight Badge: Add dependency on mw.user

https://gerrit.wikimedia.org/r/1296022

Change #1296017 merged by jenkins-bot:

[mediawiki/extensions/WikimediaCustomizations@master] Donor Delight Badge: Add dependency on mw.user

https://gerrit.wikimedia.org/r/1296017

Change #1296022 merged by jenkins-bot:

[mediawiki/extensions/WikimediaCustomizations@wmf/1.47.0-wmf.4] Donor Delight Badge: Add dependency on mw.user

https://gerrit.wikimedia.org/r/1296022

Mentioned in SAL (#wikimedia-operations) [2026-06-01T23:05:59Z] <jdlrobson@deploy1003> Started scap sync-world: Backport for [[gerrit:1296022|Donor Delight Badge: Add dependency on mw.user (T427850)]], [[gerrit:1296028|styles: Limit selector to badge client pref (T427407)]]

Mentioned in SAL (#wikimedia-operations) [2026-06-01T23:07:43Z] <jdlrobson@deploy1003> jdlrobson: Backport for [[gerrit:1296022|Donor Delight Badge: Add dependency on mw.user (T427850)]], [[gerrit:1296028|styles: Limit selector to badge client pref (T427407)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-06-01T23:15:32Z] <jdlrobson@deploy1003> Finished scap sync-world: Backport for [[gerrit:1296022|Donor Delight Badge: Add dependency on mw.user (T427850)]], [[gerrit:1296028|styles: Limit selector to badge client pref (T427407)]] (duration: 09m 33s)

Jdlrobson-WMF lowered the priority of this task from Unbreak Now! to Medium.Mon, Jun 1, 11:24 PM

Patch has been backported and the errors are now trailing off.

As this is a purely technical task, it makes sense to have an engineer do the QA and sign-off part. cc: @AnneT