Page MenuHomePhabricator

[Image Browsing] Carousel: Duplicate images in article body will lead to duplicate carousel items
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

Note – I've replicated this in my local development wiki setup. If I create a test case on TestWiki I will link it here.

  • Go to a page where the same image appears multiple times in the article body (not sure how often this happens in real world scenarios)
  • Log in and enable the carousel Beta feature
  • View the page

What happens?:
You will see the same carousel image appear multiple times (once for each time it's present on the page)

What should have happened instead?:
We want to de-duplicate carousel entries.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

This is not necessary a blocker for rolling out the carousel as a beta feature for real users.

Change #1295951 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/MultimediaViewer@master] Move image deduplication around

https://gerrit.wikimedia.org/r/1295951

Change #1295951 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Move image deduplication around

https://gerrit.wikimedia.org/r/1295951

matthiasmullie set the point value for this task to 1.Tue, Jun 2, 4:13 PM