Page MenuHomePhabricator

Search icon appears on the left on mobile while logged out on certain wikis
Closed, ResolvedPublicBUG REPORT

Assigned To
Authored By
Nintendofan885
Wed, May 27, 3:17 PM

Description

Steps to replicate the issue (include links if applicable):

What happens?:
Search icon appears near on the left hand side next to 'Wikidata' rather than on the right

What should have happened instead?:
Appears on the right like other wikis

I checked several wikis and seems like it happens while logged out on Meta, MediaWiki.org, Incubator and outreachwiki but displays fine on enwiki, eswiki and Wikifunctions.

@stjn: Source was icon (badge container with icon) added in T424069: [EPIC] WE 3.5.5 Donor badge experiment.

Screenshot_20260527_142026_com_android_chrome_ChromeTabbedActivity.jpg (1,100×148 px, 18 KB)

BDD

Feature: Search position in the mobile header with donor-badge styles

  Scenario: Logged-out mobile user on an affected wiki
    Given I am a logged-out user on mobile web (Minerva) on a wiki that loads the donor badge styles
    And the donor badge is off (minerva-badge-clientpref-0, badge container hidden)
    When I open a page
    Then the search appears on the right of the header
    And it is not shifted to the left next to the wordmark

Test Plan

Test Case 1: Beta (master) — affected wiki, logged out

  1. Open www.wikidata.beta.wmcloud.org logged out, mobile/Minerva (DevTools device emulation, e.g. iPhone 14 Pro Max).
  2. AC1: Search appears on the right of the header; donor badge container is hidden (minerva-badge-clientpref-0); search is not shifted to the left.

Test Case 2: Production (1.47.0-wmf.4) — affected wikis, logged out

  1. Open each reported wiki logged out, mobile/Minerva: www.wikidata.org (URL in the report), meta.wikimedia.org, www.mediawiki.org, incubator.wikimedia.org, outreach.wikimedia.org.
  2. AC2: On every wiki the search appears on the right of the header (not shifted left); badge container hidden.

QA Results - Beta/Prod

ACStatusDetails
1beta Wikidata, logged out T427407#11995371
2wikidata/meta/mediawiki/incubator/outreach, wmf.4, logged out T427407#11995371

Event Timeline

Nintendofan885 renamed this task from Search icon appears on the left on mobile while logged out on certain wikis to Search icon appears on the left on mobile on certain wikis while logged out.Wed, May 27, 3:22 PM
Nintendofan885 renamed this task from Search icon appears on the left on mobile on certain wikis while logged out to Search icon appears on the left on mobile while logged out on certain wikis.Wed, May 27, 3:26 PM

Icon from FY25-26 WE3.5 Donor Identification and recognition project gets added and then hidden for mobile users, which moves the search icon to the left even though it’s not supposed to be there.

Specifically this CSS makes the icon move to the left:

.minerva-badge-clientpref-0 .minerva-badge-container {
	display: none;
}

Change #1295975 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/WikimediaCustomizations@master] Scope all donor delight styles to HTML class

https://gerrit.wikimedia.org/r/1295975

Change #1296025 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/WikimediaCustomizations@master] styles: Limit selector to badge client pref

https://gerrit.wikimedia.org/r/1296025

Change #1296028 had a related patch set uploaded (by Jdlrobson; author: VolkerE):

[mediawiki/extensions/WikimediaCustomizations@wmf/1.47.0-wmf.4] styles: Limit selector to badge client pref

https://gerrit.wikimedia.org/r/1296028

Change #1295975 abandoned by Jdlrobson:

[mediawiki/extensions/WikimediaCustomizations@master] Scope all donor delight styles to HTML class

https://gerrit.wikimedia.org/r/1295975

Change #1296025 merged by jenkins-bot:

[mediawiki/extensions/WikimediaCustomizations@master] styles: Limit selector to badge client pref

https://gerrit.wikimedia.org/r/1296025

Change #1296028 merged by jenkins-bot:

[mediawiki/extensions/WikimediaCustomizations@wmf/1.47.0-wmf.4] styles: Limit selector to badge client pref

https://gerrit.wikimedia.org/r/1296028

Mentioned in SAL (#wikimedia-operations) [2026-06-01T23:05:59Z] <jdlrobson@deploy1003> Started scap sync-world: Backport for [[gerrit:1296022|Donor Delight Badge: Add dependency on mw.user (T427850)]], [[gerrit:1296028|styles: Limit selector to badge client pref (T427407)]]

Mentioned in SAL (#wikimedia-operations) [2026-06-01T23:07:43Z] <jdlrobson@deploy1003> jdlrobson: Backport for [[gerrit:1296022|Donor Delight Badge: Add dependency on mw.user (T427850)]], [[gerrit:1296028|styles: Limit selector to badge client pref (T427407)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-06-01T23:15:32Z] <jdlrobson@deploy1003> Finished scap sync-world: Backport for [[gerrit:1296022|Donor Delight Badge: Add dependency on mw.user (T427850)]], [[gerrit:1296028|styles: Limit selector to badge client pref (T427407)]] (duration: 09m 33s)

Jdlrobson-WMF lowered the priority of this task from High to Low.Mon, Jun 1, 11:26 PM
Jdlrobson-WMF subscribed.

This has now been backported.

Volker_E updated Other Assignee, added: Volker_E.
NOTE: This was validated on June 2, but documented here today.

Test Result - Beta

Status: ✅ PASS
Environment: www.wikidata.beta.wmcloud.org (master)
OS: macOS Tahoe 26.x
Browser: Chrome Canary (latest as of test date)
Device: MS
Emulated Device: iPhone 14 Pro Max (DevTools device toolbar, 430px)

Test Case 1: Affected wiki, logged out

  1. Open www.wikidata.beta.wmcloud.org logged out, mobile/Minerva.
  2. ✅ AC1: Search is on the right of the header; donor badge container hidden (minerva-badge-clientpref-0, computed display:none); search is not shifted to the left.

www.wikidata.beta.wmcloud.org_wiki_Wikidata_Main_Page(iPhone 17 Pro Max).png (1,290×2,796 px, 579 KB)

Test Result - Prod

Status: ✅ PASS
Environment: production 1.47.0-wmf.4 — www.wikidata.org, meta.wikimedia.org, www.mediawiki.org, incubator.wikimedia.org, outreach.wikimedia.org
OS: macOS Tahoe 26.x
Browser: Chrome Canary (latest as of test date)
Device: MS
Emulated Device: iPhone 14 Pro Max (DevTools device toolbar, 430px)

Test Case 1: Affected wikis from the report, logged out

  1. Open each wiki logged out, mobile/Minerva.
  2. ✅ AC1: Search is on the right of the header (not shifted left) on all affected wikis — www.wikidata.org (report URL), meta.wikimedia.org, www.mediawiki.org, incubator.wikimedia.org, outreach.wikimedia.org. Donor badge container computed display:none on all; skin=minerva, anonymous, 430px viewport.

The fix (gerrit 1296025 / 1296028, "styles: Limit selector to badge client pref") is present on master (beta) and 1.47.0-wmf.4 (production).

meta.wikimedia.org_wiki_Special_MyLanguage_Main_Page(iPhone 17 Pro Max).png (1,290×2,796 px, 436 KB)

www.wikidata.org_wiki_Wikidata_Main_Page(iPhone 17 Pro Max).png (1,290×2,796 px, 575 KB)

www.mediawiki.org_wiki_MediaWiki(iPhone 17 Pro Max).png (1,290×2,796 px, 2 MB)

incubator.wikimedia.org_wiki_Special_MyLanguage_Incubator_Main_Page(iPhone 17 Pro Max).png (1,290×2,796 px, 722 KB)

outreach.wikimedia.org_wiki_Special_MyLanguage_Main_Page(iPhone 17 Pro Max).png (1,290×2,796 px, 919 KB)