Page MenuHomePhabricator
Create Task
Maniphest T427336

Carousel: Limit the feature to article pages only
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Scenario

WHEN I'm on https://test.wikipedia.org, using Minerva skin, logged in to my user account, with the carousel beta feature enabled (note: this is only available on testwiki for the moment),
AND I navigate to a file page that has 3 or more images (due to templates present on the page)...

I see the carousel appear above the File Page like so:

Screen Shot 2026-05-26 at 15.16.37.png (1,179×2,556 px, 2 MB)

Expected Behavior

The carousel should only appear on qualifying article pages. Other pages types (File pages, Talk pages, Special pages, etc) should never get it.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Image Carousel: check candidate pagesmediawiki/extensions/MultimediaViewermaster+30 -27
Image Carousel: check candidate pagesmediawiki/extensions/MultimediaViewerwmf/1.47.0-wmf.4+30 -27
Carousel only on articlesmediawiki/extensions/MultimediaViewerwmf/1.47.0-wmf.4+10 -9
Carousel only on articlesmediawiki/extensions/MultimediaViewermaster+10 -9
Customize query in gerrit

Related Objects
Search...

Event Timeline

egardner created this task.Tue, May 26, 10:24 PM
egardner triaged this task as High priority.Tue, May 26, 10:30 PM
matthiasmullie claimed this task.Wed, May 27, 11:57 AM
gerritbot added a comment.Wed, May 27, 11:59 AM

Change #1294263 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/MultimediaViewer@master] Carousel only on articles

https://gerrit.wikimedia.org/r/1294263

gerritbot added a project: Patch-For-Review.Wed, May 27, 11:59 AM
matthiasmullie moved this task from Committed to Code Review on the Reader Growth Team (Sprint 4 (May 13 - 26) Q4 25/26) board.Wed, May 27, 11:59 AM
matthiasmullie set the point value for this task to 1.Wed, May 27, 12:12 PM
Aklapper added a project: MediaViewer.Wed, May 27, 4:38 PM
gerritbot added a comment.Wed, May 27, 5:16 PM

Change #1294263 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Carousel only on articles

https://gerrit.wikimedia.org/r/1294263

Maintenance_bot removed a project: Patch-For-Review.Wed, May 27, 5:31 PM
gerritbot added a comment.Wed, May 27, 6:05 PM

Change #1294370 had a related patch set uploaded (by Eric Gardner; author: Matthias Mullie):

[mediawiki/extensions/MultimediaViewer@wmf/1.47.0-wmf.4] Carousel only on articles

https://gerrit.wikimedia.org/r/1294370

gerritbot added a project: Patch-For-Review.Wed, May 27, 6:05 PM
gerritbot added a comment.Wed, May 27, 10:03 PM

Change #1294370 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@wmf/1.47.0-wmf.4] Carousel only on articles

https://gerrit.wikimedia.org/r/1294370

Stashbot added a comment.Wed, May 27, 10:03 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-27T22:03:41Z] <egardner@deploy1003> Started scap sync-world: Backport for [[gerrit:1294370|Carousel only on articles (T427336)]]

Stashbot added a comment.Wed, May 27, 10:05 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-27T22:05:36Z] <egardner@deploy1003> egardner: Backport for [[gerrit:1294370|Carousel only on articles (T427336)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Wed, May 27, 10:13 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-27T22:13:41Z] <egardner@deploy1003> Finished scap sync-world: Backport for [[gerrit:1294370|Carousel only on articles (T427336)]] (duration: 10m 00s)

Maintenance_bot removed a project: Patch-For-Review.Wed, May 27, 10:30 PM
gerritbot added a comment.Thu, May 28, 10:34 AM

Change #1294950 had a related patch set uploaded (by Marco Fossati; author: Marco Fossati):

[mediawiki/extensions/MultimediaViewer@master] Image Carousel: check candidate pages

https://gerrit.wikimedia.org/r/1294950

gerritbot added a project: Patch-For-Review.Thu, May 28, 10:34 AM
mfossati edited projects, added: Reader Growth Team (Sprint 5 (May 27 - Jun 9) Q4 25/26); removed: Reader Growth Team (Sprint 4 (May 13 - 26) Q4 25/26).Thu, May 28, 10:43 AM
mfossati moved this task from Committed to Code Review on the Reader Growth Team (Sprint 5 (May 27 - Jun 9) Q4 25/26) board.
gerritbot added a comment.Thu, May 28, 12:59 PM

Change #1294986 had a related patch set uploaded (by Matthias Mullie; author: Marco Fossati):

[mediawiki/extensions/MultimediaViewer@wmf/1.47.0-wmf.4] Image Carousel: check candidate pages

https://gerrit.wikimedia.org/r/1294986

gerritbot added a comment.Thu, May 28, 1:13 PM

Change #1294950 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Image Carousel: check candidate pages

https://gerrit.wikimedia.org/r/1294950

gerritbot added a comment.Thu, May 28, 1:29 PM

Change #1294986 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@wmf/1.47.0-wmf.4] Image Carousel: check candidate pages

https://gerrit.wikimedia.org/r/1294986

Stashbot added a comment.Thu, May 28, 1:29 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-28T13:29:19Z] <mlitn@deploy1003> Started scap sync-world: Backport for [[gerrit:1294986|Image Carousel: check candidate pages (T427336)]]

Maintenance_bot removed a project: Patch-For-Review.Thu, May 28, 1:30 PM
Stashbot added a comment.Thu, May 28, 1:31 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-28T13:31:05Z] <mlitn@deploy1003> mlitn: Backport for [[gerrit:1294986|Image Carousel: check candidate pages (T427336)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Thu, May 28, 1:36 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-28T13:36:00Z] <mlitn@deploy1003> Finished scap sync-world: Backport for [[gerrit:1294986|Image Carousel: check candidate pages (T427336)]] (duration: 06m 40s)

matthiasmullie moved this task from Code Review to QA on the Reader Growth Team (Sprint 5 (May 27 - Jun 9) Q4 25/26) board.Thu, May 28, 1:54 PM
mfossati closed this task as Resolved.Thu, May 28, 4:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits