Page MenuHomePhabricator
Create Task
Maniphest T427327

Handle article already exists in manual outline selection case
Open, HighPublic2 Estimated Story Points
Actions

Description

As part of the Article Guidance work (T396029), the workflow takes in consideration when the Wikipedia has already an article with the provided title to invite users to update the title. This was specified and implemented in T421196: Support case where the article title is already taken.

A regression seem to have affected this part of the process. Currently, it is possible to select an article that already exists and proceed with the workflow without an appropriate handling.
An example is illustrated below based on the following steps:

  1. Start a new article on Simple English Wikipedia with the title "Blues".
  2. Continue through the Article Guidance Workflow, observing that the UI behaves as if the article didn't exist.
  3. Reach Visual Editor and observe how the existing article contents are loaded.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Check for title taken on manual outline selectionmediawiki/extensions/ArticleGuidancemaster+33 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

Pginer-WMF created this task.Tue, May 26, 8:47 PM
Pginer-WMF triaged this task as High priority.
Pginer-WMF added a project: Regression.
Pginer-WMF moved this task from Backlog to Prioritized on the LPL Hypothesis board.
SBisson claimed this task.Wed, May 27, 6:34 PM
SBisson moved this task from Backlog to In-Editor workflow on the Article-Guidance board.
gerritbot added a comment.Wed, May 27, 6:35 PM

Change #1294378 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/ArticleGuidance@master] Check for title taken on manual outline selection

https://gerrit.wikimedia.org/r/1294378

gerritbot added a project: Patch-For-Review.Wed, May 27, 6:35 PM
SBisson moved this task from Prioritized to Needs Code Review on the LPL Hypothesis board.Wed, May 27, 6:35 PM
Nikerabbit set the point value for this task to 2.Mon, Jun 1, 12:48 PM
Nikerabbit added a project: LPL Projects (Guided article creation - FY26 WE 1.10).
Nikerabbit subscribed.

Do we know what caused the regression?

SBisson added a comment.Mon, Jun 1, 12:55 PM
In T427327#11971870, @Nikerabbit wrote:

Do we know what caused the regression?

Not a regression. Checking for title already taken was not done in the manual outline selection code path.

Nikerabbit renamed this task from Regression for handling cases when article title is already taken to Handle article already exists in manual outline selection case.Mon, Jun 1, 12:58 PM
Nikerabbit removed a project: Regression.
Nikerabbit updated the task description. (Show Details)
gerritbot added a comment.Mon, Jun 1, 9:39 PM

Change #1294378 merged by jenkins-bot:

[mediawiki/extensions/ArticleGuidance@master] Check for title taken on manual outline selection

https://gerrit.wikimedia.org/r/1294378

Maintenance_bot removed a project: Patch-For-Review.Mon, Jun 1, 10:31 PM
SBisson moved this task from Needs Code Review to Pending deployment on the LPL Hypothesis board.Tue, Jun 2, 4:29 PM
SBisson moved this task from Pending deployment to Design Signoff on the LPL Hypothesis board.Thu, Jun 4, 6:42 PM
SGautam_WMF added a comment.EditedWed, Jun 10, 10:28 AM

This is working fine but this Selected subject seems to only work for items selected from wikidata search but not for manual outlines. @SBisson shall we do it as part of separate task, or move this one back to dev? I realized this may need a little bit different treatment as they are not selecting subject here rather choosing a manual outline

New Article Moto G4 (36).png (1,080×1,920 px, 185 KB)

SBisson added a comment.Wed, Jun 10, 12:34 PM

@SGautam_WMF yes, maybe show the selected outline in this case?

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits