Page MenuHomePhabricator

ConfirmEdit extension CI blocked by Phan failures caused by VisualEditor
Closed, ResolvedPublic

Description

Summary

ConfirmEdit (CAPTCHA extension) CI is blocked by Phan failures on the master branch. This is due to the merge of bf464b94c6d38a894b890a2d25d7e7cff7c3866e

Technical details

20:51:43 includes/Hooks/Handlers/MakeGlobalVariablesScriptHookHandler.php:37 PhanRedefinedClassReference Saw reference to \MobileContext declared at ../../extensions/MobileFrontend/includes/MobileContext.php:16 which is also declared at ../../extensions/VisualEditor/.phan/stubs/MobileContext.php:7. This may lead to confusing errors. It may be possible to exclude the class that isn't used with exclude_file_list. In addition to normal ways to suppress issues, this issue type can be suppressed on either of the class definitions if it is impractical to exclude one file.
20:51:43 includes/Hooks/Handlers/MakeGlobalVariablesScriptHookHandler.php:58 PhanRedefinedClassReference Saw reference to \MobileContext declared at ../../extensions/MobileFrontend/includes/MobileContext.php:16 which is also declared at ../../extensions/VisualEditor/.phan/stubs/MobileContext.php:7. This may lead to confusing errors. It may be possible to exclude the class that isn't used with exclude_file_list. In addition to normal ways to suppress issues, this issue type can be suppressed on either of the class definitions if it is impractical to exclude one file.

Acceptance criteria

Event Timeline

Dreamy_Jazz renamed this task from ConfirmEdit extension CI blocked to ConfirmEdit extension CI blocked by Phan failures caused by VisualEditor.Tue, May 26, 8:28 PM

Change #1293797 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/VisualEditor@master] Revert "Use DI for UserOptionsLookup, ConfigFactory, HookContainer, and MobileContext"

https://gerrit.wikimedia.org/r/1293797

Change #1293799 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/ConfirmEdit@master] Exclude VisualEditor MobileContext stub to unblock CI

https://gerrit.wikimedia.org/r/1293799

Change #1293797 abandoned by Dreamy Jazz:

[mediawiki/extensions/VisualEditor@master] Revert "Use DI for UserOptionsLookup, ConfigFactory, HookContainer, and MobileContext"

Reason:

Better solved by If722ca47874de5f1bbfa633202260c5f1f7a53e3

https://gerrit.wikimedia.org/r/1293797

Change #1293799 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] Exclude VisualEditor MobileContext stub to unblock CI

https://gerrit.wikimedia.org/r/1293799

ConfirmEdit (CAPTCHA extension) CI unblocked, so this can be resolved (DiscussionTools and GrowthExperiments CI remains blocked but they can be fixed elsewhere)