Page MenuHomePhabricator
Create Task
Maniphest T427098

mw:Param meta tags can sometimes leak through unprocessed
Closed, ResolvedPublic
Actions

Description

Investigating T426649: PHP Warning: Undefined property: Wikimedia\Parsoid\NodeData\DataMw::$parts led me to https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/1290919 and in the process of debugging, I noticed that we had mw:Param metas in the DOM Range Builder after template wrapping. That was surprising because they weren't supposed to get through that far. But, I deferred going down that rabbit hole and opted to fix the warnings in a different way which also made the code a bit more clearer on its own. But, the regression test added there exposes this meta leakage. We should investigate how they escape processing and clean it up ideally.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Bump wikimedia/parsoid to 0.24.0-a6mediawiki/vendorwmf/1.47.0-wmf.4+61 -34
Bump wikimedia/parsoid to 0.24.0-a6mediawiki/vendormaster+61 -34
Set inTemplate pipeline opt when reprocessing tokensmediawiki/services/parsoidmaster+15 -7
Customize query in gerrit

Related Objects

Event Timeline

ssastry created this task.Fri, May 22, 9:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, May 22, 9:48 PM
ssastry triaged this task as Low priority.Fri, May 22, 9:50 PM
ABreault-WMF claimed this task.Fri, May 22, 10:15 PM
gerritbot added a comment.Mon, May 25, 7:31 PM

Change #1293154 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Set inTemplate pipeline opt when reprocessing tokens

https://gerrit.wikimedia.org/r/1293154

gerritbot added a project: Patch-For-Review.Mon, May 25, 7:31 PM
ABreault-WMF edited projects, added: Content-Transform-Team (Work In Progress); removed: Content-Transform-Team.Mon, May 25, 7:31 PM
ABreault-WMF moved this task from Backlog to Code Review on the Content-Transform-Team (Work In Progress) board.
gerritbot added a comment.Tue, May 26, 10:13 PM

Change #1293154 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Set inTemplate pipeline opt when reprocessing tokens

https://gerrit.wikimedia.org/r/1293154

Maintenance_bot removed a project: Patch-For-Review.Tue, May 26, 10:31 PM
ABreault-WMF moved this task from Code Review to To Deploy on the Content-Transform-Team (Work In Progress) board.Tue, May 26, 10:41 PM
MSantos moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.Thu, May 28, 2:26 PM
gerritbot added a comment.Thu, May 28, 5:42 PM

Change #1295051 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.24.0-a6

https://gerrit.wikimedia.org/r/1295051

gerritbot added a project: Patch-For-Review.Thu, May 28, 5:42 PM
gerritbot added a comment.Thu, May 28, 6:36 PM

Change #1295051 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.24.0-a6

https://gerrit.wikimedia.org/r/1295051

gerritbot added a comment.Thu, May 28, 7:23 PM

Change #1295066 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@wmf/1.47.0-wmf.4] Bump wikimedia/parsoid to 0.24.0-a6

https://gerrit.wikimedia.org/r/1295066

gerritbot added a comment.Thu, May 28, 8:40 PM

Change #1295066 merged by jenkins-bot:

[mediawiki/vendor@wmf/1.47.0-wmf.4] Bump wikimedia/parsoid to 0.24.0-a6

https://gerrit.wikimedia.org/r/1295066

Stashbot mentioned this in T420336: mw-parsoid improvements.Thu, May 28, 8:41 PM
Stashbot mentioned this in T427354: PHP Deprecated: Use of Wikimedia\Parsoid\Core\DomPageBundle::toDom without SiteConfig was deprecated in Parsoid 0.24. [Called from Wikimedia\Parsoid\Utils\ComputeSelectiveStats::classify].

Mentioned in SAL (#wikimedia-operations) [2026-05-28T20:41:14Z] <arlolra@deploy1003> Started scap sync-world: Backport for [[gerrit:1295066|Bump wikimedia/parsoid to 0.24.0-a6 (T420336 T427098 T427354 T427082)]], [[gerrit:1295067|Bump wikimedia/parsoid to 0.24.0-a6 (T427082)]]

Stashbot mentioned this in T427082: CTT tasks week of 2026-05-22.Thu, May 28, 8:41 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-28T20:43:02Z] <arlolra@deploy1003> arlolra: Backport for [[gerrit:1295066|Bump wikimedia/parsoid to 0.24.0-a6 (T420336 T427098 T427354 T427082)]], [[gerrit:1295067|Bump wikimedia/parsoid to 0.24.0-a6 (T427082)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Thu, May 28, 8:48 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-28T20:48:48Z] <arlolra@deploy1003> Finished scap sync-world: Backport for [[gerrit:1295066|Bump wikimedia/parsoid to 0.24.0-a6 (T420336 T427098 T427354 T427082)]], [[gerrit:1295067|Bump wikimedia/parsoid to 0.24.0-a6 (T427082)]] (duration: 07m 34s)

ABreault-WMF moved this task from To Deploy to To Verify on the Content-Transform-Team (Work In Progress) board.Thu, May 28, 8:52 PM
ABreault-WMF closed this task as Resolved.Thu, May 28, 8:56 PM

Pre-deploy, I took page from T426649 and looked at the html output and metas were clearly visible,

https://vi.wikipedia.org/wiki/Th%C3%A0nh_vi%C3%AAn:Nakon/cascade2

<meta typeof="mw:Param"/><meta typeof="mw:Param/End"/>

Post-deploy and purge, they are no longer there.

Maintenance_bot removed a project: Patch-For-Review.Thu, May 28, 9:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits