Page MenuHomePhabricator
Create Task
Maniphest T426740

QUnit test "ext.confirmEdit.hCaptcha.secureEnclave" fails on unrelated WikimediaEvents change
Closed, ResolvedPublic
Actions

Description

The following test now failed 3 times in a row on an unrelated WikimediaEvents change:

00:01:55.570 SUMMARY:
00:01:55.570 ✔ 1393 tests completed
00:01:55.571 ℹ 46 tests skipped
00:01:55.571 ✖ 1 test failed
00:01:55.571
00:01:55.571 FAILED TESTS:
00:01:55.572   ext.confirmEdit.hCaptcha.secureEnclave
00:01:55.572     ✖ should load hCaptcha exactly once when the form is interacted with [interaction with input element]
00:01:55.573       Firefox 140.0 (Linux 0.0.0)
00:01:55.573     global failure: TypeError: can't access property "targetLoader", mw.libs.ve is undefined
00:01:55.574     ext.confirmEdit.hCaptcha/init.js/initEditorIntegrations/<@http://127.0.0.1:9413/load.php?modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cmoment%2Coojs%2Coojs-ui%2Coojs-ui-core%2Coojs-ui-toolbars%2Coojs-ui-widgets%2Coojs-ui-windows%2Cpinia%2Csinonjs%2Cvue%2Cvue-test-utils%7Cext.centralauth.ForeignApi%7Cext.checkUser%2CeventLogging%2CglobalBlocking%2CtestKitchen%2CwikimediaEvents%7Cext.checkUser.clientHints%2CsuggestedInvestigations%2CtempAccounts%2CuserInfoCard%7Cext.confirmEdit.CaptchaWidget%2ChCaptcha%2CvisualEditor%7Cext.echo.api%2Cdm%2Cinit%7Cext.eventLogging.metricsPlatform%7Cext.wikimediaEvents.testKitchen%7Cjquery.client%2ChighlightText%2ClengthLimit%2CmakeCollapsible%2Ctablesorter%2CtextSelection%7Cjquery.makeCollapsible.styles%7Cjquery.tablesorter.styles%7Cmediawiki.DateFormatter%2CForeignApi%2CString%2CTitle%2CUri%2Capi%2Ccldr%2CconfirmCloseWindow%2Ccookie%2Cdeflate%2Cexperiments%2Chtmlform%2Cinspect%2CjqueryMsg%2Clanguage%2CmessagePoster%2Cqunit-testrunner%2Crouter%2Cstorage%2Ctemplate%2Ctoc%2Cuser%2Cutil%2CvisibleTimeout%2Cwidgets%7Cmediawiki.ForeignApi.core%7Cmediawiki.language.grammar.testdata%7Cmediawiki.language.jqueryMsg.testdata%7Cmediawiki.language.months%2Ctestdata%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.pager.codex%2Cstyles%7Cmediawiki.rcfilters.filters.ui%7Cmediawiki.special.block.codex%7Cmediawiki.template.mustache%7Cmediawiki.widgets.MediaSearch%2CTable%2CUserInputWidget%2Cstyles%7Coojs-ui-core.icons%2Cstyles%7Coojs-ui-toolbars.icons%7Coojs-ui-widgets.icons%7Coojs-ui-windows.icons%7Coojs-ui.styles.icons-content%2Cicons-editing-advanced%2Cicons-editing-core%2Cicons-editing-styling%2Cicons-interactions%2Cicons-layout%2Cicons-location%2Cicons-media%2Cicons-moderation%2Cicons-user%2Cindicators%7Cskins.vector.clientPreferences%7Ctest.CentralAuth%2CCheckUser%2CConfirmEdit%2CEcho%2CEventLogging%2CGlobalBlocking%2CMediaWiki%2CTestKitchen%2CVector%2CWikimediaEvents&version=1fz2t:1976:169
00:01:55.574

(logs 1, logs 2, logs 3)

This is blocking merges.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Skip init.test.js test if VisualEditor not installedmediawiki/extensions/ConfirmEditwmf/1.47.0-wmf.3+2 -1
Skip init.test.js test if VisualEditor not installedmediawiki/extensions/ConfirmEditmaster+2 -1
test: skip failing QUnit test to unblock unrelated changesmediawiki/extensions/ConfirmEditmaster+2 -2
hCaptcha: Stub mw.libs.ve in init.test.js to avoid async failuremediawiki/extensions/ConfirmEditmaster+21 -6
Customize query in gerrit

Related Objects

Event Timeline

Michael created this task.Tue, May 19, 10:53 AM
Restricted Application added a project: Product Safety and Integrity. · View Herald TranscriptTue, May 19, 10:53 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kostajh edited projects, added: Bot detection and mitigation (WE4.10 hCaptcha), Product Safety and Integrity (Sprint lily-of-the-valley (May 4 - May 22)); removed: Product Safety and Integrity.Tue, May 19, 11:36 AM
Dreamy_Jazz added subscribers: MPostoronca-WMF, Dreamy_Jazz.Tue, May 19, 11:43 AM
This comment was removed by Dreamy_Jazz.
gerritbot added a comment.Tue, May 19, 11:44 AM

Change #1289310 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/ConfirmEdit@master] test: skip failing QUnit test to unblock unrelated changes

https://gerrit.wikimedia.org/r/1289310

gerritbot added a project: Patch-For-Review.Tue, May 19, 11:44 AM
Dreamy_Jazz added a comment.Tue, May 19, 11:45 AM

Probably caused by 8c56ff71826add4460ad6909ce02edc03f80f331

Dreamy_Jazz added a comment.Tue, May 19, 11:46 AM
In T426740#11935800, @gerritbot wrote:

Change #1289310 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/ConfirmEdit@master] test: skip failing QUnit test to unblock unrelated changes

https://gerrit.wikimedia.org/r/1289310

I don't think this will fix it

Dreamy_Jazz claimed this task.Tue, May 19, 11:51 AM

Looks like the new tests in 8c56ff71826add4460ad6909ce02edc03f80f331 were not appropriately skipped if VisualEditor isn't loaded

Dreamy_Jazz moved this task from Backlog to In progress on the Product Safety and Integrity (Sprint lily-of-the-valley (May 4 - May 22)) board.Tue, May 19, 11:51 AM
gerritbot added a comment.Tue, May 19, 11:52 AM

Change #1289321 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/ConfirmEdit@master] hCaptcha: Stub mw.libs.ve in init.test.js to avoid async failure

https://gerrit.wikimedia.org/r/1289321

gerritbot added a comment.Tue, May 19, 11:57 AM

Change #1289322 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/ConfirmEdit@master] Skip init.test.js test if VisualEditor not installed

https://gerrit.wikimedia.org/r/1289322

gerritbot added a comment.Tue, May 19, 11:59 AM

Change #1289321 abandoned by Kosta Harlan:

[mediawiki/extensions/ConfirmEdit@master] hCaptcha: Stub mw.libs.ve in init.test.js to avoid async failure

Reason:

Id563b57819bf46e8f6edd1c83ea8f3d4b5366540 is a better approach

https://gerrit.wikimedia.org/r/1289321

Dreamy_Jazz closed this task as Resolved.Tue, May 19, 12:02 PM
Dreamy_Jazz moved this task from In progress to Done on the Product Safety and Integrity (Sprint lily-of-the-valley (May 4 - May 22)) board.

My patch seems to have fixed it based on https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php83/76790/console:

13:01:05   ext.confirmEdit.hCaptcha.init
13:01:05     ✔ registers VE plugins when VE is available (skipped)
13:01:05     ✔ does not register VE plugins when VE module state is missing
13:01:06   ext.confirmEdit.hCaptcha.secureEnclave
13:01:06     ✔ should not load hCaptcha before the form has been interacted with
13:01:06     ✔ should load hCaptcha exactly once when the form is interacted with [interaction with input element]
13:01:06     ✔ should load hCaptcha exactly once when the form is interacted with [interaction with textarea element]
gerritbot added a comment.Tue, May 19, 12:10 PM

Change #1289322 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] Skip init.test.js test if VisualEditor not installed

https://gerrit.wikimedia.org/r/1289322

Dreamy_Jazz removed a project: Patch-For-Review.Tue, May 19, 12:12 PM
gerritbot added a comment.Tue, May 19, 12:12 PM

Change #1289310 abandoned by Michael Große:

[mediawiki/extensions/ConfirmEdit@master] test: skip failing QUnit test to unblock unrelated changes

Reason:

fixed better by Id563b57819bf46e8f6edd1c83ea8f3d4b5366540

https://gerrit.wikimedia.org/r/1289310

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.4; 2026-05-26).Tue, May 19, 1:00 PM
gerritbot added a comment.Tue, May 19, 1:13 PM

Change #1289347 had a related patch set uploaded (by Michael Große; author: Dreamy Jazz):

[mediawiki/extensions/ConfirmEdit@wmf/1.47.0-wmf.3] Skip init.test.js test if VisualEditor not installed

https://gerrit.wikimedia.org/r/1289347

gerritbot added a project: Patch-For-Review.Tue, May 19, 1:13 PM
gerritbot added a comment.Thu, May 21, 1:41 PM

Change #1289347 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@wmf/1.47.0-wmf.3] Skip init.test.js test if VisualEditor not installed

https://gerrit.wikimedia.org/r/1289347

Stashbot added a comment.Thu, May 21, 1:43 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-21T13:43:45Z] <lucaswerkmeister-wmde@deploy1003> Started scap sync-world: Backport for [[gerrit:1290743|composer.json: Updated symfony/yaml from 7.4.6 to 7.4.12 (T426861)]], [[gerrit:1289347|Skip init.test.js test if VisualEditor not installed (T426740)]], [[gerrit:1289342|fix: simplify to show only one icon type for password reveal (T419413)]]

Stashbot mentioned this in T426861: symfony/yaml security issues blocking vendor.Thu, May 21, 1:43 PM
Stashbot mentioned this in T419413: Add reveal password action to mobile account creation form.

Mentioned in SAL (#wikimedia-operations) [2026-05-21T13:45:28Z] <lucaswerkmeister-wmde@deploy1003> lucaswerkmeister-wmde, migr: Backport for [[gerrit:1290743|composer.json: Updated symfony/yaml from 7.4.6 to 7.4.12 (T426861)]], [[gerrit:1289347|Skip init.test.js test if VisualEditor not installed (T426740)]], [[gerrit:1289342|fix: simplify to show only one icon type for password reveal (T419413)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes

Stashbot added a comment.Thu, May 21, 1:51 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-21T13:51:06Z] <lucaswerkmeister-wmde@deploy1003> Finished scap sync-world: Backport for [[gerrit:1290743|composer.json: Updated symfony/yaml from 7.4.6 to 7.4.12 (T426861)]], [[gerrit:1289347|Skip init.test.js test if VisualEditor not installed (T426740)]], [[gerrit:1289342|fix: simplify to show only one icon type for password reveal (T419413)]] (duration: 07m 20s)

ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.3; 2026-05-19); removed: MW-1.47-notes (1.47.0-wmf.4; 2026-05-26).Thu, May 21, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Thu, May 21, 2:32 PM
• hector.arroyo moved this task from Backlog to Done on the Bot detection and mitigation (WE4.10 hCaptcha) board.Fri, May 22, 3:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits