Page MenuHomePhabricator

Deprecated: Using null as an array offset is deprecated, use an empty string instead
Closed, ResolvedPublic

Description

Deprecated: Using null as an array offset is deprecated, use an empty string instead in /var/www/wiki/mediawiki/extensions/timeline/includes/Timeline.php on line 297

Seemingly $input is null...

	/**
	 * Given a user's input of font, identify the font
	 * directory and font path that should be set
	 *
	 * @param ?string $input
	 * @return array with 'dir', 'file' keys. Note that 'dir' might be false.
	 */
	private static function determineFont( $input ) {
		global $wgTimelineFonts, $wgTimelineFontFile, $wgTimelineFontDirectory;
		// Try the user-specified font, if invalid, use "default"
		$fullPath = $wgTimelineFonts[$input] ?? $wgTimelineFonts['default'] ?? false;

Event Timeline

Reedy moved this task from Backlog to Defects and bugs on the EasyTimeline board.

Change #1288923 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/timeline@master] Timeline: Handle $input being null in determineFont()

https://gerrit.wikimedia.org/r/1288923

Change #1288923 merged by jenkins-bot:

[mediawiki/extensions/timeline@master] Timeline: Stop passing null to determineFont()

https://gerrit.wikimedia.org/r/1288923

Change #1293157 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/timeline@REL1_46] Timeline: Stop passing null to determineFont()

https://gerrit.wikimedia.org/r/1293157

Change #1293158 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/timeline@REL1_45] Timeline: Stop passing null to determineFont()

https://gerrit.wikimedia.org/r/1293158

Change #1293159 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/timeline@REL1_44] Timeline: Stop passing null to determineFont()

https://gerrit.wikimedia.org/r/1293159

Change #1293160 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/timeline@REL1_43] Timeline: Stop passing null to determineFont()

https://gerrit.wikimedia.org/r/1293160

Change #1293158 merged by jenkins-bot:

[mediawiki/extensions/timeline@REL1_45] Timeline: Stop passing null to determineFont()

https://gerrit.wikimedia.org/r/1293158

Change #1293159 merged by jenkins-bot:

[mediawiki/extensions/timeline@REL1_44] Timeline: Stop passing null to determineFont()

https://gerrit.wikimedia.org/r/1293159

Change #1293160 merged by jenkins-bot:

[mediawiki/extensions/timeline@REL1_43] Timeline: Stop passing null to determineFont()

https://gerrit.wikimedia.org/r/1293160

Change #1293157 merged by jenkins-bot:

[mediawiki/extensions/timeline@REL1_46] Timeline: Stop passing null to determineFont()

https://gerrit.wikimedia.org/r/1293157

Reedy claimed this task.