Page MenuHomePhabricator
Create Task
Maniphest T426603

The effect of the VisualEditor "Editing mode" preference on the section edit links is being included in the "post-processing cache" (aka "post-OutputTransform cache") without splitting the cache on the preference
Open, Needs TriagePublic
Actions

Description

https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#c-Anomie-20260517141600-The_Bushranger-20260512222000

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Adjust tests to take into account visibleLinks ParserOption set by VEmediawiki/extensions/FlaggedRevsmaster+7 -4
Replace onParserOptionsRegister by onParserOptionsDefaultsmediawiki/coremaster+55 -2
Make ParserOptions available to Skinmediawiki/coremaster+12 -0
Sets edit link behaviour in ParserOptions in an earlier hookmediawiki/extensions/VisualEditormaster+71 -13
ParserOptions: allow option values to be enumeration valuesmediawiki/coremaster+6 -0
Customize query in gerrit

Event Timeline

matmarex created this task.Mon, May 18, 12:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMon, May 18, 12:05 PM
ihurbain subscribed.Mon, May 18, 2:44 PM

Yup, this is indeed an issue on the postproc cache. Adding section edit links eventually calls onSkinEditSectionLinks, which has a hook in VE to do fancy things depending on user prefs & the last editor used by the user. And the cache has no option for that (... because so far it was very much post cache; and it's not even in the parsing options either), so that's indeed not splitting the cache, good call.

cscott assigned this task to ihurbain.Mon, May 18, 3:27 PM
cscott edited projects, added: Content-Transform-Team (Work In Progress), Essential-Work; removed: Content-Transform-Team.
cscott moved this task from Backlog to In Progress on the Content-Transform-Team (Work In Progress) board.
gerritbot added a comment.Thu, May 21, 1:44 PM

Change #1290772 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/core@master] Add a postproc parseroption for edit link behaviour

https://gerrit.wikimedia.org/r/1290772

gerritbot added a project: Patch-For-Review.Thu, May 21, 1:44 PM
gerritbot added a comment.Thu, May 21, 3:46 PM

Change #1290773 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/VisualEditor@master] Sets edit link behaviour in ParserOptions in an earlier hook

https://gerrit.wikimedia.org/r/1290773

gerritbot added a comment.Thu, May 21, 9:22 PM

Change #1290929 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] ParserOptions: allow option values to be enumeration values

https://gerrit.wikimedia.org/r/1290929

gerritbot added a comment.Fri, May 22, 4:01 PM

Change #1292042 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/FlaggedRevs@master] Adjust tests to take into account visibleLinks ParserOption set by VE

https://gerrit.wikimedia.org/r/1292042

cscott moved this task from In Progress to Code Review on the Content-Transform-Team (Work In Progress) board.Tue, May 26, 2:44 PM
gerritbot added a comment.Thu, May 28, 8:50 AM

Change #1290929 merged by jenkins-bot:

[mediawiki/core@master] ParserOptions: allow option values to be enumeration values

https://gerrit.wikimedia.org/r/1290929

gerritbot added a comment.Thu, May 28, 1:07 PM

Change #1294991 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/core@master] Replace onParserOptionsRegister by onParserOptionsDefaults

https://gerrit.wikimedia.org/r/1294991

gerritbot added a comment.Tue, Jun 2, 12:51 AM

Change #1294991 merged by jenkins-bot:

[mediawiki/core@master] Replace onParserOptionsRegister by onParserOptionsDefaults

https://gerrit.wikimedia.org/r/1294991

gerritbot added a comment.Tue, Jun 2, 12:52 AM

Change #1290772 merged by jenkins-bot:

[mediawiki/core@master] Make ParserOptions available to Skin

https://gerrit.wikimedia.org/r/1290772

gerritbot added a comment.Tue, Jun 2, 12:53 AM

Change #1290773 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Sets edit link behaviour in ParserOptions in an earlier hook

https://gerrit.wikimedia.org/r/1290773

gerritbot added a comment.Tue, Jun 2, 1:17 AM

Change #1292042 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Adjust tests to take into account visibleLinks ParserOption set by VE

https://gerrit.wikimedia.org/r/1292042

Maintenance_bot removed a project: Patch-For-Review.Tue, Jun 2, 1:30 AM
ihurbain moved this task from Code Review to To Verify on the Content-Transform-Team (Work In Progress) board.Mon, Jun 8, 3:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits