Page MenuHomePhabricator
Create Task
Maniphest T426387

Enforce php strict types in extensions stewarded by Product Safety and Integrity (plus ConfirmEdit)
Closed, ResolvedPublic
Actions

Assigned To
MPostoronca-WMF
Authored By
MPostoronca-WMF
Fri, May 15, 9:13 AM
Project Tags
Referenced Files
None
Subscribers
A_smart_kitten
Aklapper
Dreamy_Jazz
MPostoronca-WMF
Novem_Linguae

Description

We should try to use declare(strict_types=1) in all of the PHP files.

This helps prevent implicit type conversion issues.

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects

Event Timeline

MPostoronca-WMF created this task.Fri, May 15, 9:13 AM
Restricted Application added a project: Product Safety and Integrity. · View Herald TranscriptFri, May 15, 9:13 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
MPostoronca-WMF claimed this task.Fri, May 15, 9:14 AM
MPostoronca-WMF edited projects, added: Product Safety and Integrity (Sprint lily-of-the-valley (May 4 - May 22)); removed: Product Safety and Integrity.
MPostoronca-WMF moved this task from Backlog to Needs review on the Product Safety and Integrity (Sprint lily-of-the-valley (May 4 - May 22)) board.
gerritbot added a comment.Fri, May 15, 9:15 AM

Change #1286348 had a related patch set uploaded (by Mpostoronca; author: Mpostoronca):

[mediawiki/extensions/CheckUser@master] Add pre-commit hook enforcing declare(strict_types=1)

https://gerrit.wikimedia.org/r/1286348

gerritbot added a project: Patch-For-Review.Fri, May 15, 9:15 AM
gerritbot added a comment.Fri, May 15, 1:49 PM

Change #1286348 abandoned by Mpostoronca:

[mediawiki/extensions/CheckUser@master] Add pre-commit hook enforcing declare(strict_types=1)

https://gerrit.wikimedia.org/r/1286348

MPostoronca-WMF updated the task description. (Show Details)Fri, May 15, 1:49 PM
gerritbot added a comment.Fri, May 15, 1:53 PM

Change #1287877 had a related patch set uploaded (by Mpostoronca; author: Mpostoronca):

[mediawiki/extensions/ConfirmEdit@master] Add declare(strict_types=1) to all PHP files

https://gerrit.wikimedia.org/r/1287877

MPostoronca-WMF renamed this task from Add git hook for php strict mode to Enforce php strict mode.Fri, May 15, 2:10 PM
gerritbot added a comment.Fri, May 15, 2:16 PM

Change #1287888 had a related patch set uploaded (by Mpostoronca; author: Mpostoronca):

[mediawiki/extensions/ConfirmEdit@master] Add declare(strict_types=1) to all PHP files

https://gerrit.wikimedia.org/r/1287888

gerritbot added a comment.Fri, May 15, 2:57 PM

Change #1287877 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] Add declare(strict_types=1) to all PHP files

https://gerrit.wikimedia.org/r/1287877

gerritbot added a comment.Fri, May 15, 2:58 PM

Change #1287888 abandoned by Dreamy Jazz:

[mediawiki/extensions/ConfirmEdit@master] Add declare(strict_types=1) to all PHP files

Reason:

Duplicate to I7854d9b0df2a4edd25a27065221303336cda8eae from what I can see

https://gerrit.wikimedia.org/r/1287888

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.3; 2026-05-19).Fri, May 15, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Fri, May 15, 3:31 PM
MPostoronca-WMF moved this task from Needs review to Done on the Product Safety and Integrity (Sprint lily-of-the-valley (May 4 - May 22)) board.Mon, May 18, 1:56 PM
OKryva-WMF moved this task from Done to In progress on the Product Safety and Integrity (Sprint lily-of-the-valley (May 4 - May 22)) board.Tue, May 19, 12:05 PM
Dreamy_Jazz added a project: ConfirmEdit (CAPTCHA extension).Tue, May 19, 12:14 PM
gerritbot added a comment.Tue, May 19, 1:39 PM

Change #1289350 had a related patch set uploaded (by Mpostoronca; author: Mpostoronca):

[mediawiki/extensions/CheckUser@master] Add declare(strict_types=1) to all PHP files

https://gerrit.wikimedia.org/r/1289350

gerritbot added a project: Patch-For-Review.Tue, May 19, 1:39 PM
MPostoronca-WMF moved this task from In progress to Needs review on the Product Safety and Integrity (Sprint lily-of-the-valley (May 4 - May 22)) board.Wed, May 20, 7:40 AM
gerritbot added a comment.Wed, May 20, 2:56 PM

Change #1289350 had a related patch set uploaded (by Mpostoronca; author: Mpostoronca):

[mediawiki/extensions/CheckUser@master] Add declare(strict_types=1) to all PHP files

https://gerrit.wikimedia.org/r/1289350

gerritbot added a comment.Wed, May 20, 4:33 PM

Change #1289350 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add declare(strict_types=1) to all PHP files

https://gerrit.wikimedia.org/r/1289350

MPostoronca-WMF moved this task from Needs review to In progress on the Product Safety and Integrity (Sprint lily-of-the-valley (May 4 - May 22)) board.Thu, May 21, 11:12 AM
gerritbot added a comment.Thu, May 21, 2:26 PM

Change #1290789 had a related patch set uploaded (by Mpostoronca; author: Mpostoronca):

[mediawiki/extensions/AntiSpoof@master] Add declare(strict_types=1) to all PHP files

https://gerrit.wikimedia.org/r/1290789

gerritbot added a comment.Thu, May 21, 2:31 PM

Change #1290790 had a related patch set uploaded (by Mpostoronca; author: Mpostoronca):

[mediawiki/extensions/EmailAuth@master] Add declare(strict_types=1) to all PHP files

https://gerrit.wikimedia.org/r/1290790

gerritbot added a comment.Thu, May 21, 2:35 PM

Change #1290791 had a related patch set uploaded (by Mpostoronca; author: Mpostoronca):

[mediawiki/extensions/LoginNotify@master] Add declare(strict_types=1) to all PHP files

https://gerrit.wikimedia.org/r/1290791

gerritbot added a comment.Thu, May 21, 2:37 PM

Change #1290792 had a related patch set uploaded (by Mpostoronca; author: Mpostoronca):

[mediawiki/extensions/IPReputation@master] Add declare(strict_types=1) to all PHP files

https://gerrit.wikimedia.org/r/1290792

gerritbot added a comment.Thu, May 21, 2:40 PM

Change #1290796 had a related patch set uploaded (by Mpostoronca; author: Mpostoronca):

[mediawiki/extensions/ReportIncident@master] Add declare(strict_types=1) to all PHP files

https://gerrit.wikimedia.org/r/1290796

gerritbot added a comment.Thu, May 21, 2:43 PM

Change #1290801 had a related patch set uploaded (by Mpostoronca; author: Mpostoronca):

[mediawiki/extensions/GlobalBlocking@master] Add declare(strict_types=1) to all PHP files

https://gerrit.wikimedia.org/r/1290801

gerritbot added a comment.Thu, May 21, 2:46 PM

Change #1290802 had a related patch set uploaded (by Mpostoronca; author: Mpostoronca):

[mediawiki/extensions/MediaModeration@master] Add declare(strict_types=1) to all PHP files

https://gerrit.wikimedia.org/r/1290802

gerritbot added a comment.Thu, May 21, 2:49 PM

Change #1290804 had a related patch set uploaded (by Mpostoronca; author: Mpostoronca):

[mediawiki/extensions/SecurePoll@master] Add declare(strict_types=1) to all PHP files

https://gerrit.wikimedia.org/r/1290804

gerritbot added a comment.Thu, May 21, 2:58 PM

Change #1290809 had a related patch set uploaded (by Mpostoronca; author: Mpostoronca):

[mediawiki/extensions/IPInfo@master] Add declare(strict_types=1) to all PHP files

https://gerrit.wikimedia.org/r/1290809

gerritbot added a comment.Thu, May 21, 3:00 PM

Change #1290812 had a related patch set uploaded (by Mpostoronca; author: Mpostoronca):

[mediawiki/extensions/OATHAuth@master] Add declare(strict_types=1) to all PHP files

https://gerrit.wikimedia.org/r/1290812

Dreamy_Jazz added projects: AntiSpoof, MediaWiki-extensions-SecurePoll, MediaWiki-extensions-OATHAuth, MediaModeration, GlobalBlocking, MediaWiki-extensions-IPReputation, MediaWiki-extensions-EmailAuth, MediaWiki-extensions-LoginNotify.Thu, May 21, 3:43 PM
gerritbot added a comment.Thu, May 21, 3:57 PM

Change #1290802 merged by jenkins-bot:

[mediawiki/extensions/MediaModeration@master] Add declare(strict_types=1) to all PHP files

https://gerrit.wikimedia.org/r/1290802

ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.4; 2026-05-26); removed: MW-1.47-notes (1.47.0-wmf.3; 2026-05-19).Thu, May 21, 4:00 PM
Pppery renamed this task from Enforce php strict mode to Enforce php strict types.Thu, May 21, 5:20 PM
gerritbot added a comment.Thu, May 21, 5:31 PM

Change #1290801 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Add declare(strict_types=1) to all PHP files

https://gerrit.wikimedia.org/r/1290801

gerritbot added a comment.Fri, May 22, 10:28 AM

Change #1290790 merged by jenkins-bot:

[mediawiki/extensions/EmailAuth@master] Add declare(strict_types=1) to all PHP files

https://gerrit.wikimedia.org/r/1290790

MPostoronca-WMF mentioned this in rEEMA8ec0937f9d42: Add declare(strict_types=1) to all PHP files.Fri, May 22, 10:30 AM
gerritbot added a comment.Fri, May 22, 10:31 AM

Change #1290812 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] Add declare(strict_types=1) to all PHP files

https://gerrit.wikimedia.org/r/1290812

gerritbot added a comment.Fri, May 22, 10:35 AM

Change #1290791 merged by jenkins-bot:

[mediawiki/extensions/LoginNotify@master] Add declare(strict_types=1) to all PHP files

https://gerrit.wikimedia.org/r/1290791

gerritbot added a comment.Fri, May 22, 10:41 AM

Change #1290789 merged by jenkins-bot:

[mediawiki/extensions/AntiSpoof@master] Add declare(strict_types=1) to all PHP files

https://gerrit.wikimedia.org/r/1290789

gerritbot added a comment.Fri, May 22, 10:41 AM

Change #1290792 merged by jenkins-bot:

[mediawiki/extensions/IPReputation@master] Add declare(strict_types=1) to all PHP files

https://gerrit.wikimedia.org/r/1290792

MPostoronca-WMF mentioned this in rEIPRbf5ab7921fa0: Add declare(strict_types=1) to all PHP files.Fri, May 22, 10:44 AM
gerritbot added a comment.Fri, May 22, 10:54 AM

Change #1290796 merged by jenkins-bot:

[mediawiki/extensions/ReportIncident@master] Add declare(strict_types=1) to all PHP files

https://gerrit.wikimedia.org/r/1290796

MPostoronca-WMF mentioned this in rEREI32c463f3b63e: Add declare(strict_types=1) to all PHP files.Fri, May 22, 10:55 AM
OKryva-WMF edited projects, added: Product Safety and Integrity (Sprint Iris (May 25 - Jun 12)); removed: Product Safety and Integrity (Sprint lily-of-the-valley (May 4 - May 22)).Mon, May 25, 12:41 PM
OKryva-WMF moved this task from Backlog to In progress on the Product Safety and Integrity (Sprint Iris (May 25 - Jun 12)) board.Mon, May 25, 12:42 PM
gerritbot added a comment.Wed, May 27, 9:25 AM

Change #1290809 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Add declare(strict_types=1) to all PHP files

https://gerrit.wikimedia.org/r/1290809

MPostoronca-WMF moved this task from In progress to Needs review on the Product Safety and Integrity (Sprint Iris (May 25 - Jun 12)) board.Wed, May 27, 10:53 AM
Reedy moved this task from Backlog to External on the MediaWiki-extensions-OATHAuth board.Wed, May 27, 4:15 PM
Dreamy_Jazz mentioned this in T427480: CheckUserLookupUtils: ArchivedRevisionLookup::getArchivedRevisionRecord(): Argument #2 ($revId) must be of type int, string given.Thu, May 28, 8:49 AM
Dreamy_Jazz mentioned this in T427505: TypeError: Wikimedia\Mime\MimeAnalyzer::getMimeTypeFromExtensionOrNull(): Argument #1 ($ext) must be of type string, false given, called in /srv/mediawiki/php-1.47.0-wmf.4/extensions/MediaModeration/src/Services/MediaModeration.Thu, May 28, 12:30 PM
kostajh mentioned this in T427625: TypeError: MediaWiki\Extension\CheckUser\Logging\TemporaryAccountLogger::logAutoRevealAccessEnabled(): Argument #2 ($expiry) must be of type int, string given, called in /srv/mediawiki/php-1.47.0-wmf.4/extensions/CheckUser/src/.Fri, May 29, 1:13 PM
A_smart_kitten subscribed.Fri, May 29, 3:25 PM

(Just to clarify, is the scope of this task Product Safety and Integrity -stewarded extensions? Just asking as the tags currently present on this task seem to be PSI-stewarded exts AFAICS, w/ the exception of ConfirmEdit (CAPTCHA extension) [which is apparently stewarded by the Editing-team?])

Dreamy_Jazz subscribed.Fri, May 29, 3:47 PM

This is intended for extensions we steward, but as we are working on hCaptcha we have touched most of ConfirmEdit (CAPTCHA extension) code and so thought we'd include it

A_smart_kitten renamed this task from Enforce php strict types to Enforce php strict types in extensions stewarded by Product Safety and Integrity (plus ConfirmEdit).Fri, May 29, 3:54 PM

Acknowledged :) Retitled for clarity. Feel free to adjust if desired

Dreamy_Jazz closed this task as Resolved.Thu, Jun 4, 12:20 PM
Dreamy_Jazz moved this task from Needs review to Done on the Product Safety and Integrity (Sprint Iris (May 25 - Jun 12)) board.
gerritbot added a comment.Thu, Jun 4, 1:01 PM

Change #1290804 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Add declare(strict_types=1) to all PHP files

https://gerrit.wikimedia.org/r/1290804

SD0001 mentioned this in T428368: Creation of polls is broken.Sun, Jun 7, 6:26 PM
Novem_Linguae subscribed.Thu, Jun 11, 9:55 PM

If you're thinking about adding strict_types to anything else, I would recommend against it. This ticket caused 4 production errors in SecurePoll. Not sure that's worth whatever benefit strict_types provides.

https://gerrit.wikimedia.org/r/q/is:merged+strict+repo:mediawiki/extensions/SecurePoll

It also added some non-standard phpcs rules to the phpcs config.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits