Page MenuHomePhabricator
Create Task
Maniphest T425948

🧹️ Stop using TypeDispatchingEntitySearchHelper in the searchEntities maintenance script
Closed, ResolvedPublic
Actions

Description

Ask around if anyone uses this. Remove if not, use a controller otherwise.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Search: Remove searchEntities maintenance scriptmediawiki/extensions/Wikibasemaster+0 -167
Avoid generic search helper in searchEntitiesmediawiki/extensions/Wikibasemaster+7 -1
Search: Use ItemSearchHelper and PropertySearchHelper in searchEntities maintenance scriptmediawiki/extensions/Wikibasemaster+6 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Silvan_WMDE created this task.May 11 2026, 1:36 PM
Mona_WMDE claimed this task.Thu, May 21, 12:44 PM
Mona_WMDE moved this task from To Do to Doing on the Wikibase Reuse Team (Sprint 69) board.
Jakob_WMDE subscribed.Thu, May 21, 2:04 PM

I suspect that the searchEntities maintenance script is mainly used for items and properties, if at all. If we don't want to remove it completely, we could just stop depending on the generic WikibaseRepo::getEntitySearchHelper that works for all entity types and instead use WbSearch::getItemSearchHelper and WbSearch::getPropertySearchHelper for items and properties respectively. That would of course break support for other entity types, but that's probably no big deal.

Jakob_WMDE moved this task from Sprint 69 to Sprint 70 on the Wikibase Reuse Team board.Wed, May 27, 9:52 AM
Jakob_WMDE edited projects, added: Wikibase Reuse Team (Sprint 70); removed: Wikibase Reuse Team (Sprint 69).
Jakob_WMDE moved this task from To Do to Doing on the Wikibase Reuse Team (Sprint 70) board.
gerritbot added a comment.Wed, May 27, 2:48 PM

Change #1294311 had a related patch set uploaded (by Mona_WMDE; author: Mona_WMDE):

[mediawiki/extensions/Wikibase@master] Search: Use ItemSearchHelper and PropertySearchHelper in searchEntities maintenance script

https://gerrit.wikimedia.org/r/1294311

gerritbot added a project: Patch-For-Review.Wed, May 27, 2:48 PM
gerritbot added a comment.Wed, May 27, 3:32 PM

Change #1293733 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Avoid generic search helper in searchEntities

https://gerrit.wikimedia.org/r/1293733

gerritbot added a comment.Wed, May 27, 3:34 PM

Change #1294311 abandoned by Mona_WMDE:

[mediawiki/extensions/Wikibase@master] Search: Use ItemSearchHelper and PropertySearchHelper in searchEntities maintenance script

Reason:

duplicate patch

https://gerrit.wikimedia.org/r/1294311

Mona_WMDE moved this task from Doing to Peer Review on the Wikibase Reuse Team (Sprint 70) board.Wed, May 27, 3:35 PM
gerritbot added a comment.Thu, May 28, 1:32 PM

Change #1293733 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Avoid generic search helper in searchEntities

https://gerrit.wikimedia.org/r/1293733

Maintenance_bot removed a project: Patch-For-Review.Thu, May 28, 2:31 PM
Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Reuse Team (Sprint 70) board.Fri, May 29, 8:24 AM
gerritbot added a comment.Mon, Jun 1, 10:27 AM

Change #1295867 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] Search: Remove searchEntities maintenance script

https://gerrit.wikimedia.org/r/1295867

gerritbot added a project: Patch-For-Review.Mon, Jun 1, 10:27 AM
gerritbot added a comment.Mon, Jun 1, 10:46 AM

Change #1295867 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Search: Remove searchEntities maintenance script

https://gerrit.wikimedia.org/r/1295867

Maintenance_bot removed a project: Patch-For-Review.Mon, Jun 1, 11:31 AM
Ifrahkhanyaree_WMDE closed this task as Resolved.Thu, Jun 11, 10:45 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits