ArticleGuidance: TypeError: str_contains(): Argument #1 ($haystack) must be of type string, null given
Closed, ResolvedPublic1 Estimated Story PointsPRODUCTION ERROR
Actions

Description

Error

service.version: 1.47.0-wmf.1
timestamp: 2026-05-07T20:33:40.616Z
labels.phpversion: 8.3.30
trace.id: 6e2a7f41-6911-4752-9434-0b5033030afd
Find trace.id in Logstash

labels.normalized_message

[{reqId}] {exception_url}   TypeError: str_contains(): Argument #1 ($haystack) must be of type string, null given

Frame	Location	Call
from	/srv/mediawiki/php-1.47.0-wmf.1/extensions/ArticleGuidance/src/Hooks/PreloadCleanupHandler.php(18)
#0	/srv/mediawiki/php-1.47.0-wmf.1/extensions/ArticleGuidance/src/Hooks/PreloadCleanupHandler.php(18)	str_contains(null, string)
#1	/srv/mediawiki/php-1.47.0-wmf.1/includes/HookContainer/HookContainer.php(127)	MediaWiki\Extension\ArticleGuidance\Hooks\PreloadCleanupHandler->onEditFormPreloadText(null, MediaWiki\Title\Title)
#2	/srv/mediawiki/php-1.47.0-wmf.1/includes/Api/ApiHookRunner.php(359)	MediaWiki\HookContainer\HookContainer->run(string, array)
#3	/srv/mediawiki/php-1.47.0-wmf.1/includes/Api/ApiQueryInfo.php(447)	MediaWiki\Api\ApiHookRunner->onEditFormPreloadText(null, MediaWiki\Title\Title)
#4	/srv/mediawiki/php-1.47.0-wmf.1/includes/Api/ApiQueryInfo.php(304)	MediaWiki\Api\ApiQueryInfo->extractPageInfo(int, MediaWiki\Title\Title)
#5	/srv/mediawiki/php-1.47.0-wmf.1/includes/Api/ApiQuery.php(735)	MediaWiki\Api\ApiQueryInfo->execute()
#6	/srv/mediawiki/php-1.47.0-wmf.1/includes/Api/ApiMain.php(2045)	MediaWiki\Api\ApiQuery->execute()
#7	/srv/mediawiki/php-1.47.0-wmf.1/includes/Api/ApiMain.php(949)	MediaWiki\Api\ApiMain->executeAction()
#8	/srv/mediawiki/php-1.47.0-wmf.1/includes/Api/ApiMain.php(920)	MediaWiki\Api\ApiMain->executeActionWithErrorHandling()
#9	/srv/mediawiki/php-1.47.0-wmf.1/includes/Api/ApiEntryPoint.php(138)	MediaWiki\Api\ApiMain->execute()
#10	/srv/mediawiki/php-1.47.0-wmf.1/includes/MediaWikiEntryPoint.php(180)	MediaWiki\Api\ApiEntryPoint->execute()
#11	/srv/mediawiki/php-1.47.0-wmf.1/api.php(30)	MediaWiki\MediaWikiEntryPoint->run()
#12	/srv/mediawiki/w/api.php(3)	require(string)
#13	{main}

Notes

Saw burst of 381 of of these for simplewiki, in the recently-deployed 1.47.0-wmf.1 (T423910).

Details

Request URL: https://simple.wikipedia.org/w/api.php?action=query&format=*&inprop=*&prop=*&redirects=*&titles=*

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
ApiQueryInfo: Pass an empty string instead of null to EditFormPreloadText hook	mediawiki/core	REL1_45	+1 -2
ApiQueryInfo: Pass an empty string instead of null to EditFormPreloadText hook	mediawiki/core	REL1_43	+1 -2
ApiQueryInfo: Pass an empty string instead of null to EditFormPreloadText hook	mediawiki/core	REL1_46	+1 -2
ApiQueryInfo: Pass an empty string instead of null to EditFormPreloadText hook	mediawiki/core	REL1_44	+1 -2
ApiQueryInfo: Pass an empty string instead of null to EditFormPreloadText hook	mediawiki/core	master	+1 -2

Customize query in gerrit

Related Objects

Mentioned Here: T423910: 1.47.0-wmf.1 deployment blockers

Event Timeline

brennen created this task.May 7 2026, 8:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 7 2026, 8:53 PM

SomeRandomDeveloper subscribed.May 7 2026, 11:40 PM

Introduced by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ArticleGuidance/+/1280505.

Interestingly, onEditFormPreloadText is documented to take a non-null $text parameter, but ApiQueryInfo passes null to it. According to git blame, this has been the case for a long time. It seems like core is wrong here.

Change #1284946 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/core@master] ApiQueryInfo: Pass an empty string instead of null to EditFormPreloadText hook

https://gerrit.wikimedia.org/r/1284946

gerritbot added a project: Patch-For-Review.May 8 2026, 12:11 AM

SomeRandomDeveloper claimed this task.May 8 2026, 12:12 AM

SomeRandomDeveloper added a project: MediaWiki-Action-API.

Maintenance_bot added a project: MW-Interfaces-Team.May 8 2026, 12:30 AM

Change #1284946 merged by jenkins-bot:

[mediawiki/core@master] ApiQueryInfo: Pass an empty string instead of null to EditFormPreloadText hook

https://gerrit.wikimedia.org/r/1284946

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.2; 2026-05-12).May 8 2026, 4:00 PM

Change #1285408 had a related patch set uploaded (by Reedy; author: SomeRandomDeveloper):

[mediawiki/core@REL1_46] ApiQueryInfo: Pass an empty string instead of null to EditFormPreloadText hook

https://gerrit.wikimedia.org/r/1285408

Change #1285409 had a related patch set uploaded (by Reedy; author: SomeRandomDeveloper):

[mediawiki/core@REL1_45] ApiQueryInfo: Pass an empty string instead of null to EditFormPreloadText hook

https://gerrit.wikimedia.org/r/1285409

Change #1285410 had a related patch set uploaded (by Reedy; author: SomeRandomDeveloper):

[mediawiki/core@REL1_44] ApiQueryInfo: Pass an empty string instead of null to EditFormPreloadText hook

https://gerrit.wikimedia.org/r/1285410

Change #1285411 had a related patch set uploaded (by Reedy; author: SomeRandomDeveloper):

[mediawiki/core@REL1_43] ApiQueryInfo: Pass an empty string instead of null to EditFormPreloadText hook

https://gerrit.wikimedia.org/r/1285411

Change #1285410 merged by jenkins-bot:

[mediawiki/core@REL1_44] ApiQueryInfo: Pass an empty string instead of null to EditFormPreloadText hook

https://gerrit.wikimedia.org/r/1285410

Change #1285411 merged by jenkins-bot:

[mediawiki/core@REL1_43] ApiQueryInfo: Pass an empty string instead of null to EditFormPreloadText hook

https://gerrit.wikimedia.org/r/1285411

Change #1285408 merged by jenkins-bot:

[mediawiki/core@REL1_46] ApiQueryInfo: Pass an empty string instead of null to EditFormPreloadText hook

https://gerrit.wikimedia.org/r/1285408

Change #1285409 merged by jenkins-bot:

[mediawiki/core@REL1_45] ApiQueryInfo: Pass an empty string instead of null to EditFormPreloadText hook

https://gerrit.wikimedia.org/r/1285409

ReleaseTaggerBot added projects: MW-1.45-notes, MW-1.43-notes, MW-1.44-notes, MW-1.46-notes.May 8 2026, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 8 2026, 5:31 PM

BPirkle edited projects, added: Language and Product Localization; removed: MW-Interfaces-Team.May 8 2026, 9:48 PM

Do we want to backport this (I could schedule it for the UTC late backport window today), or is the error rate low enough that it's not necessary and we can wait until it rolls out through the train?

thcipriani moved this task from Untriaged to Apr–Jun 2026 on the Wikimedia-production-error board.Thu, May 14, 3:38 PM

GGalofre-WMF moved this task from Backlog to Pre-Editor workflow on the Article-Guidance board.Mon, May 18, 8:12 AM

The fix should've been deployed through the train last week, are there still any errors?

SomeRandomDeveloper moved this task from Backlog to Waiting on the User-SomeRandomDeveloper board.Wed, May 20, 11:42 PM

Nikerabbit edited projects, added: LPL Essential (FY2025-26 Q3&4); removed: Language and Product Localization.Thu, May 21, 8:55 AM

Nikerabbit edited projects, added: LPL Hypothesis; removed: LPL Essential (FY2025-26 Q3&4).Thu, May 21, 9:02 AM

Not seen after 1.47.0-wmf.1 Thanks for fixing!

ArticleGuidance: TypeError: str_contains(): Argument #1 ($haystack) must be of type string, null givenClosed, ResolvedPublic1 Estimated Story PointsPRODUCTION ERRORActions