Deprecate Skin::mapInterwikiToLanguage
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson-WMF
	May 7 2026, 3:41 AM

Project Tags

Referenced Files

None

Subscribers

Aklapper

HakanIST

Jdlrobson-WMF

Description

According to https://codesearch.wmcloud.org/search/?q=mapInterwikiToLanguage&files=&excludeFiles=&repos= the public Skin::mapInterwikiToLanguage is used only by SkinLanguageHelper. Let's therefore move it to SkinLanguageHelper and deprecate it. This will help us with our overall goal of simplifying Skin code so that it's only responsibility is rendering the HTML of the page!

TODO

copy/paste mapInterwikiToLanguage from Skin.php into SkinLanguageHelper.php. Don't worry about the Skin method for now.
update the constructor for SkinLanguageHelper.php so that it doesn't take Skin
add wfDeprecated call to Skin::mapInterwikiToLanguage (which should now be unused
note its deprecation in RELEASE-NOTES-1.47

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Skin: Deprecate mapInterwikiToLanguage	mediawiki/core	master	+5 -0
	SkinLanguageHelper: Replace Skin parameter with explicit dependencies	mediawiki/core	master	+65 -38

Customize query in gerrit

Event Timeline

Jdlrobson-WMF created this task.May 7 2026, 3:41 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 7 2026, 3:41 AM

Jdlrobson-WMF triaged this task as Medium priority.May 7 2026, 3:41 AM

HakanIST claimed this task.May 7 2026, 4:05 AM

Change #1284171 had a related patch set uploaded (by HakanIST; author: HakanIST):

[mediawiki/core@master] SkinLanguageHelper: Remove Skin dependency, use explicit DI

https://gerrit.wikimedia.org/r/1284171

gerritbot added a project: Patch-For-Review.May 7 2026, 4:20 AM

Change #1284185 had a related patch set uploaded (by HakanIST; author: HakanIST):

[mediawiki/core@master] Skin: Deprecate mapInterwikiToLanguage

https://gerrit.wikimedia.org/r/1284185

Change #1284171 merged by jenkins-bot:

[mediawiki/core@master] SkinLanguageHelper: Replace Skin parameter with explicit dependencies

https://gerrit.wikimedia.org/r/1284171

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.2; 2026-05-12).May 7 2026, 5:00 PM

Jdlrobson-WMF closed this task as Resolved.May 7 2026, 9:09 PM

Jdlrobson-WMF updated the task description. (Show Details)

Change #1284185 merged by jenkins-bot: