Page MenuHomePhabricator
Create Task
Maniphest T425513

🧄 Stop using FallbackEntitySearchHelperController for items
Closed, ResolvedPublic
Actions

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove EntitySearchHelperFactory::newItemPropertySearchHelpermediawiki/extensions/WikibaseCirrusSearchmaster+2 -6
Search: Stop using FallbackEntitySearchHelperController for itemsmediawiki/extensions/Wikibasemaster+10 -31
Search: Move WBCS enabled check to factory wiringmediawiki/extensions/Wikibasemaster+10 -23
Search: Introduce EntitySearchHelperFactory interfacemediawiki/extensions/Wikibasemaster+72 -53
Implement EntitySearchHelperFactory interfacemediawiki/extensions/WikibaseCirrusSearchmaster+6 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jakob_WMDE created this task.May 6 2026, 8:06 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 6 2026, 8:06 AM
Jakob_WMDE moved this task from To Do to Doing on the Wikibase Reuse Team (Sprint 68) board.May 6 2026, 8:06 AM
gerritbot added a comment.May 6 2026, 2:36 PM

Change #1283800 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Search: Introduce EntitySearchHelperFactory interface

https://gerrit.wikimedia.org/r/1283800

gerritbot added a project: Patch-For-Review.May 6 2026, 2:36 PM
gerritbot added a comment.May 6 2026, 3:03 PM

Change #1283807 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/WikibaseCirrusSearch@master] Search: Implement EntitySearchHelperFactory interface

https://gerrit.wikimedia.org/r/1283807

gerritbot added a comment.May 6 2026, 3:11 PM

Change #1283811 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/WikibaseCirrusSearch@master] Remove EntitySearchHelperFactory::newItemPropertySearchHelper

https://gerrit.wikimedia.org/r/1283811

gerritbot added a comment.May 6 2026, 3:13 PM

Change #1283812 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Search: Move WBCS enabled check to factory wiring

https://gerrit.wikimedia.org/r/1283812

gerritbot added a comment.May 7 2026, 7:47 AM

Change #1284448 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Search: Stop using FallbackEntitySearchHelperController for items

https://gerrit.wikimedia.org/r/1284448

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Reuse Team (Sprint 68) board.May 7 2026, 8:07 AM
gerritbot added a comment.May 7 2026, 3:38 PM

Change #1283800 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Search: Introduce EntitySearchHelperFactory interface

https://gerrit.wikimedia.org/r/1283800

gerritbot added a comment.May 7 2026, 3:38 PM

Change #1283807 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Implement EntitySearchHelperFactory interface

https://gerrit.wikimedia.org/r/1283807

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.2; 2026-05-12).May 7 2026, 4:00 PM
gerritbot added a comment.May 7 2026, 4:10 PM

Change #1283812 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Search: Move WBCS enabled check to factory wiring

https://gerrit.wikimedia.org/r/1283812

gerritbot added a comment.May 8 2026, 5:37 AM

Change #1284448 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Search: Stop using FallbackEntitySearchHelperController for items

https://gerrit.wikimedia.org/r/1284448

gerritbot added a comment.May 8 2026, 5:38 AM

Change #1283811 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Remove EntitySearchHelperFactory::newItemPropertySearchHelper

https://gerrit.wikimedia.org/r/1283811

Maintenance_bot removed a project: Patch-For-Review.May 8 2026, 6:30 AM
Silvan_WMDE moved this task from Peer Review to Done on the Wikibase Reuse Team (Sprint 68) board.May 8 2026, 6:55 AM
Ifrahkhanyaree_WMDE closed this task as Resolved.Fri, May 15, 2:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits