Page MenuHomePhabricator
Create Task
Maniphest T425450

Donor badge experiment: Bug bash
Open, HighPublic
Actions

Description

Background

A structured bug bash across all non-control variants on real devices before the experiment reaches traffic.

Goal

All critical bugs found and fixed before full traffic ramp-up. All others documented.

Requirements

  • Bug bash covers all variants (A/B/C) on at minimum: Chrome Android (mid-range device), Safari iOS (current and one previous major version).
  • Accessibility requirements clarified. Dependently tested.
  • Edge cases to test: donor who taps badge repeatedly in rapid succession (animation queuing), slow network conditions.

Identified issues

  1. T427407: Search icon appears on the left on mobile while logged out on certain wikis
  2. With current code in WikimediaCustomizations only the CSS class fragment (prefix) wikimedia-donor-badge- is in the output. No control, no treatment group class.

Acceptance Criteria for Done

  • Bug bash completed across all 3 variants on defined device/browsers above.
  • All critical and high bugs resolved and verified fixed.
  • Edge cases tested and outcomes documented.
  • Remaining known issues logged with severity and owner before closing.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
styles, build: Show badge container exclusively on experiment in treatmentmediawiki/extensions/WikimediaCustomizationsmaster+98 -73
styles: Hide donor badge container by defaultmediawiki/skins/MinervaNeuewmf/1.47.0-wmf.4+2 -2
styles: Hide donor badge container by defaultmediawiki/skins/MinervaNeuemaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Volker_E created this task.May 5 2026, 4:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 5 2026, 4:54 PM
Volker_E added a project: FY25-26 WE3.5 Donor Identification and recognition.May 6 2026, 3:23 AM
Volker_E updated the task description. (Show Details)
Volker_E added a parent task: T424069: [EPIC] WE 3.5.5 Donor badge experiment.
Jdrewniak moved this task from Backlog to WE3.5.5 Offer logged-out donors persistent Thank You badge on the FY25-26 WE3.5 Donor Identification and recognition board.May 7 2026, 4:37 PM
HFan-WMF triaged this task as High priority.May 7 2026, 5:49 PM
HFan-WMF moved this task from Incoming to Needs refinement on the Reader Experience Team board.
Volker_E added a project: WikimediaCustomizations.Fri, May 29, 6:48 PM
Volker_E updated the task description. (Show Details)
gerritbot added a comment.Fri, May 29, 6:59 PM

Change #1295498 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/MinervaNeue@master] styles: Hide donor badge when not in experiment

https://gerrit.wikimedia.org/r/1295498

gerritbot added a project: Patch-For-Review.Fri, May 29, 6:59 PM
gerritbot added a comment.Mon, Jun 1, 1:30 PM

Change #1295920 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/WikimediaCustomizations@master] styles: Show badge container only on experiment

https://gerrit.wikimedia.org/r/1295920

Volker_E added a subtask: T427407: Search icon appears on the left on mobile while logged out on certain wikis.Mon, Jun 1, 4:09 PM
Volker_E updated the task description. (Show Details)Mon, Jun 1, 4:38 PM
gerritbot added a comment.Mon, Jun 1, 6:16 PM

Change #1295990 had a related patch set uploaded (by Jdlrobson; author: VolkerE):

[mediawiki/skins/MinervaNeue@wmf/1.47.0-wmf.4] styles: Hide donor badge container by default

https://gerrit.wikimedia.org/r/1295990

gerritbot added a comment.Mon, Jun 1, 6:18 PM

Change #1295491 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/WikimediaCustomizations@master] WIP: Stop adding donor delight badge module to page

https://gerrit.wikimedia.org/r/1295491

gerritbot added a comment.Mon, Jun 1, 6:30 PM

Change #1295498 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] styles: Hide donor badge container by default

https://gerrit.wikimedia.org/r/1295498

Volker_E added a subtask: T427850: TypeError: Cannot read properties of undefined (reading 'set').Mon, Jun 1, 9:42 PM
gerritbot added a comment.Mon, Jun 1, 11:19 PM

Change #1295990 abandoned by Jdlrobson:

[mediawiki/skins/MinervaNeue@wmf/1.47.0-wmf.4] styles: Hide donor badge container by default

Reason:

I decided not to backport this.

https://gerrit.wikimedia.org/r/1295990

Volker_E updated the task description. (Show Details)Tue, Jun 2, 6:40 AM
Volker_E created subtask T427933: Donor badge experiment: UI polishing - donor badge icon.Tue, Jun 2, 3:07 PM
Jdlrobson-WMF closed subtask T427850: TypeError: Cannot read properties of undefined (reading 'set') as Resolved.Tue, Jun 2, 3:35 PM
Volker_E created subtask T427956: Donor badge experiment: Prefix remaining CSS classes.Tue, Jun 2, 4:26 PM
Jdlrobson-WMF subscribed.Tue, Jun 2, 5:09 PM

In treatment-simple the popup appears on every page load. I think it should only show on the first display? Can you please fix? This seems like it would break the A/B test as people would be motivated to click hide. Is that in scope for this ticket?

$.cookie( 'centralnotice_hide_fundraising', '{"v":1,"created":1779379520,"reason":"donate"}', { path: '/' } );
mw.testKitchen.overrideExperimentGroup('donor-delight-badge', 'treatment-b-simple');
Jdlrobson-WMF mentioned this in T425459: Donor badge experiment: Setup donor badge.Tue, Jun 2, 5:09 PM
Volker_E created subtask T427965: Donor badge experiment: Remove cache polluting class.Tue, Jun 2, 5:40 PM
gerritbot added a comment.Wed, Jun 3, 11:08 PM

Change #1295920 had a related patch set uploaded (by Jdlrobson; author: VolkerE):

[mediawiki/extensions/WikimediaCustomizations@master] styles, build: Show badge container exclusively on experiment in treatment

https://gerrit.wikimedia.org/r/1295920

gerritbot added a comment.Wed, Jun 3, 11:17 PM

Change #1295491 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/WikimediaCustomizations@master] Stop adding donor delight badge module to page

https://gerrit.wikimedia.org/r/1295491

gerritbot added a comment.Fri, Jun 5, 3:51 PM

Change #1295920 abandoned by Jdlrobson:

[mediawiki/extensions/WikimediaCustomizations@master] styles, build: Show badge container exclusively on experiment in treatment

Reason:

Done in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaCustomizations/+/1298302 instead

https://gerrit.wikimedia.org/r/1295920

Volker_E added a subtask: T428277: Show badge on tablet/desktop devices if in treatment.Fri, Jun 5, 4:52 PM
Volker_E removed a project: Patch-For-Review.Mon, Jun 8, 4:23 PM
Jdlrobson-WMF closed subtask T427407: Search icon appears on the left on mobile while logged out on certain wikis as Resolved.Mon, Jun 8, 10:37 PM
Jdlrobson-WMF closed subtask T427933: Donor badge experiment: UI polishing - donor badge icon as Resolved.Thu, Jun 11, 3:29 PM
Jdlrobson-WMF closed subtask T428277: Show badge on tablet/desktop devices if in treatment as Resolved.Thu, Jun 11, 6:30 PM
Volker_E closed subtask T427965: Donor badge experiment: Remove cache polluting class as Resolved.Thu, Jun 11, 6:41 PM
Jdlrobson-WMF closed subtask T427956: Donor badge experiment: Prefix remaining CSS classes as Resolved.Thu, Jun 11, 8:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits