Page MenuHomePhabricator
Create Task
Maniphest T425358

Share Highlight: dark background and invisible text on Firefox
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:

The quote card's background color is dark, and the text is illegible.

ShareHighlight bug dark background Firefox.jpg (828×1,682 px, 61 KB)

What should have happened instead?:

The quote card with an image has a dominant-color-hex background color. The text is legible and has a dominant-color-contrasting color.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

  • Verified on Firefox browser on an iOS device with light/dark appearance settings.
  • Verified Minerva theme settings are unrelated. Switching Minerva light/dark theme does not affect the card element's background color. It affects other dialog elements: scrollable-container, dialog__header, and dialog__footer.
  • For testing, try BrowserStack (limited access/seats) or a local server on a real mobile device.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add robust color fallbacks for QuoteCard average-color stylingmediawiki/extensions/ReaderExperimentswmf/1.47.0-wmf.2+25 -7
Add robust color fallbacks for QuoteCard average-color stylingmediawiki/extensions/ReaderExperimentsmaster+25 -7
[WIP] Background color patch demo test on Firefoxmediawiki/extensions/ReaderExperimentsmaster+25 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

lwatson created this task.May 4 2026, 3:18 PM
SherryYang-WMF triaged this task as High priority.May 5 2026, 4:16 PM
matthiasmullie set the point value for this task to 2.May 5 2026, 4:24 PM
lwatson updated the task description. (Show Details)May 5 2026, 7:15 PM
lwatson updated the task description. (Show Details)May 5 2026, 7:18 PM
KSarabia-WMF claimed this task.May 6 2026, 4:18 PM
gerritbot added a comment.May 6 2026, 10:25 PM

Change #1283992 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[mediawiki/extensions/ReaderExperiments@master] [WIP] Background color patch demo test on Firefox

https://gerrit.wikimedia.org/r/1283992

gerritbot added a project: Patch-For-Review.May 6 2026, 10:25 PM
PatchDemoBot added a comment.May 6 2026, 10:33 PM

Test wiki created on Patch demo by KSarabia-WMF using patch(es) linked to this task:
https://522c43ec23.catalyst.wmcloud.org/w/

lwatson added a comment.EditedMay 6 2026, 11:18 PM

Hey @KSarabia-WMF - patchdemo won't work for testing the share highlights experiment. The only options I can think of are BrowserStack (which many folks, including myself, don't have access to) or a local server on a real mobile device. I'll add that to the task description.

lwatson updated the task description. (Show Details)May 6 2026, 11:20 PM
egardner moved this task from Committed to Doing on the Reader Growth Team (Sprint 3 (Apr 29 - May 12) Q4 25/26) board.May 7 2026, 4:22 PM
gerritbot added a comment.May 7 2026, 5:26 PM

Change #1284739 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[mediawiki/extensions/ReaderExperiments@master] [WIP] Background color patch demo test on Firefox

https://gerrit.wikimedia.org/r/1284739

gerritbot added a comment.May 7 2026, 11:41 PM

Change #1283992 abandoned by Kimberly Sarabia:

[mediawiki/extensions/ReaderExperiments@master] [WIP] Background color patch demo test on Firefox

Reason:

Accidentally made another gerrit patch.

https://gerrit.wikimedia.org/r/1283992

PatchDemoBot added a comment.May 7 2026, 11:41 PM

Test wiki on Patch demo by KSarabia-WMF using patch(es) linked to this task was deleted:

https://522c43ec23.catalyst.wmcloud.org/w/

PatchDemoBot added a comment.May 7 2026, 11:47 PM

Test wiki created on Patch demo by KSarabia-WMF using patch(es) linked to this task:
https://63519a14d7.catalyst.wmcloud.org/w/

matthiasmullie moved this task from Doing to Code Review on the Reader Growth Team (Sprint 3 (Apr 29 - May 12) Q4 25/26) board.May 11 2026, 3:26 PM
matthiasmullie moved this task from Code Review to QA on the Reader Growth Team (Sprint 3 (Apr 29 - May 12) Q4 25/26) board.May 12 2026, 8:14 PM
gerritbot added a comment.May 12 2026, 8:17 PM

Change #1284739 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@master] Add robust color fallbacks for QuoteCard average-color styling

https://gerrit.wikimedia.org/r/1284739

Maintenance_bot removed a project: Patch-For-Review.May 12 2026, 8:31 PM
ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.3; 2026-05-19).May 12 2026, 9:00 PM
mfossati added a project: FY2025-26 WE3.1 Engaging New Audiences.May 13 2026, 9:23 AM
gerritbot added a comment.May 13 2026, 9:40 AM

Change #1286838 had a related patch set uploaded (by Marco Fossati; author: Kimberly Sarabia):

[mediawiki/extensions/ReaderExperiments@wmf/1.47.0-wmf.2] Add robust color fallbacks for QuoteCard average-color styling

https://gerrit.wikimedia.org/r/1286838

gerritbot added a project: Patch-For-Review.May 13 2026, 9:40 AM
gerritbot added a comment.May 13 2026, 1:17 PM

Change #1286838 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@wmf/1.47.0-wmf.2] Add robust color fallbacks for QuoteCard average-color styling

https://gerrit.wikimedia.org/r/1286838

Stashbot mentioned this in T425710: Make cards fixed width.May 13 2026, 1:27 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-13T13:27:13Z] <mfossati@deploy1003> Started scap sync-world: Backport for [[gerrit:1286518|[Share Highlight] Exclude section edit links, footnotes from selection (T423658)]], [[gerrit:rEWBA128683823dcc|Add robust color fallbacks for QuoteCard average-color styling (T425358)]], [[gerrit:1286839|Fixed card width (T425710)]], [[gerrit:1286844|Adjust image size to match fixed width (T425710)]], [[gerrit:1286846|ShareHighlight: exclude browsers th

Stashbot mentioned this in T423658: shareHighlight - if headers were highlighlited, Share card shows "edit" word.May 13 2026, 1:27 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-13T13:29:09Z] <mfossati@deploy1003> jdlrobson, mfossati: Backport for [[gerrit:1286518|[Share Highlight] Exclude section edit links, footnotes from selection (T423658)]], [[gerrit:rEWBA128683823dcc|Add robust color fallbacks for QuoteCard average-color styling (T425358)]], [[gerrit:1286839|Fixed card width (T425710)]], [[gerrit:1286844|Adjust image size to match fixed width (T425710)]], [[gerrit:1286846|ShareHighlight: exclude browsers that d

Maintenance_bot removed a project: Patch-For-Review.May 13 2026, 1:31 PM
Stashbot added a comment.May 13 2026, 1:40 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-13T13:40:29Z] <mfossati@deploy1003> Finished scap sync-world: Backport for [[gerrit:1286518|[Share Highlight] Exclude section edit links, footnotes from selection (T423658)]], [[gerrit:rEWBA128683823dcc|Add robust color fallbacks for QuoteCard average-color styling (T425358)]], [[gerrit:1286839|Fixed card width (T425710)]], [[gerrit:1286844|Adjust image size to match fixed width (T425710)]], [[gerrit:1286846|ShareHighlight: exclude browsers t

ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.2; 2026-05-12); removed: MW-1.47-notes (1.47.0-wmf.3; 2026-05-19).May 13 2026, 2:00 PM
HSwan-WMF moved this task from QA to Signoff on the Reader Growth Team (Sprint 3 (Apr 29 - May 12) Q4 25/26) board.Wed, May 13, 4:08 PM
lwatson updated the task description. (Show Details)Thu, May 14, 10:52 AM
lwatson edited projects, added: Reader Growth Team (Sprint 4 (May 13 - 26) Q4 25/26); removed: Reader Growth Team (Sprint 3 (Apr 29 - May 12) Q4 25/26).Thu, May 14, 11:08 AM

Bug persists on Italian wiki: https://it.wikipedia.org/wiki/Italia?mpo=share-highlight:treatment

Share Highlight T425358 itwiki prod check.jpg (828×1,720 px, 50 KB)

Moving ticket to current sprint

lwatson closed this task as Resolved.Thu, May 14, 10:19 PM
lwatson edited projects, added: Reader Growth Team (Sprint 3 (Apr 29 - May 12) Q4 25/26); removed: Reader Growth Team (Sprint 4 (May 13 - 26) Q4 25/26).

Rechecked this bug on Italian and English wikis today on my iPhone 11, and it's resolved 😅 The card's background is the dominant average color, and the text is legible.
Moving back to the previous sprint and marking it as resolved.

PatchDemoBot added a comment.Fri, Jun 5, 5:21 PM

Test wiki on Patch demo by KSarabia-WMF using patch(es) linked to this task was deleted:

https://63519a14d7.catalyst.wmcloud.org/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits