Page MenuHomePhabricator
Create Task
Maniphest T425329

New language selector missing languages entry point suggests the source language and private-use language code
Closed, ResolvedPublic4 Estimated Story PointsBUG REPORT
Actions

Assigned To
abi_
Authored By
Nikerabbit
May 4 2026, 9:12 AM
Project Tags
Referenced Files
F86403632: image.png
Wed, Jun 3, 10:14 AM
F79828292: image.png
May 5 2026, 5:22 PM
F79601981: image.png
May 4 2026, 9:12 AM
F79601961: image.png
May 4 2026, 9:12 AM
Subscribers
Aklapper
Bugreporter
Danielyepezgarces
GiovanniPen
Hakimi97
IKhitron
ItsNyoty
View All 14 Subscribers

Description

Steps to replicate the issue (include links if applicable):

What happens?:

image.png (1,439×622 px, 138 KB)

image.png (1,439×622 px, 180 KB)

What should have happened instead?:

Source language should not be suggested.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
See also https://www.mediawiki.org/w/index.php?diff=8364746#Logic_Error_in_ULS_Rewrite:_%22Not_available%22_message_shown_for_Chinese_variants_on_Chinese_Wikipedia which may have same or different cause.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
ULS rewrite: Don't suggest private use language codes or content languagemediawiki/extensions/UniversalLanguageSelectormaster+17 -1
ULS rewrite: Add source language even if it's missingmediawiki/extensions/UniversalLanguageSelectormaster+72 -11
ULS rewrite: Get missing language list from the entrypointmediawiki/extensions/UniversalLanguageSelectormaster+29 -11
Customize query in gerrit

Related Objects

Event Timeline

Nikerabbit created this task.May 4 2026, 9:12 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 4 2026, 9:12 AM
Nikerabbit updated the task description. (Show Details)May 4 2026, 9:14 AM
Nikerabbit moved this task from Backlog to Ready for dev on the LPL Essential (FY2025-26 Q3&4) board.May 4 2026, 1:27 PM
Michael21107 awarded a token.May 4 2026, 3:52 PM
GiovanniPen subscribed.May 4 2026, 7:03 PM

actually doesn't matter the language, i got the same even in sicilian and italian wp.

Addonian1123 subscribed.May 5 2026, 11:34 AM
Addonian1123 awarded a token.May 5 2026, 11:39 AM
Addonian1123 unsubscribed.
Nikerabbit added a comment.May 5 2026, 5:22 PM

Relatedly, it's also possible to see qqx in the list:

image.png (1,080×495 px, 109 KB)

Our original idea of avoiding any delay by hosting this logic in the language selector itself needs some refinement. Is there heuristics we can apply, or can we delegate proper filtering to the code that knows what makes sense to show?

Nikerabbit triaged this task as High priority.May 7 2026, 11:34 AM
Nikerabbit set the point value for this task to 4.
gerritbot added a comment.May 7 2026, 4:16 PM

Change #1284704 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Don't suggest private use language codes

https://gerrit.wikimedia.org/r/1284704

gerritbot added a project: Patch-For-Review.May 7 2026, 4:16 PM
Bugreporter merged a task: T425774: Missing in local wiki's language (new language selector).May 9 2026, 6:38 AM
Bugreporter merged a task: T425168: Enwiki language selector on desktop site says "Missing in English".
Bugreporter merged a task: T425682: Missing in ... qqx (new language selector).
Bugreporter added a subscriber: Ponor.
Bugreporter added a subscriber: Ramkarlo82.
Bugreporter renamed this task from New language selector missing languages entry point suggests the source language to New language selector missing languages entry point suggests the source language and private-use language code.May 9 2026, 6:44 AM
Bugreporter subscribed.May 9 2026, 6:47 AM

Note: We should also make sure we should not suggest languages that does not have a wiki within the current wiki family (e.g. Wikipedia), or if such a wiki is closed.

IKhitron subscribed.May 11 2026, 1:51 PM
SCP-2000 subscribed.May 12 2026, 3:47 PM
abi_ changed the task status from Open to In Progress.May 13 2026, 2:42 PM
abi_ moved this task from Ready for dev to In Progress on the LPL Essential (FY2025-26 Q3&4) board.
gerritbot added a comment.May 13 2026, 2:47 PM

Change #1286955 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Add source language even if it's missing

https://gerrit.wikimedia.org/r/1286955

gerritbot added a comment.Thu, May 14, 5:50 AM

Change #1287287 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Get missing language list from the entrypoint

https://gerrit.wikimedia.org/r/1287287

abi_ moved this task from Backlog to In progress on the LPL Projects (ULS rewrite) board.Thu, May 14, 8:27 AM
jhsoby merged a task: T426514: English appears as missing language in Universal Language Selector when viewed from English Wikipedia.Sat, May 16, 5:08 PM
jhsoby added subscribers: Theklan, Hakimi97, Johannnes89.
Nikerabbit assigned this task to abi_.Mon, May 18, 8:19 AM
gerritbot added a comment.Wed, May 20, 12:33 PM

Change #1286955 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Add source language even if it's missing

https://gerrit.wikimedia.org/r/1286955

gerritbot added a comment.Wed, May 20, 12:33 PM

Change #1287287 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Get missing language list from the entrypoint

https://gerrit.wikimedia.org/r/1287287

abi_ moved this task from In Progress to Pending Deployment on the LPL Essential (FY2025-26 Q3&4) board.Wed, May 20, 1:06 PM
ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.4; 2026-05-26).Wed, May 20, 2:01 PM
Johannnes89 merged a task: T427121: ULS missing languages showing the current project as missing.Sat, May 23, 5:33 PM
Johannnes89 added a subscriber: ItsNyoty.
Bugreporter merged a task: T427461: Universal Language Selector rewrite incorrectly shows current wiki language as missing.Thu, May 28, 12:35 AM
Bugreporter added a subscriber: Danielyepezgarces.
Nikerabbit moved this task from Pending Deployment to In Progress on the LPL Essential (FY2025-26 Q3&4) board.Thu, May 28, 8:24 AM

@abi_ Please clarify status of the open patch before moving to pending deployment. It should either be merged, abandoned or untagged for this task.

gerritbot added a comment.Wed, Jun 3, 7:29 AM

Change #1284704 abandoned by Abijeet Patro:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Don't suggest private use language codes or content language

Reason:

Abandoned after discussion with Jon. We've taken a different approach.

https://gerrit.wikimedia.org/r/1284704

abi_ moved this task from In Progress to Pending Deployment on the LPL Essential (FY2025-26 Q3&4) board.Wed, Jun 3, 7:29 AM
abi_ added a subscriber: jhsoby.
In T425329#11962161, @Nikerabbit wrote:

@abi_ Please clarify status of the open patch before moving to pending deployment. It should either be merged, abandoned or untagged for this task.

Ack. I've abandoned the patch based after discussion with @jhsoby .

Maintenance_bot removed a project: Patch-For-Review.Wed, Jun 3, 7:30 AM
Nikerabbit moved this task from Pending Deployment to Need QA on the LPL Essential (FY2025-26 Q3&4) board.Wed, Jun 3, 10:07 AM
Nikerabbit closed this task as Resolved.Wed, Jun 3, 10:14 AM
Nikerabbit moved this task from Need QA to Done on the LPL Essential (FY2025-26 Q3&4) board.

image.png (1,519×806 px, 169 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits