Page MenuHomePhabricator

Update the element_friendly_name in PersonalDashboard Review Changes module in order to differentiate diff link clicks
Closed, ResolvedPublic2 Estimated Story Points

Description

Now that we've introduced multiple change sources in the Review Changes module we should pass the feed origin into the instrumentation so that we can interrogate the click through rate on the separate link types.

Acceptance Criteria:

  • Update instrumentation code in WikimediaEvents to differentiate an existing high risk diff link click from a watched page diff click. This can probably be done by just updating the element_friendly_name field depending on the source. That way we can still use the standard ClickThroughRateInstrument.
  • Make sure this change is documented in our instrumentation spec

Event Timeline

Kgraessle renamed this task from Add diff source to the instrumentation to Update the element_friendly_name in PersonalDashboard Review Changes module in order to differentiate diff link clicks.Apr 28 2026, 2:42 PM
Kgraessle set the point value for this task to 2.

Change #1279259 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/WikimediaEvents@master] Update the element_friendly_name in PersonalDashboard Review Changes module in order to differentiate diff link clicks

https://gerrit.wikimedia.org/r/1279259

Change #1279259 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Update the element_friendly_name in PersonalDashboard Review Changes module in order to differentiate diff link clicks

https://gerrit.wikimedia.org/r/1279259

This is not working on enwiki, @Dillon will create a follow-up patch to fix.

Change #1287021 had a related patch set uploaded (by Dillon; author: Dillon):

[mediawiki/extensions/WikimediaEvents@master] PersonalDashboard: Fix ReviewChanges/ActiveDiscussions cards selector

https://gerrit.wikimedia.org/r/1287021

Change #1287021 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] PersonalDashboard: Fix ReviewChanges/ActiveDiscussions cards selector

https://gerrit.wikimedia.org/r/1287021

jsn.sherman moved this task from QA to Done on the Moderator-Tools-Team (Kanban) board.
jsn.sherman subscribed.

verified on testwiki