Page MenuHomePhabricator
Create Task
Maniphest T424446

Space added for no reason
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue:

What happens?:

  • Wikitrapper template content, when viewed on the first page, is slightly misaligned due to extra spaces internally added for no reason
  • In its page (the latter one) the template is displayed correctly, with or without Parsoid

What should have happened instead?:
No extra space added, as it happens without using Parsoid

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Parsoid: Prevent paragraph wrapping near mw:Transclusion boundariesmediawiki/services/parsoidmaster+47 -4
Bump wikimedia/parsoid to 0.24.0-a2mediawiki/vendorwmf/1.47.0-wmf.1+14 K -14 K
Bump wikimedia/parsoid to 0.24.0-a2mediawiki/vendormaster+14 K -14 K
Fix a corner case in table attribute parsingmediawiki/services/parsoidmaster+18 -1
Customize query in gerrit

Related Objects

Mentioned In
T423241: Thumbtime for TimedMedia no longer working
T423701: Serialize ContentHolder (or at least its fragments) in ParserOutput
T373384: Parsoid doesn't properly handle double-underscore magic words
T425731: CTT tasks week of 2026-05-01
T425056: 1.46.0-wmf.26 broke itwiki's Template:Divisa calcio
T425107: __TOC__ not showing up in Parsoid on Norwegian Bokmål village pump pages
T425008: WrapSectionState crash: Wikimedia\Assert\InvariantException: Invariant failed: Expected only language variants to be missing about ids.
T420336: mw-parsoid improvements
T319058: ParserTests defaults to wgAllowExternalImages=true
T424773: __NOCONTENTCONVERT__ is not honored in Parsoid
T368724: Rendering diff on broken link with template (visual diff testing)
Mentioned Here
T319058: ParserTests defaults to wgAllowExternalImages=true
T368724: Rendering diff on broken link with template (visual diff testing)
T373384: Parsoid doesn't properly handle double-underscore magic words
T420336: mw-parsoid improvements
T423241: Thumbtime for TimedMedia no longer working
T423701: Serialize ContentHolder (or at least its fragments) in ParserOutput
T424773: __NOCONTENTCONVERT__ is not honored in Parsoid
T425008: WrapSectionState crash: Wikimedia\Assert\InvariantException: Invariant failed: Expected only language variants to be missing about ids.
T425056: 1.46.0-wmf.26 broke itwiki's Template:Divisa calcio
T425107: __TOC__ not showing up in Parsoid on Norwegian Bokmål village pump pages
T425731: CTT tasks week of 2026-05-01

Event Timeline

zdev created this task.Apr 26 2026, 4:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 26 2026, 4:31 PM
zdev updated the task description. (Show Details)Apr 26 2026, 4:32 PM
zdev added a subscriber: GiovanniPen.
gerritbot added a comment.Apr 26 2026, 5:39 PM

Change #1277268 had a related patch set uploaded (by Ayush8620; author: Ayush8620):

[mediawiki/services/parsoid@master] Parsoid: Prevent paragraph wrapping near mw:Transclusion boundaries

https://gerrit.wikimedia.org/r/1277268

gerritbot added a project: Patch-For-Review.Apr 26 2026, 5:39 PM
Ayush8620 claimed this task.Apr 26 2026, 5:40 PM
Ayush8620 subscribed.

Uploaded a patch to Gerrit to address this issue:

Review here

The fix prevents ParagraphWrapper from inserting synthetic <p> and <br> tokens
when buffered newlines occur adjacent to mw:Transclusion boundary markers.

This restores correct alignment for ASCII-art templates such as {{wikitrappen}}
during transclusion and matches legacy parser behavior.

Feedback is welcome.

Ayush8620 changed the task status from Open to In Progress.Apr 27 2026, 12:10 PM
ssastry updated the task description. (Show Details)Apr 27 2026, 4:48 PM
SomeRandomDeveloper subscribed.May 2 2026, 9:27 AM
gerritbot added a comment.May 2 2026, 2:00 PM

Change #1281784 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/services/parsoid@master] Fix a corner case in table attribute parsing

https://gerrit.wikimedia.org/r/1281784

ihurbain subscribed.May 2 2026, 2:01 PM

@SomeRandomDeveloper I have a patch which is probably correct (well, that's for a reviewer to decide), but if you want to discuss it I'm happy to :)

gerritbot added a comment.May 6 2026, 2:58 AM

Change #1281784 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Fix a corner case in table attribute parsing

https://gerrit.wikimedia.org/r/1281784

gerritbot added a comment.May 7 2026, 7:45 PM

Change #1284813 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.24.0-a2

https://gerrit.wikimedia.org/r/1284813

gerritbot added a comment.May 7 2026, 8:02 PM

Change #1284813 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.24.0-a2

https://gerrit.wikimedia.org/r/1284813

gerritbot added a comment.May 7 2026, 8:16 PM

Change #1284832 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@wmf/1.47.0-wmf.1] Bump wikimedia/parsoid to 0.24.0-a2

https://gerrit.wikimedia.org/r/1284832

gerritbot added a comment.May 7 2026, 9:07 PM

Change #1284832 merged by jenkins-bot:

[mediawiki/vendor@wmf/1.47.0-wmf.1] Bump wikimedia/parsoid to 0.24.0-a2

https://gerrit.wikimedia.org/r/1284832

Stashbot mentioned this in T368724: Rendering diff on broken link with template (visual diff testing).May 7 2026, 9:15 PM
Stashbot mentioned this in T424773: __NOCONTENTCONVERT__ is not honored in Parsoid.
Stashbot mentioned this in T319058: ParserTests defaults to wgAllowExternalImages=true.

Mentioned in SAL (#wikimedia-operations) [2026-05-07T21:15:34Z] <cscott@deploy1003> Started scap sync-world: Backport for [[gerrit:1284828|Upgrading webonyx/graphql-php (v15.31.5 => v15.32.3)]], [[gerrit:1284834|composer.json: Update webonyx/graphql-php to ^15.32.3]], [[gerrit:1284832|Bump wikimedia/parsoid to 0.24.0-a2 (T319058 T368724 T373384 T420336 T423241 T423701 T424446 T424773 T425008 T425056 T425107 T425731)]], [[gerrit:1284837|Bump wikimedia/parsoid to 0.24.0-a2 (T425731)]

Stashbot mentioned this in T420336: mw-parsoid improvements.May 7 2026, 9:15 PM
Stashbot mentioned this in T425008: WrapSectionState crash: Wikimedia\Assert\InvariantException: Invariant failed: Expected only language variants to be missing about ids..
Stashbot mentioned this in T425107: __TOC__ not showing up in Parsoid on Norwegian Bokmål village pump pages.
Stashbot mentioned this in T425056: 1.46.0-wmf.26 broke itwiki's Template:Divisa calcio.
Stashbot mentioned this in T425731: CTT tasks week of 2026-05-01.
Stashbot mentioned this in T373384: Parsoid doesn't properly handle double-underscore magic words.
Stashbot mentioned this in T423701: Serialize ContentHolder (or at least its fragments) in ParserOutput.
Stashbot mentioned this in T423241: Thumbtime for TimedMedia no longer working.

Mentioned in SAL (#wikimedia-operations) [2026-05-07T21:17:28Z] <cscott@deploy1003> cscott: Backport for [[gerrit:1284828|Upgrading webonyx/graphql-php (v15.31.5 => v15.32.3)]], [[gerrit:1284834|composer.json: Update webonyx/graphql-php to ^15.32.3]], [[gerrit:1284832|Bump wikimedia/parsoid to 0.24.0-a2 (T319058 T368724 T373384 T420336 T423241 T423701 T424446 T424773 T425008 T425056 T425107 T425731)]], [[gerrit:1284837|Bump wikimedia/parsoid to 0.24.0-a2 (T425731)]] synced to the t

Stashbot added a comment.May 7 2026, 9:27 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-07T21:27:35Z] <cscott@deploy1003> Finished scap sync-world: Backport for [[gerrit:1284828|Upgrading webonyx/graphql-php (v15.31.5 => v15.32.3)]], [[gerrit:1284834|composer.json: Update webonyx/graphql-php to ^15.32.3]], [[gerrit:1284832|Bump wikimedia/parsoid to 0.24.0-a2 (T319058 T368724 T373384 T420336 T423241 T423701 T424446 T424773 T425008 T425056 T425107 T425731)]], [[gerrit:1284837|Bump wikimedia/parsoid to 0.24.0-a2 (T425731)

ihurbain claimed this task.May 11 2026, 3:24 PM
ihurbain edited projects, added: Content-Transform-Team (Work In Progress); removed: Patch-For-Review.
ihurbain moved this task from Backlog to To Deploy on the Content-Transform-Team (Work In Progress) board.
ABreault-WMF closed this task as Resolved.Fri, May 22, 10:30 PM
ABreault-WMF moved this task from To Deploy to To Verify on the Content-Transform-Team (Work In Progress) board.
ABreault-WMF subscribed.

Post-deploy and purge the ASCII art looks the same,
https://it.wikipedia.org/wiki/Wikipedia:Scherzi_e_STUBidaggini/WikiTrapper?useparsoid=0
https://it.wikipedia.org/wiki/Wikipedia:Scherzi_e_STUBidaggini/WikiTrapper?useparsoid=1

gerritbot added a comment.Fri, May 22, 10:31 PM

Change #1277268 abandoned by Arlolra:

[mediawiki/services/parsoid@master] Parsoid: Prevent paragraph wrapping near mw:Transclusion boundaries

Reason:

T424446 has now been resolved

https://gerrit.wikimedia.org/r/1277268

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits