Feature summary:
Although patrol actions are recorded in logging, they don't appear to leave any trace in the CheckUser logs. Without integration with CheckUser, we have to rely on other data points, which limits how thoroughly we can investigate potential misuse of the patrolling system.
This can be particularly problematic if a sockmaster is creative enough to know what they're doing…
+1, this would be a welcome addition to the toolset. Since autopatrol is already excluded (T184485), hooking into MarkPatrolledComplete and writing to cu_log_event like the existing LocalUserCreated handler should keep the overhead low.
Change #1281490 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/CheckUser@master] Rename CheckUserPrivateEventsHandler to CheckUserEventsHandler
MarkPatrolledComplete doesn't pass the associated log ID, so we will need to update that to pass it to the hook handlers
Perhaps PatrolLog::record() could return the $logid instead of bool, so it can be forwarded to the hook directly?
Change #1281507 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/core@master] Move PatrolLog::record to PatrolManager
Change #1281524 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/core@master] Replace MarkPatrolledComplete with MarkPatrolledAudit
Change #1281525 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/core@master] Hard deprecate the MarkPatrolledComplete hook
Change #1281490 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Rename CheckUserPrivateEventsHandler to CheckUserEventsHandler
Change #1281531 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/PageTriage@master] PageTriage: Use PatrolManager over deprecated method calls
Change #1281507 merged by jenkins-bot:
[mediawiki/core@master] Move PatrolLog::record to PatrolManager
Change #1281535 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/PageTriage@master] Replace deprecated MarkPatrolledComplete hook
Change #1281524 merged by jenkins-bot:
[mediawiki/core@master] Replace MarkPatrolledComplete with MarkPatrolledAudit
Change #1281531 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] PageTriage: Use PatrolManager over deprecated method calls
Change #1281617 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/CheckUser@master] Log patrol events in CheckUser
Change #1281535 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Replace deprecated MarkPatrolledComplete hook
Change #1281525 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate the MarkPatrolledComplete hook
Change #1281617 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Log patrol events in CheckUser
Entries exist in testwiki:
(testwiki)> select log_id, log_type, log_action from cu_log_event join logging on log_id = cule_log_id where log_type = 'patrol'; +--------+----------+------------+ | log_id | log_type | log_action | +--------+----------+------------+ | 463097 | patrol | patrol | | 463120 | patrol | patrol | | 463155 | patrol | patrol | +--------+----------+------------+