Page MenuHomePhabricator
Create Task
Maniphest T424325

EntitySchema daily CI broken by deprecation of SpecialPage constructor parameters
Closed, ResolvedPublic
Actions

Description

https://github.com/wikimedia/mediawiki-extensions-EntitySchema/actions/runs/24875478161/job/72831003102

There were 27 errors:

1) EntitySchema\Tests\Integration\MediaWiki\Specials\EntitySchemaTextTest::testExistingSchema
Use of MediaWiki\SpecialPage\SpecialPage constructor parameters $restriction, $listed, $function, $file and $includable was deprecated in MediaWiki 1.46. [Called from EntitySchema\MediaWiki\Specials\EntitySchemaText::__construct in /home/runner/work/mediawiki-extensions-EntitySchema/mediawiki/extensions/EntitySchema/src/MediaWiki/Specials/EntitySchemaText.php at line 23]

/home/runner/work/mediawiki-extensions-EntitySchema/mediawiki/includes/Debug/MWDebug.php:372
/home/runner/work/mediawiki-extensions-EntitySchema/mediawiki/includes/Debug/MWDebug.php:342
/home/runner/work/mediawiki-extensions-EntitySchema/mediawiki/includes/Debug/MWDebug.php:224
/home/runner/work/mediawiki-extensions-EntitySchema/mediawiki/includes/GlobalFunctions.php:525
/home/runner/work/mediawiki-extensions-EntitySchema/mediawiki/includes/SpecialPage/SpecialPage.php:215
/home/runner/work/mediawiki-extensions-EntitySchema/mediawiki/extensions/EntitySchema/src/MediaWiki/Specials/EntitySchemaText.php:23
/home/runner/work/mediawiki-extensions-EntitySchema/mediawiki/extensions/EntitySchema/tests/phpunit/integration/MediaWiki/Specials/EntitySchemaTextTest.php:80
/home/runner/work/mediawiki-extensions-EntitySchema/mediawiki/tests/phpunit/includes/Specials/SpecialPageTestBase.php:84
/home/runner/work/mediawiki-extensions-EntitySchema/mediawiki/extensions/EntitySchema/tests/phpunit/integration/MediaWiki/Specials/EntitySchemaTextTest.php:47

…

Presumably T416793’s fault.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Override SpecialPage::getRestriction to avoid deprecation warningmediawiki/extensions/EntitySchemamaster+15 -12
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Apr 24 2026, 10:31 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 24 2026, 10:31 AM
Lucas_Werkmeister_WMDE mentioned this in T414989: Wikibase and EntitySchema secondary CI broken: outdated PHP version (8.1).Apr 24 2026, 10:33 AM
Lucas_Werkmeister_WMDE added a project: ci-test-error (WMF-deployed Build Failure).
Lucas_Werkmeister_WMDE added a project: Wikidata-Omega (The Board).Apr 24 2026, 10:39 AM
gerritbot added a comment.Apr 24 2026, 10:41 AM

Change #1277066 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/EntitySchema@master] EntitySchemaText: Override ::getRestriction to avoid deprecation warning

https://gerrit.wikimedia.org/r/1277066

gerritbot added a project: Patch-For-Review.Apr 24 2026, 10:41 AM
Lucas_Werkmeister_WMDE moved this task from new to the board to Ready for Peer Review on the Wikidata-Omega (The Board) board.Apr 24 2026, 10:49 AM
gerritbot added a comment.Apr 24 2026, 11:06 AM

Change #1277066 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Override SpecialPage::getRestriction to avoid deprecation warning

https://gerrit.wikimedia.org/r/1277066

Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to Ready for Tech Verification on the Wikidata-Omega (The Board) board.Apr 24 2026, 11:11 AM

Should be fixed (thanks to Fomafix for the review); we can check on Monday if the next daily builds worked or not.

Maintenance_bot added a project: Wikidata.Apr 24 2026, 11:29 AM
Maintenance_bot removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.26; 2026-04-28).Apr 24 2026, 12:00 PM
mahmoud.abdelsattar.wmde subscribed.Apr 28 2026, 7:51 AM

TV: Looks like the provided solution worked, the issue was not triggered again.
Thank you!

mahmoud.abdelsattar.wmde closed this task as Resolved.Apr 28 2026, 7:51 AM
mahmoud.abdelsattar.wmde claimed this task.
mahmoud.abdelsattar.wmde moved this task from Ready for Tech Verification to Done - Moving a task here will move it to the completed tasks workboard, resolve the ticket, and assign it to whomever made the move on the Wikidata-Omega (The Board) board.
mahmoud.abdelsattar.wmde edited projects, added: Wikidata-Omega (Completed Tasks); removed: Wikidata-Omega (The Board).
karapayneWMDE moved this task from Newly completed tasks to 2026 Q2 on the Wikidata-Omega (Completed Tasks) board.May 4 2026, 8:05 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits