Page MenuHomePhabricator

EntitySchema daily CI broken by deprecation of SpecialPage constructor parameters
Closed, ResolvedPublic

Description

https://github.com/wikimedia/mediawiki-extensions-EntitySchema/actions/runs/24875478161/job/72831003102

There were 27 errors:

1) EntitySchema\Tests\Integration\MediaWiki\Specials\EntitySchemaTextTest::testExistingSchema
Use of MediaWiki\SpecialPage\SpecialPage constructor parameters $restriction, $listed, $function, $file and $includable was deprecated in MediaWiki 1.46. [Called from EntitySchema\MediaWiki\Specials\EntitySchemaText::__construct in /home/runner/work/mediawiki-extensions-EntitySchema/mediawiki/extensions/EntitySchema/src/MediaWiki/Specials/EntitySchemaText.php at line 23]

/home/runner/work/mediawiki-extensions-EntitySchema/mediawiki/includes/Debug/MWDebug.php:372
/home/runner/work/mediawiki-extensions-EntitySchema/mediawiki/includes/Debug/MWDebug.php:342
/home/runner/work/mediawiki-extensions-EntitySchema/mediawiki/includes/Debug/MWDebug.php:224
/home/runner/work/mediawiki-extensions-EntitySchema/mediawiki/includes/GlobalFunctions.php:525
/home/runner/work/mediawiki-extensions-EntitySchema/mediawiki/includes/SpecialPage/SpecialPage.php:215
/home/runner/work/mediawiki-extensions-EntitySchema/mediawiki/extensions/EntitySchema/src/MediaWiki/Specials/EntitySchemaText.php:23
/home/runner/work/mediawiki-extensions-EntitySchema/mediawiki/extensions/EntitySchema/tests/phpunit/integration/MediaWiki/Specials/EntitySchemaTextTest.php:80
/home/runner/work/mediawiki-extensions-EntitySchema/mediawiki/tests/phpunit/includes/Specials/SpecialPageTestBase.php:84
/home/runner/work/mediawiki-extensions-EntitySchema/mediawiki/extensions/EntitySchema/tests/phpunit/integration/MediaWiki/Specials/EntitySchemaTextTest.php:47

…

Presumably T416793’s fault.

Event Timeline

Change #1277066 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/EntitySchema@master] EntitySchemaText: Override ::getRestriction to avoid deprecation warning

https://gerrit.wikimedia.org/r/1277066

Change #1277066 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Override SpecialPage::getRestriction to avoid deprecation warning

https://gerrit.wikimedia.org/r/1277066

Should be fixed (thanks to Fomafix for the review); we can check on Monday if the next daily builds worked or not.

TV: Looks like the provided solution worked, the issue was not triggered again.
Thank you!