Page MenuHomePhabricator
Create Task
Maniphest T424313

[MEX] Fixing the failed editTimeDatatype.cy.ts after Codex 2.5.0 upgrade
Closed, ResolvedPublic
Actions

Description

After upgrading Codex to 2.5.0, the test cypress/e2e/wbui2025/editTimeDatatype.cy.ts fails.

There is a patch created to comment-out the failed lines, but that should not be the solution.

Something must have changed between Codex 2.4.0 and 2.5.0 that causes the input to not be cleared, and the test expects "156" but gets
"12 CE156". I can't figure out why this happens, so disabling this test for now to unblock the Codex release.

Acceptance criteria:

  • Investigate the root cause of the failed test after upgrading to Codex 2.5.0.
  • Implement a proper solution that fixes the root cause of the failed test.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update Codex from v2.4.0 to v2.5.1mediawiki/coremaster+1 K -455
useFocusTrap: Don't move focus away from elements inside the anchordesign/codexmain+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

mahmoud.abdelsattar.wmde created this task.Apr 24 2026, 7:22 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 24 2026, 7:22 AM
ArthurTaylor subscribed.Apr 24 2026, 7:25 AM

Did a git bisect to track down the breaking change: https://gerrit.wikimedia.org/r/c/design/codex/+/1233683

ArthurTaylor claimed this task.Apr 24 2026, 7:27 AM
ArthurTaylor moved this task from Incoming to The Board on the Wikidata-Omega board.
ArthurTaylor edited projects, added: Wikidata-Omega (The Board); removed: Wikidata-Omega.
ArthurTaylor moved this task from new to the board to In Development on the Wikidata-Omega (The Board) board.
Lucas_Werkmeister_WMDE subscribed.Apr 24 2026, 8:21 AM

Does this also have an impact on users, or is it just affecting the test? (I.e. should this be a train blocker for T423877?)

ArthurTaylor added a comment.EditedApr 24 2026, 8:29 AM

It doesn't seem to have any real-world effect. I think it might just be a race between the popover and cypress to get the focus when the popover opens - users probably can't click fast enough to have an issue. But I'm still investigating.

Michael subscribed.Apr 24 2026, 9:53 AM
ArthurTaylor added a comment.Apr 24 2026, 9:59 AM

Correction - I do see the issue in manual testing. in 2.4.0, the editTimeSnakValue main snak input field would focus on click. With 2.5.0 it no longer does - the focus is high-jacked. I'm working on a minimal reproduction.

ArthurTaylor added a comment.Apr 24 2026, 11:05 AM

I've created a Gitlab repo here that has a simple reproduction of the issue. The problem seems to be with nested pop-ups. The behaviour seems different in 2.5.0 in significant ways, which seem like they could definitely be a result of the gerrit patch mentioned above.

Lucas_Werkmeister_WMDE added a comment.Apr 24 2026, 11:22 AM
In T424313#11854917, @ArthurTaylor wrote:

I've created a Gitlab repo here that has a simple reproduction of the issue.

Can confirm that this seems to reproduce the issue. (Note that if you’re using Fresh, you need to make sure you’re using the latest version first, and then use at least fresh-node22, not the default fresh-node = fresh-node20.)

gerritbot added a comment.Apr 24 2026, 6:49 PM

Change #1277169 had a related patch set uploaded (by Catrope; author: Catrope):

[design/codex@main] useFocusTrap: Don't move focus away from elements inside the anchor

https://gerrit.wikimedia.org/r/1277169

gerritbot added a project: Patch-For-Review.Apr 24 2026, 6:49 PM
Catrope subscribed.Apr 24 2026, 6:49 PM

Thank you, this was really helpful! It allowed me to track down the bug and upload a fix. I'll get this reviewed soon and do a follow-up release (2.5.1).

gerritbot added a comment.Apr 24 2026, 7:08 PM

Change #1277169 merged by jenkins-bot:

[design/codex@main] useFocusTrap: Don't move focus away from elements inside the anchor

https://gerrit.wikimedia.org/r/1277169

gerritbot added a comment.Apr 24 2026, 7:22 PM

Change #1277176 had a related patch set uploaded (by Catrope; author: Catrope):

[design/codex@main] useFocusTrap: Add comment with task number for T424313

https://gerrit.wikimedia.org/r/1277176

gerritbot added a comment.Apr 24 2026, 8:07 PM

Change #1277176 merged by jenkins-bot:

[design/codex@main] useFocusTrap, docs: Add comment with task number for T424313

https://gerrit.wikimedia.org/r/1277176

Maintenance_bot removed a project: Patch-For-Review.Apr 24 2026, 8:30 PM
gerritbot added a comment.Apr 24 2026, 9:14 PM

Change #1275555 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update Codex from v2.4.0 to v2.5.1

https://gerrit.wikimedia.org/r/1275555

gerritbot added a project: Patch-For-Review.Apr 24 2026, 9:14 PM
gerritbot added a comment.Apr 24 2026, 11:06 PM

Change #1275555 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v2.4.0 to v2.5.1

https://gerrit.wikimedia.org/r/1275555

Maintenance_bot removed a project: Patch-For-Review.Apr 24 2026, 11:32 PM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.26; 2026-04-28).Apr 25 2026, 12:00 AM
ArthurTaylor removed ArthurTaylor as the assignee of this task.Apr 27 2026, 7:59 AM
ArthurTaylor moved this task from In Development to Ready for Tech Verification on the Wikidata-Omega (The Board) board.
mahmoud.abdelsattar.wmde added a comment.May 5 2026, 8:20 AM

TV: The applied solution works. a fix for 2.5.1 was also applied which seems to fix the issue.
Thank you!

mahmoud.abdelsattar.wmde closed this task as Resolved.May 5 2026, 8:21 AM
mahmoud.abdelsattar.wmde claimed this task.
mahmoud.abdelsattar.wmde moved this task from Ready for Tech Verification to Done - Moving a task here will move it to the completed tasks workboard, resolve the ticket, and assign it to whomever made the move on the Wikidata-Omega (The Board) board.
mahmoud.abdelsattar.wmde edited projects, added: Wikidata-Omega (Completed Tasks); removed: Wikidata-Omega (The Board).
karapayneWMDE moved this task from Newly completed tasks to 2026 Q2 on the Wikidata-Omega (Completed Tasks) board.May 5 2026, 3:13 PM
karapayneWMDE added a parent task: T394621: [MEX] Mobile Editing Experience of Items Project.May 6 2026, 2:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits