Page MenuHomePhabricator

ReadingLists tests are failing on Jenkins in `quibble-vendor-mysql-php85`
Closed, ResolvedPublic

Description

Tests are failing for ReadingLists with php 8.5. In some of the Rest API tests, they allow null as an array offset, which is something that is now deprecated in php 8.5.

This is blocking merging any patches in the ReadingLists extension.

13:49:37 1) MediaWiki\Extension\ReadingLists\Tests\Integration\Rest\ListsEntriesCreateBatchHandlerTest::testListsEntriesCreateFailure with data set "no params" (null, array())
13:49:37 Using null as an array offset is deprecated, use an empty string instead
13:49:37 
13:49:37 /workspace/src/extensions/ReadingLists/tests/phpunit/integration/Rest/ListsEntriesCreateBatchHandlerTest.php:148
13:49:37 
13:49:37 2) MediaWiki\Extension\ReadingLists\Tests\Integration\Rest\ListsEntriesCreateBatchHandlerTest::testListsEntriesCreateFailure with data set "missing id" (null, array('foo', 'Lassie'))
13:49:37 Using null as an array offset is deprecated, use an empty string instead
13:49:37 
13:49:37 /workspace/src/extensions/ReadingLists/tests/phpunit/integration/Rest/ListsEntriesCreateBatchHandlerTest.php:148
13:49:37 
13:49:37 3) MediaWiki\Extension\ReadingLists\Tests\Integration\Rest\ListsEntriesCreateHandlerTest::testListsEntriesCreateFailure with data set "no params" (null, array())
13:49:37 Using null as an array offset is deprecated, use an empty string instead
13:49:37 
13:49:37 /workspace/src/extensions/ReadingLists/tests/phpunit/integration/Rest/ListsEntriesCreateHandlerTest.php:130
13:49:37 
13:49:37 4) MediaWiki\Extension\ReadingLists\Tests\Integration\Rest\ListsEntriesCreateHandlerTest::testListsEntriesCreateFailure with data set "missing id" (null, array('foo', 'Lassie'))
13:49:37 Using null as an array offset is deprecated, use an empty string instead
13:49:37 
13:49:37 /workspace/src/extensions/ReadingLists/tests/phpunit/integration/Rest/ListsEntriesCreateHandlerTest.php:130

Event Timeline

Change #1276757 had a related patch set uploaded (by Aude; author: Aude):

[mediawiki/extensions/ReadingLists@master] Fix php 8.5 test issue with null array offset

https://gerrit.wikimedia.org/r/1276757

aude renamed this task from ReadingLists extension is failing on Jenkins in `quibble-vendor-mysql-php85` to ReadingLists tests are failing on Jenkins in `quibble-vendor-mysql-php85`.Apr 23 2026, 7:26 PM

Change #1276757 merged by jenkins-bot:

[mediawiki/extensions/ReadingLists@master] Fix PHP 8.5 test issue with `null` array offset

https://gerrit.wikimedia.org/r/1276757

Reedy assigned this task to aude.