Page MenuHomePhabricator

Add support for Minerva skin in ULS Rewrite
Closed, ResolvedPublic4 Estimated Story Points

Description

Currently the ULS rewrite only supports Vector 2022 theme. Add support for the Minerva theme.

Event Timeline

Change #1275558 had a related patch set uploaded (by Abijeet Patro; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Support new ULS rewrite

https://gerrit.wikimedia.org/r/1275558

Change #1276415 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/UniversalLanguageSelector@master] Add support for Minerva theme

https://gerrit.wikimedia.org/r/1276415

Change #1275558 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Support new ULS rewrite

https://gerrit.wikimedia.org/r/1275558

Change #1276415 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Add support for Minerva theme

https://gerrit.wikimedia.org/r/1276415

Nikerabbit subscribed.

Seems to be working fine.

One tweak I would suggest is to anchor on opposite corner on inline direction by default, so that it looks more polished. Currently when using minerva skin on larger screen, it can look like this

image.png (462×578 px, 48 KB)

Change #1286537 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Anchor content language selector to bottom-end for minerva

https://gerrit.wikimedia.org/r/1286537

Seems to be working fine.

One tweak I would suggest is to anchor on opposite corner on inline direction by default, so that it looks more polished. Currently when using minerva skin on larger screen, it can look like this

image.png (462×578 px, 48 KB)

Thanks, fixed in latest patch:

image.png (1,363×1,130 px, 114 KB)

It's working in articles but not on the main page. I'm happy to file a separate bug report if you like.

Steps to reproduce:

IMG_2832.png (750×1,334 px, 151 KB)

Change #1286537 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Anchor content language selector to bottom-end for minerva

https://gerrit.wikimedia.org/r/1286537

Nikerabbit moved this task from Need QA to Done on the LPL Essential (FY2025-26 Q3&4) board.

Works fine, apart from the main pages. Opening separate task for that.