| DSmit-WMF | |
| Apr 21 2026, 2:41 PM |
| F77138540: Screenshot 2026-04-21 at 15.17.28.png | |
| Apr 21 2026, 2:41 PM |
Steps to replicate the issue (include links if applicable):
What happens?:
Too much white space between the various paragraph() functions
 |
What should have happened instead?:
Less whitesace , default wiki behaviour of the margins.
This is because of the <span> </span>. which works great on inline elements but not for paragraphs
Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
Other information (browser name/version, screenshots, etc.):
Every AbstractPreviewFragment component appends a <span> </span> after its output. This acts as a word separator between inline fragments, but when a fragment renders a block-level element (e.g. paragraph() → <p>…</p>), the adds extra whitespace on top of the paragraph's own CSS margins — causing the double spacing.
Parse the rendered HTML and check whether the last top-level element is block-level (p, div, h1–h6, etc.). If so, omit the .
We check the last child because the follows the fragment output, so only the trailing element's display context matters.
This can be done with DOMParser at computed-property time. However, this is not great: DOMParser does not apply stylesheets, so if any CSS overrides the display of a tag (e.g. p { display: inline }), the check gives the wrong answer. The only fully reliable solution would be to call window.getComputedStyle() on the real DOM node after render — which adds significant reactivity complexity for a theoretical edge case.
Remove <span> </span> and rely on function authors to insert correct whitespace in their output. Inline fragments that need a space between them would include it; block-level fragments like paragraph() handle their own spacing via CSS margins. This is simpler and unambiguously correct — but requires auditing all existing inline fragment functions to confirm they produce appropriate surrounding whitespace.
I propose the community adds a 'non-breaking html seperator function' , which returns a Z89 with <span> </span> and include this whenever needed -> WIP Patch if approved can go
Change #1275953 had a related patch set uploaded (by Daphne Smit; author: Daphne Smit):
[mediawiki/extensions/WikiLambda@master] abstract: Remove inline separator from AbstractPreviewFragment
Change #1275953 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@master] abstract: Remove inline separator from AbstractPreviewFragment