Page MenuHomePhabricator
Create Task
Maniphest T423889

Remove onConditionalDefaultOptionsAddCondition hook
Closed, ResolvedPublic
Actions

Description

This hook was introduced in the past to support some advanced experimentation needs of the Growth Team in our bespoke experimentation setup.
However, with TestKitchen having replaced that custom system, this hook is no longer needed. Given that it is an undocumented (T383702) and complex hook in a complex feature, it seems simpler to drop it again instead of keeping it around and paying the associated maintenance overhead when we don't actually have a use for it.

Acceptance criteria:

  • All known users removed
  • The hook is deprecated (in MW 1.46)
  • the ConditionalDefaultOptionsAddCondition hook has been removed from core again (in MW 1.47+) release notes

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add release notes entry for ConditionalDefaultOptionsAddConditionHook removalmediawiki/coremaster+2 -0
Remove ConditionalDefaultOptionsAddConditionHookmediawiki/coremaster+3 -126
Hard-deprecate the onConditionalDefaultOptionsAddCondition hookmediawiki/coremaster+5 -1
Customize query in gerrit

Related Objects

Event Timeline

Michael created this task.Apr 20 2026, 3:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2026, 3:21 PM
Michael triaged this task as Low priority.Apr 20 2026, 3:21 PM
Michael updated the task description. (Show Details)
Michael mentioned this in T383702: Document onConditionalDefaultOptionsAddCondition under mw:Manual:Hooks.
Michael moved this task from Inbox to Needs Refinement on the Growth-Team board.
Michael moved this task from Backlog to Unused code removal & deprecations on the Growth Team Maintenance board.
Jdforrester-WMF subscribed.Apr 20 2026, 3:25 PM

Despite being undocumented on MW.org, your team chose to document it in the code including the * @stable to implement which means you need to follow the https://www.mediawiki.org/wiki/Stable_interface_policy to deprecate and then remove it

Urbanecm_WMF claimed this task.Apr 21 2026, 2:19 PM
Urbanecm_WMF raised the priority of this task from Low to High.
Urbanecm_WMF edited projects, added: Growth-Team (FY2025-26 Q4 Sprint 2); removed: Growth-Team.
Urbanecm_WMF subscribed.

In the light of what James said, let's get this started now, to avoid having to wait N more months.

gerritbot added a comment.Apr 21 2026, 3:36 PM

Change #1275962 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@master] Hard-deprecate the onConditionalDefaultOptionsAddCondition hook

https://gerrit.wikimedia.org/r/1275962

gerritbot added a project: Patch-For-Review.Apr 21 2026, 3:36 PM

Change #1275963 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@master] Remove ConditionalDefaultOptionsAddConditionHook

https://gerrit.wikimedia.org/r/1275963

gerritbot added a comment.Apr 21 2026, 4:37 PM

Change #1275962 merged by jenkins-bot:

[mediawiki/core@master] Hard-deprecate the onConditionalDefaultOptionsAddCondition hook

https://gerrit.wikimedia.org/r/1275962

Jdforrester-WMF updated the task description. (Show Details)Apr 21 2026, 4:43 PM
Sgs moved this task from Incoming to Code Review on the Growth-Team (FY2025-26 Q4 Sprint 2) board.Apr 21 2026, 4:48 PM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.26; 2026-04-28).Apr 21 2026, 5:00 PM
Sgs moved this task from Code Review to QA on the Growth-Team (FY2025-26 Q4 Sprint 2) board.Apr 21 2026, 5:01 PM
Michael added a project: Technical-Debt (Deprecation process).Apr 21 2026, 5:11 PM
Urbanecm_WMF lowered the priority of this task from High to Medium.May 3 2026, 9:03 PM
Urbanecm_WMF moved this task from QA to Code Review on the Growth-Team (FY2025-26 Q4 Sprint 2) board.
gerritbot added a comment.May 4 2026, 6:10 PM

Change #1275963 merged by jenkins-bot:

[mediawiki/core@master] Remove ConditionalDefaultOptionsAddConditionHook

https://gerrit.wikimedia.org/r/1275963

Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (FY2025-26 Q4 Sprint 2) board.May 4 2026, 6:11 PM
Maintenance_bot removed a project: Patch-For-Review.May 4 2026, 6:30 PM
ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.1; 2026-05-05).May 4 2026, 7:00 PM
SomeRandomDeveloper subscribed.May 5 2026, 7:58 PM
gerritbot added a comment.May 5 2026, 8:00 PM

Change #1283089 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/core@master] Add release notes entry for ConditionalDefaultOptionsAddConditionHook removal

https://gerrit.wikimedia.org/r/1283089

gerritbot added a project: Patch-For-Review.May 5 2026, 8:00 PM
gerritbot added a comment.May 7 2026, 9:34 PM

Change #1283089 merged by jenkins-bot:

[mediawiki/core@master] Add release notes entry for ConditionalDefaultOptionsAddConditionHook removal

https://gerrit.wikimedia.org/r/1283089

ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.2; 2026-05-12); removed: MW-1.47-notes (1.47.0-wmf.1; 2026-05-05).May 7 2026, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 7 2026, 10:30 PM
Etonkovidova moved this task from QA to Test in Production on the Growth-Team (FY2025-26 Q4 Sprint 2) board.May 8 2026, 7:16 PM
DMburugu closed this task as Resolved.Mon, May 18, 9:15 AM
DMburugu updated the task description. (Show Details)
DMburugu subscribed.

@Urbanecm_WMF This is ready to be resolved based on the release notes here. Feel free to reopen if necessary.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits